diff mbox

[dpdk-dev,v2,1/1] ethdev: remove the imissed deprecation tag

Message ID 1445337258-6101-1-git-send-email-maryam.tahhan@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Tahhan, Maryam Oct. 20, 2015, 10:34 a.m. UTC 
  Remove the deprecation tag and notice for imissed as it is a generic
register that accounts for packets that were dropped by the HW,
because there are no available mbufs (RX queues are full). imissed is
different to ierrors and can help with general debug.

Fixes: 49f386542af4 ("ethdev: remove driver specific stats")

Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
---
v2:
 - Clarify why imissed is no longer deprecated.
 - Improve definition of imissed in the documentation.
---
 doc/guides/rel_notes/deprecation.rst | 2 +-
 lib/librte_ether/rte_ethdev.h        | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

Comments

Thomas Monjalon Nov. 2, 2015, 11:41 p.m. UTC | #1 
2015-10-20 11:34, Maryam Tahhan:
> Remove the deprecation tag and notice for imissed as it is a generic
> register that accounts for packets that were dropped by the HW,
> because there are no available mbufs (RX queues are full). imissed is
> different to ierrors and can help with general debug.
> 
> Fixes: 49f386542af4 ("ethdev: remove driver specific stats")
> 
> Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
> ---
> v2:
>  - Clarify why imissed is no longer deprecated.
>  - Improve definition of imissed in the documentation.
> ---

Applied, thanks
diff mbox

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index fa55117..c4babbd 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -14,7 +14,7 @@  Deprecation Notices
   All binaries will need to be rebuilt from release 2.2.
 
 * The following fields have been deprecated in rte_eth_stats:
-  imissed, ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss,
+  ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss,
   tx_pause_xon, rx_pause_xon, tx_pause_xoff, rx_pause_xoff
 
 * ABI changes are planned for struct rte_eth_fdir_flow_ext in order to support
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 8a8c82b..d404f85 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -195,7 +195,9 @@  struct rte_eth_stats {
 	uint64_t ibytes;    /**< Total number of successfully received bytes. */
 	uint64_t obytes;    /**< Total number of successfully transmitted bytes. */
 	uint64_t imissed;
-	/**< Deprecated; Total of RX missed packets (e.g full FIFO). */
+	/**< Total of RX missed packets (packets that were dropped by the HW,
+	 * because there are no available mbufs i.e. RX queues are full).
+	 */
 	uint64_t ibadcrc;
 	/**< Deprecated; Total of RX packets with CRC error. */
 	uint64_t ibadlen;