diff mbox

[dpdk-dev,v6,2/9] null: fix segfault when null_pmd added to bonding

Message ID 1444989651-6236-3-git-send-email-tomaszx.kulasek@intel.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Tomasz Kulasek Oct. 16, 2015, 10 a.m. UTC 
  This patch initializes eth_dev->link_intr_cbs queue used when null pmd is
added to the bonding.

v5 changes:
 - removed unnecessary malloc for eth_driver (rte_null_pmd)

Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
---
 drivers/net/null/rte_eth_null.c |    2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Monjalon Oct. 27, 2015, 4:58 p.m. UTC | #1 
Hi,
There is no change in v6 for this patch which was acked by Tetsuya.
So why not keep the Acked-by below your Signed-off-by?

It seems patches 2, 3, 4 and 5 were Acked by Tetsuya.
Other acks I'm missing?


2015-10-16 12:00, Tomasz Kulasek:
> This patch initializes eth_dev->link_intr_cbs queue used when null pmd is
> added to the bonding.
> 
> v5 changes:
>  - removed unnecessary malloc for eth_driver (rte_null_pmd)
> 
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Tomasz Kulasek Oct. 28, 2015, 1:43 p.m. UTC | #2 
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, October 27, 2015 17:59
> To: Kulasek, TomaszX
> Cc: dev@dpdk.org; Tetsuya Mukawa
> Subject: Re: [dpdk-dev] [PATCH v6 2/9] null: fix segfault when null_pmd
> added to bonding
> 
> Hi,
> There is no change in v6 for this patch which was acked by Tetsuya.
> So why not keep the Acked-by below your Signed-off-by?
> 
> It seems patches 2, 3, 4 and 5 were Acked by Tetsuya.
> Other acks I'm missing?
> 

Hi,

Patches 4 and 5 were changed due to the Tetsuya's suggestions and already reviewed. There are not big changes, but I'm not sure if it should be reacked by Tetsuya, or I can just copy ack?

Tomasz
Tetsuya Mukawa Oct. 29, 2015, 7:19 a.m. UTC | #3 
On 2015/10/28 22:43, Kulasek, TomaszX wrote:
>> -----Original Message-----
>> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
>> Sent: Tuesday, October 27, 2015 17:59
>> To: Kulasek, TomaszX
>> Cc: dev@dpdk.org; Tetsuya Mukawa
>> Subject: Re: [dpdk-dev] [PATCH v6 2/9] null: fix segfault when null_pmd
>> added to bonding
>>
>> Hi,
>> There is no change in v6 for this patch which was acked by Tetsuya.
>> So why not keep the Acked-by below your Signed-off-by?
>>
>> It seems patches 2, 3, 4 and 5 were Acked by Tetsuya.
>> Other acks I'm missing?
>>
> Hi,
>
> Patches 4 and 5 were changed due to the Tetsuya's suggestions and already reviewed. There are not big changes, but I'm not sure if it should be reacked by Tetsuya, or I can just copy ack?
>
> Tomasz

Hi Tomasz,

Could you please check Bernard's patch series?
 - [PATCH v5 00/28] remove pci driver from vdevs
He tries to remove pci_drv from PMD.

It seems your below patch will be affected by his patch.
 - null: fix segfault when null_pmd added to bonding

I just wonder your bonding RSS patch works without below fixing.
drivers/net/null/rte_eth_null.c :
+       pci_dev->driver = &rte_null_pmd.pci_drv;

Anyway, Could you please check him patches?

Thanks,
Tetsuya
Tomasz Kulasek Oct. 30, 2015, 1:50 p.m. UTC | #4 
> -----Original Message-----
> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp]
> Sent: Thursday, October 29, 2015 08:19
> To: Kulasek, TomaszX
> Cc: Thomas Monjalon; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 2/9] null: fix segfault when null_pmd
> added to bonding
> 
> On 2015/10/28 22:43, Kulasek, TomaszX wrote:
> >> -----Original Message-----
> >> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> >> Sent: Tuesday, October 27, 2015 17:59
> >> To: Kulasek, TomaszX
> >> Cc: dev@dpdk.org; Tetsuya Mukawa
> >> Subject: Re: [dpdk-dev] [PATCH v6 2/9] null: fix segfault when
> >> null_pmd added to bonding
> >>
> >> Hi,
> >> There is no change in v6 for this patch which was acked by Tetsuya.
> >> So why not keep the Acked-by below your Signed-off-by?
> >>
> >> It seems patches 2, 3, 4 and 5 were Acked by Tetsuya.
> >> Other acks I'm missing?
> >>
> > Hi,
> >
> > Patches 4 and 5 were changed due to the Tetsuya's suggestions and
> already reviewed. There are not big changes, but I'm not sure if it
> should be reacked by Tetsuya, or I can just copy ack?
> >
> > Tomasz
> 
> Hi Tomasz,
> 
> Could you please check Bernard's patch series?
>  - [PATCH v5 00/28] remove pci driver from vdevs He tries to remove
> pci_drv from PMD.
> 
> It seems your below patch will be affected by his patch.
>  - null: fix segfault when null_pmd added to bonding
> 
> I just wonder your bonding RSS patch works without below fixing.
> drivers/net/null/rte_eth_null.c :
> +       pci_dev->driver = &rte_null_pmd.pci_drv;
> 
> Anyway, Could you please check him patches?
> 
> Thanks,
> Tetsuya

Hi Tetsuya,

I've just checked Bernard's patches and it seems that it can be safely removed from here. It's not used in RSS implementation, so have no impact on it.

I'm sending patchset v7 with copied your acks, as Thomas suggested, if you have no other objections.

Tomasz
diff mbox

Patch

diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index e244595..c748101 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -432,6 +432,7 @@  eth_dev_null_create(const char *name,
 	internals->numa_node = numa_node;
 
 	pci_dev->numa_node = numa_node;
+	pci_dev->driver = &rte_null_pmd.pci_drv;
 
 	data->dev_private = internals;
 	data->port_id = eth_dev->data->port_id;
@@ -445,6 +446,7 @@  eth_dev_null_create(const char *name,
 	eth_dev->dev_ops = &ops;
 	eth_dev->pci_dev = pci_dev;
 	eth_dev->driver = &rte_null_pmd;
+	TAILQ_INIT(&eth_dev->link_intr_cbs);
 
 	/* finally assign rx and tx ops */
 	if (packet_copy) {