diff mbox

[dpdk-dev,1/2] ixgbe: fix VF statistic wraparound handling macro

Message ID 1444668333-20191-2-git-send-email-harry.van.haaren@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Van Haaren, Harry Oct. 12, 2015, 4:45 p.m. UTC 
  Fix a misinterpretation of VF stats in ixgbe

Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Roger Melton Oct. 13, 2015, 7:43 p.m. UTC | #1 
ack

On 10/12/15 12:45 PM, Harry van Haaren wrote:
> Fix a misinterpretation of VF stats in ixgbe
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> ---
>   drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index ec2918c..86dcd87 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -329,10 +329,10 @@ static int ixgbe_timesync_read_tx_timestamp(struct rte_eth_dev *dev,
>   /*
>    * Define VF Stats MACRO for Non "cleared on read" register
>    */
> -#define UPDATE_VF_STAT(reg, last, cur)	                        \
> +#define UPDATE_VF_STAT(reg, last, cur)                          \
>   {                                                               \
>   	uint32_t latest = IXGBE_READ_REG(hw, reg);              \
> -	cur += latest - last;                                   \
> +	cur += (latest-last) & UINT_MAX;                        \
>   	last = latest;                                          \
>   }
>
Roger Melton Oct. 14, 2015, 10:15 a.m. UTC | #2 
On 10/12/15 12:45 PM, Harry van Haaren wrote:
> Fix a misinterpretation of VF stats in ixgbe
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>

Acked-by: Roger Melton <rmelton@cisco.com>
Thomas Monjalon Oct. 28, 2015, 1:37 p.m. UTC | #3 
2015-10-12 17:45, Harry van Haaren:
> -	cur += latest - last;                                   \
> +	cur += (latest-last) & UINT_MAX;                        \

CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)

Please use checkpatch before submitting.
Thanks
diff mbox

Patch

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index ec2918c..86dcd87 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -329,10 +329,10 @@  static int ixgbe_timesync_read_tx_timestamp(struct rte_eth_dev *dev,
 /*
  * Define VF Stats MACRO for Non "cleared on read" register
  */
-#define UPDATE_VF_STAT(reg, last, cur)	                        \
+#define UPDATE_VF_STAT(reg, last, cur)                          \
 {                                                               \
 	uint32_t latest = IXGBE_READ_REG(hw, reg);              \
-	cur += latest - last;                                   \
+	cur += (latest-last) & UINT_MAX;                        \
 	last = latest;                                          \
 }