diff mbox

[dpdk-dev,2/2] igb: fix VF statistic wraparound handling macro

Message ID 1444656823-717-3-git-send-email-harry.van.haaren@intel.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Van Haaren, Harry Oct. 12, 2015, 1:33 p.m. UTC 
  Fix a misinterpreatation of VF statistic macro in e1000/igb.

Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
 drivers/net/e1000/igb_ethdev.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Roger Melton Oct. 12, 2015, 3:02 p.m. UTC | #1 
ack

On 10/12/15 9:33 AM, Harry van Haaren wrote:
> Fix a misinterpreatation of VF statistic macro in e1000/igb.
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> ---
>   drivers/net/e1000/igb_ethdev.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index 848ef6e..e3f7402 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -246,7 +246,11 @@ static void eth_igb_configure_msix_intr(struct rte_eth_dev *dev);
>   #define UPDATE_VF_STAT(reg, last, cur)            \
>   {                                                 \
>   	u32 latest = E1000_READ_REG(hw, reg);     \
> -	cur += latest - last;                     \
> +	if(likely(latest > last)) {               \
> +		cur += latest - last;             \
> +	} else {                                  \
> +		cur += (UINT_MAX - last) + latest;\
> +	}                                         \
>   	last = latest;                            \
>   }
>
diff mbox

Patch

diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 848ef6e..e3f7402 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -246,7 +246,11 @@  static void eth_igb_configure_msix_intr(struct rte_eth_dev *dev);
 #define UPDATE_VF_STAT(reg, last, cur)            \
 {                                                 \
 	u32 latest = E1000_READ_REG(hw, reg);     \
-	cur += latest - last;                     \
+	if(likely(latest > last)) {               \
+		cur += latest - last;             \
+	} else {                                  \
+		cur += (UINT_MAX - last) + latest;\
+	}                                         \
 	last = latest;                            \
 }