[dpdk-dev,v5,5/9] null: export eth_dev_null_create
Commit Message
Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
---
drivers/net/null/Makefile | 2 +-
drivers/net/null/rte_eth_null.c | 2 +-
drivers/net/null/rte_eth_null.h | 40 +++++++++++++++++++++++++++++
drivers/net/null/rte_pmd_null_version.map | 7 +++++
4 files changed, 49 insertions(+), 2 deletions(-)
create mode 100644 drivers/net/null/rte_eth_null.h
Comments
On 2015/09/30 23:05, Tomasz Kulasek wrote:
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> ---
> drivers/net/null/Makefile | 2 +-
> drivers/net/null/rte_eth_null.c | 2 +-
> drivers/net/null/rte_eth_null.h | 40 +++++++++++++++++++++++++++++
> drivers/net/null/rte_pmd_null_version.map | 7 +++++
> 4 files changed, 49 insertions(+), 2 deletions(-)
> create mode 100644 drivers/net/null/rte_eth_null.h
Acked-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tetsuya Mukawa
> Sent: Wednesday, October 14, 2015 3:35 AM
> To: Kulasek, TomaszX; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v5 5/9] null: export eth_dev_null_create
>
> On 2015/09/30 23:05, Tomasz Kulasek wrote:
> > Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> > ---
> > drivers/net/null/Makefile | 2 +-
> > drivers/net/null/rte_eth_null.c | 2 +-
> > drivers/net/null/rte_eth_null.h | 40
> +++++++++++++++++++++++++++++
> > drivers/net/null/rte_pmd_null_version.map | 7 +++++
> > 4 files changed, 49 insertions(+), 2 deletions(-)
> > create mode 100644 drivers/net/null/rte_eth_null.h
> Acked-by: Tetsuya Mukawa <mukawa@igel.co.jp>
Hi Tetsuya,
Thank You for a review and acking patches.
There are 5 remaining patches in a patch-set:
[dpdk-dev] [PATCH v5 1/9] bonding: rss dynamic configuration
[dpdk-dev] [PATCH v5 6/9] test: dynamic rss configuration
[dpdk-dev] [PATCH v5 7/9] bonding: per queue stats
[dpdk-dev] [PATCH v5 8/9] doc: fixed spellings and typos
[dpdk-dev] [PATCH v5 9/9] doc: dynamic rss configuration for bonding
Could You also review them and ack if You agree with that implementation, please?
On 2015/10/14 21:42, Jastrzebski, MichalX K wrote:
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tetsuya Mukawa
>> Sent: Wednesday, October 14, 2015 3:35 AM
>> To: Kulasek, TomaszX; dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v5 5/9] null: export eth_dev_null_create
>>
>> On 2015/09/30 23:05, Tomasz Kulasek wrote:
>>> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
>>> ---
>>> drivers/net/null/Makefile | 2 +-
>>> drivers/net/null/rte_eth_null.c | 2 +-
>>> drivers/net/null/rte_eth_null.h | 40
>> +++++++++++++++++++++++++++++
>>> drivers/net/null/rte_pmd_null_version.map | 7 +++++
>>> 4 files changed, 49 insertions(+), 2 deletions(-)
>>> create mode 100644 drivers/net/null/rte_eth_null.h
>> Acked-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> Hi Tetsuya,
> Thank You for a review and acking patches.
> There are 5 remaining patches in a patch-set:
>
> [dpdk-dev] [PATCH v5 1/9] bonding: rss dynamic configuration
> [dpdk-dev] [PATCH v5 6/9] test: dynamic rss configuration
> [dpdk-dev] [PATCH v5 7/9] bonding: per queue stats
> [dpdk-dev] [PATCH v5 8/9] doc: fixed spellings and typos
> [dpdk-dev] [PATCH v5 9/9] doc: dynamic rss configuration for bonding
>
> Could You also review them and ack if You agree with that implementation, please?
Hi MichalX,
I've checked above patches. But I am sorry that I am not a correct
person to ack your patches.
To review it correctly, at least knowledge about RSS and bonding PMD are
needed, but honestly I am not familiar with RSS.
Is it possible to find a correct person who can ack it?
BTW, I've checked the patch from the following point of view. It may
help other reviewers.
(I've checked after fixing null PMD issues I've found today, please
check an email I've sent to Tomasz)
- No fatal errors are reported by checkpatch.pl.
- Some style warnings are reported, but I guess we can ignore it.
- No compile error with gcc-4.6/4.7/4.8/4.9/5, clang and icc.
- No missing symbol.
- No compile error for docs.
- No compile error for examples.
Thanks,
Tetsuya
> -----Original Message-----
> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp]
> Sent: Thursday, October 15, 2015 10:17 AM
> To: Jastrzebski, MichalX K
> Cc: Glynn, Michael J; Kulasek, TomaszX; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v5 5/9] null: export eth_dev_null_create
>
> On 2015/10/14 21:42, Jastrzebski, MichalX K wrote:
> >> -----Original Message-----
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tetsuya Mukawa
> >> Sent: Wednesday, October 14, 2015 3:35 AM
> >> To: Kulasek, TomaszX; dev@dpdk.org
> >> Subject: Re: [dpdk-dev] [PATCH v5 5/9] null: export eth_dev_null_create
> >>
> >> On 2015/09/30 23:05, Tomasz Kulasek wrote:
> >>> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> >>> ---
> >>> drivers/net/null/Makefile | 2 +-
> >>> drivers/net/null/rte_eth_null.c | 2 +-
> >>> drivers/net/null/rte_eth_null.h | 40
> >> +++++++++++++++++++++++++++++
> >>> drivers/net/null/rte_pmd_null_version.map | 7 +++++
> >>> 4 files changed, 49 insertions(+), 2 deletions(-)
> >>> create mode 100644 drivers/net/null/rte_eth_null.h
> >> Acked-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> > Hi Tetsuya,
> > Thank You for a review and acking patches.
> > There are 5 remaining patches in a patch-set:
> >
> > [dpdk-dev] [PATCH v5 1/9] bonding: rss dynamic configuration
> > [dpdk-dev] [PATCH v5 6/9] test: dynamic rss configuration
> > [dpdk-dev] [PATCH v5 7/9] bonding: per queue stats
> > [dpdk-dev] [PATCH v5 8/9] doc: fixed spellings and typos
> > [dpdk-dev] [PATCH v5 9/9] doc: dynamic rss configuration for bonding
> >
> > Could You also review them and ack if You agree with that implementation,
> please?
>
> Hi MichalX,
>
> I've checked above patches. But I am sorry that I am not a correct
> person to ack your patches.
> To review it correctly, at least knowledge about RSS and bonding PMD are
> needed, but honestly I am not familiar with RSS.
> Is it possible to find a correct person who can ack it?
>
> BTW, I've checked the patch from the following point of view. It may
> help other reviewers.
> (I've checked after fixing null PMD issues I've found today, please
> check an email I've sent to Tomasz)
> - No fatal errors are reported by checkpatch.pl.
> - Some style warnings are reported, but I guess we can ignore it.
> - No compile error with gcc-4.6/4.7/4.8/4.9/5, clang and icc.
> - No missing symbol.
> - No compile error for docs.
> - No compile error for examples.
>
> Thanks,
> Tetsuya
Hi Tetsuya,
Thank You very much for verifications and Your comments.
I will ask maintainers in term of reviewing remaining patches.
Regarding an issue with rte_eth_null.h I think that reordering of patches
4 and 5 may be sufficient.
Best regards
Michal
@@ -51,7 +51,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += rte_eth_null.c
#
# Export include files
#
-SYMLINK-y-include +=
+SYMLINK-y-include += rte_eth_null.h
# this lib depends upon:
DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += lib/librte_mbuf
@@ -491,7 +491,7 @@ static const struct eth_dev_ops ops = {
.rss_hash_conf_get = eth_rss_hash_conf_get
};
-static int
+int
eth_dev_null_create(const char *name,
const unsigned numa_node,
unsigned packet_size,
new file mode 100644
@@ -0,0 +1,40 @@
+/*-
+ * BSD LICENSE
+ *
+ * Copyright(c) 2015 Intel Corporation. All rights reserved.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Intel Corporation nor the names of its
+ * contributors may be used to endorse or promote products derived
+ * from this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef RTE_ETH_NULL_H_
+#define RTE_ETH_NULL_H_
+
+int eth_dev_null_create(const char *name, const unsigned numa_node,
+ unsigned packet_size, unsigned packet_copy);
+
+#endif /* RTE_ETH_NULL_H_ */
@@ -2,3 +2,10 @@ DPDK_2.0 {
local: *;
};
+
+DPDK_2.2 {
+ global:
+
+ eth_dev_null_create;
+
+} DPDK_2.0;