[dpdk-dev,v5,2/9] null: fix segfault when null_pmd added to bonding

Message ID 1443621905-7872-3-git-send-email-tomaszx.kulasek@intel.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Tomasz Kulasek Sept. 30, 2015, 2:04 p.m. UTC
  This patch initializes eth_dev->link_intr_cbs queue used when null pmd is
added to the bonding.

v5 changes:
 - removed unnecessary malloc for eth_driver (rte_null_pmd)

Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
---
 drivers/net/null/rte_eth_null.c |    2 ++
 1 file changed, 2 insertions(+)
  

Comments

Tetsuya Mukawa Oct. 14, 2015, 1:34 a.m. UTC | #1
On 2015/09/30 23:04, Tomasz Kulasek wrote:
> This patch initializes eth_dev->link_intr_cbs queue used when null pmd is
> added to the bonding.
>
> v5 changes:
>  - removed unnecessary malloc for eth_driver (rte_null_pmd)
>
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> ---
>  drivers/net/null/rte_eth_null.c |    2 ++
>  1 file changed, 2 insertions(+)
Acked-by: Tetsuya Mukawa <mukawa@igel.co.jp>
  

Patch

diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index e244595..c748101 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -432,6 +432,7 @@  eth_dev_null_create(const char *name,
 	internals->numa_node = numa_node;
 
 	pci_dev->numa_node = numa_node;
+	pci_dev->driver = &rte_null_pmd.pci_drv;
 
 	data->dev_private = internals;
 	data->port_id = eth_dev->data->port_id;
@@ -445,6 +446,7 @@  eth_dev_null_create(const char *name,
 	eth_dev->dev_ops = &ops;
 	eth_dev->pci_dev = pci_dev;
 	eth_dev->driver = &rte_null_pmd;
+	TAILQ_INIT(&eth_dev->link_intr_cbs);
 
 	/* finally assign rx and tx ops */
 	if (packet_copy) {