[dpdk-dev,8/8] librte_table: modify release notes and deprecation notice
Commit Message
From: Fan Zhang <roy.fan.zhang@intel.com>
The LIBABIVER number is incremented. The release notes is updated and
the deprecation announce is removed.
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
doc/guides/rel_notes/deprecation.rst | 3 ---
doc/guides/rel_notes/release_2_2.rst | 5 ++++-
lib/librte_table/Makefile | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
Comments
Hi and welcome,
(it seems to be your first patch on DPDK)
2015-09-25 23:33, roy.fan.zhang@intel.com:
> --- a/doc/guides/rel_notes/release_2_2.rst
> +++ b/doc/guides/rel_notes/release_2_2.rst
> @@ -95,6 +95,9 @@ ABI Changes
>
> * The LPM structure is changed. The deprecated field mem_location is removed.
>
> +* Key mask parameter is added to the hash table parameter structure for
> + 8-byte key and 16-byte key extendible bucket and LRU tables. The
> + deprecated field mem_location is removed.
It seems the last sentence is a wrong copy/paste.
If a v2 is needed, please squash the release notes changes with the API changes
(patches 1 and 2).
Thanks
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Monday, October 12, 2015 3:24 PM
> To: Zhang, Roy Fan
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 8/8] librte_table: modify release notes and
> deprecation notice
>
> If a v2 is needed, please squash the release notes changes with the API
> changes (patches 1 and 2).
Hi Thomas,
Could you clarify this? In general shouldn't we keep all lib/drivers/examples/doc changes in separate patches in the patchset?
John
From: Fan Zhang <roy.fan.zhang@intel.com>
This patchset links to ABI change announced for librte_table.
Key_mask parameters has been added to the hash table parameter
structure for 8-byte key and 16-byte key extendible bucket
and LRU tables.
v2:
*change in release note.
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Fan Zhang (8):
librte_table: add key_mask parameter to 8-byte key hash parameters
librte_table: add key_mask parameter to 16-byte key hash parameters
librte_table: add 16 byte hash table operations with computed lookup
app/test: modify app/test_table_combined and app/test_table_tables
app/test-pipeline: modify pipeline test
example/ip_pipeline: add parse_hex_string for internal use
example/ip_pipeline/pipeline: update flow_classification pipeline
librte_table: modify release notes and deprecation notice
app/test-pipeline/pipeline_hash.c | 4 +
app/test/test_table_combined.c | 4 +
app/test/test_table_tables.c | 6 +-
doc/guides/rel_notes/deprecation.rst | 3 -
doc/guides/rel_notes/release_2_2.rst | 4 +-
examples/ip_pipeline/config_parse.c | 70 ++++
examples/ip_pipeline/pipeline.h | 4 +
.../pipeline/pipeline_flow_classification_be.c | 56 ++-
lib/librte_table/Makefile | 2 +-
lib/librte_table/rte_table_hash.h | 20 +
lib/librte_table/rte_table_hash_key16.c | 411 ++++++++++++++++++++-
lib/librte_table/rte_table_hash_key8.c | 54 ++-
12 files changed, 607 insertions(+), 31 deletions(-)
2015-10-12 16:30, Mcnamara, John:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > If a v2 is needed, please squash the release notes changes with the API
> > changes (patches 1 and 2).
>
> Hi Thomas,
>
> Could you clarify this? In general shouldn't we keep all lib/drivers/examples/doc changes in separate patches in the patchset?
Why should we?
When reviewing a patch, having the doc atomically updated with the code change
will help to understand it.
This patchset links to ABI change announced for librte_table.
The key_mask parameters has been added to the hash table
parameter structure for 8-byte key and 16-byte key extendible
bucket and LRU tables.
v2:
*updated release note
v3:
*merged release note with source code patch
*fixed build error: added missing symbol to
librte_table/rte_table_version.map
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Fan Zhang (6):
librte_table: add 16 byte hash table operations with computed lookup
app/test: modify app/test_table_combined and app/test_table_tables
app/test-pipeline: modify pipeline test
example/ip_pipeline: add parse_hex_string for internal use
example/ip_pipeline/pipeline: update flow_classification pipeline
librte_table: add key_mask parameter to 8- and 16-bytes key hash
parameters
app/test-pipeline/pipeline_hash.c | 4 +
app/test/test_table_combined.c | 5 +-
app/test/test_table_tables.c | 6 +-
doc/guides/rel_notes/deprecation.rst | 4 -
doc/guides/rel_notes/release_2_2.rst | 4 +
examples/ip_pipeline/config_parse.c | 70 ++++
examples/ip_pipeline/pipeline.h | 4 +
.../pipeline/pipeline_flow_classification_be.c | 56 ++-
lib/librte_table/rte_table_hash.h | 20 +
lib/librte_table/rte_table_hash_key16.c | 411 ++++++++++++++++++++-
lib/librte_table/rte_table_hash_key8.c | 54 ++-
lib/librte_table/rte_table_version.map | 7 +
12 files changed, 614 insertions(+), 31 deletions(-)
@@ -63,9 +63,6 @@ Deprecation Notices
* librte_table: New functions for table entry bulk add/delete will be added
to the table operations structure.
-* librte_table hash: Key mask parameter will be added to the hash table
- parameter structure for 8-byte key and 16-byte key extendible bucket and
- LRU tables.
* librte_pipeline: The prototype for the pipeline input port, output port
and table action handlers will be updated:
@@ -95,6 +95,9 @@ ABI Changes
* The LPM structure is changed. The deprecated field mem_location is removed.
+* Key mask parameter is added to the hash table parameter structure for
+ 8-byte key and 16-byte key extendible bucket and LRU tables. The
+ deprecated field mem_location is removed.
Shared Library Versions
-----------------------
@@ -127,6 +130,6 @@ The libraries prepended with a plus sign were incremented in this version.
librte_reorder.so.1
librte_ring.so.1
librte_sched.so.1
- librte_table.so.1
+ librte_table.so.2
librte_timer.so.1
librte_vhost.so.1
@@ -41,7 +41,7 @@ CFLAGS += $(WERROR_FLAGS)
EXPORT_MAP := rte_table_version.map
-LIBABIVER := 1
+LIBABIVER := 2
#
# all source are stored in SRCS-y