From patchwork Fri Sep 25 08:28:11 2015
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Marvin Liu <yong.liu@intel.com>
X-Patchwork-Id: 7184
Return-Path: <dev-bounces@dpdk.org>
X-Original-To: patchwork@dpdk.org
Delivered-To: patchwork@dpdk.org
Received: from [92.243.14.124] (localhost [IPv6:::1])
	by dpdk.org (Postfix) with ESMTP id C9B1F8E8E;
	Fri, 25 Sep 2015 10:28:35 +0200 (CEST)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
	by dpdk.org (Postfix) with ESMTP id DDF558E86
	for <dev@dpdk.org>; Fri, 25 Sep 2015 10:28:33 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
	by fmsmga103.fm.intel.com with ESMTP; 25 Sep 2015 01:28:33 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,585,1437462000"; d="scan'208";a="568204819"
Received: from shvmail01.sh.intel.com ([10.239.29.42])
	by FMSMGA003.fm.intel.com with ESMTP; 25 Sep 2015 01:28:32 -0700
Received: from shecgisg003.sh.intel.com (shecgisg003.sh.intel.com
	[10.239.29.90])
	by shvmail01.sh.intel.com with ESMTP id t8P8SUNl027768;
	Fri, 25 Sep 2015 16:28:30 +0800
Received: from shecgisg003.sh.intel.com (localhost [127.0.0.1])
	by shecgisg003.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP
	id t8P8SSxX004788; Fri, 25 Sep 2015 16:28:30 +0800
Received: (from yliu84x@localhost)
	by shecgisg003.sh.intel.com (8.13.6/8.13.6/Submit) id t8P8SSIi004784;
	Fri, 25 Sep 2015 16:28:28 +0800
From: Yong Liu <yong.liu@intel.com>
To: dev@dpdk.org
Date: Fri, 25 Sep 2015 16:28:11 +0800
Message-Id: <1443169692-4709-7-git-send-email-yong.liu@intel.com>
X-Mailer: git-send-email 1.7.4.1
In-Reply-To: <1443169692-4709-1-git-send-email-yong.liu@intel.com>
References: <1443169692-4709-1-git-send-email-yong.liu@intel.com>
Subject: [dpdk-dev] [PATCH v1 6/7] e1000: lsc interrupt setup only enable
	itself
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
	<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
	<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

From: Marvin Liu <yong.liu@intel.com>

Only mask lsc interrupt bit when setup device interrupt.

Signed-off-by: Marvin Liu <yong.liu@intel.com>

diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
index 920d814..4e2ebf1 100644
--- a/drivers/net/e1000/em_ethdev.c
+++ b/drivers/net/e1000/em_ethdev.c
@@ -1343,11 +1343,14 @@ eth_em_vlan_offload_set(struct rte_eth_dev *dev, int mask)
 static int
 eth_em_interrupt_setup(struct rte_eth_dev *dev)
 {
+	uint32_t regval;
 	struct e1000_hw *hw =
 		E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);
 
-	E1000_WRITE_REG(hw, E1000_IMS, E1000_ICR_LSC);
-	rte_intr_enable(&(dev->pci_dev->intr_handle));
+	/* clear interrupt */
+	E1000_READ_REG(hw, E1000_ICR);
+	regval = E1000_READ_REG(hw, E1000_IMS);
+	E1000_WRITE_REG(hw, E1000_IMS, regval | E1000_ICR_LSC);
 	return (0);
 }