diff mbox

[dpdk-dev,v1] Return ENOMEM during mpipe_devinit failure

Message ID 1440014407-3233-1-git-send-email-rkerur@gmail.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Ravi Kerur Aug. 19, 2015, 8 p.m. UTC 
  In function rte_pmd_mpipe_devinit, if rte_eth_dev_allocate
fails return error which is inline with other drivers.

Signed-off-by: Ravi Kerur <rkerur@gmail.com>
---
 drivers/net/mpipe/mpipe_tilegx.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Tetsuya Mukawa Aug. 20, 2015, 2:07 a.m. UTC | #1 
On 2015/08/20 5:00, Ravi Kerur wrote:
> In function rte_pmd_mpipe_devinit, if rte_eth_dev_allocate
> fails return error which is inline with other drivers.
>
> Signed-off-by: Ravi Kerur <rkerur@gmail.com>
> ---
>  drivers/net/mpipe/mpipe_tilegx.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/mpipe/mpipe_tilegx.c b/drivers/net/mpipe/mpipe_tilegx.c
> index 743feef..6e3e304 100644
> --- a/drivers/net/mpipe/mpipe_tilegx.c
> +++ b/drivers/net/mpipe/mpipe_tilegx.c
> @@ -1582,6 +1582,7 @@ rte_pmd_mpipe_devinit(const char *ifname,
>  	if (!eth_dev) {
>  		RTE_LOG(ERR, PMD, "%s: Failed to allocate device.\n", ifname);
>  		rte_free(priv);
> +		return -ENOMEM;
>  	}
>  
>  	RTE_LOG(INFO, PMD, "%s: Initialized mpipe device"
Acked-by: Tetsuya Mukawa <mukawa@igel.co.jp>
Zhigang Lu Aug. 20, 2015, 2:14 a.m. UTC | #2 
>-----Original Message-----
>From: Ravi Kerur [mailto:rkerur@gmail.com]
>Sent: Thursday, August 20, 2015 4:00 AM
>To: dev@dpdk.org
>Cc: zlu@ezchip.com; Ravi Kerur
>Subject: [PATCH v1] Return ENOMEM during mpipe_devinit failure
>
>In function rte_pmd_mpipe_devinit, if rte_eth_dev_allocate
>fails return error which is inline with other drivers.
>
>Signed-off-by: Ravi Kerur <rkerur@gmail.com>
>---
> drivers/net/mpipe/mpipe_tilegx.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/mpipe/mpipe_tilegx.c
>b/drivers/net/mpipe/mpipe_tilegx.c
>index 743feef..6e3e304 100644
>--- a/drivers/net/mpipe/mpipe_tilegx.c
>+++ b/drivers/net/mpipe/mpipe_tilegx.c
>@@ -1582,6 +1582,7 @@ rte_pmd_mpipe_devinit(const char *ifname,
> 	if (!eth_dev) {
> 		RTE_LOG(ERR, PMD, "%s: Failed to allocate device.\n",
ifname);
> 		rte_free(priv);
>+		return -ENOMEM;
> 	}
>
> 	RTE_LOG(INFO, PMD, "%s: Initialized mpipe device"
>--
>1.9.1

Thanks for fixing this.
Acked-by: Zhigang Lu <zlu@ezchip.com>
Thomas Monjalon Oct. 24, 2015, 5:28 p.m. UTC | #3 
> >In function rte_pmd_mpipe_devinit, if rte_eth_dev_allocate
> >fails return error which is inline with other drivers.
> >
> >Signed-off-by: Ravi Kerur <rkerur@gmail.com>
> 
> Thanks for fixing this.
> Acked-by: Zhigang Lu <zlu@ezchip.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/net/mpipe/mpipe_tilegx.c b/drivers/net/mpipe/mpipe_tilegx.c
index 743feef..6e3e304 100644
--- a/drivers/net/mpipe/mpipe_tilegx.c
+++ b/drivers/net/mpipe/mpipe_tilegx.c
@@ -1582,6 +1582,7 @@  rte_pmd_mpipe_devinit(const char *ifname,
 	if (!eth_dev) {
 		RTE_LOG(ERR, PMD, "%s: Failed to allocate device.\n", ifname);
 		rte_free(priv);
+		return -ENOMEM;
 	}
 
 	RTE_LOG(INFO, PMD, "%s: Initialized mpipe device"