diff mbox

[dpdk-dev,v2] examples/l3fwd: fix compilation issue when using exact-match

Message ID 1439116125-29180-1-git-send-email-pablo.de.lara.guarch@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

De Lara Guarch, Pablo Aug. 9, 2015, 10:28 a.m. UTC 
  From: "Pablo de Lara" <pablo.de.lara.guarch@intel.com>

L3fwd was trying to use an inexistent function "simple_ipv6_fwd_4pkts",
instead it should be "simple_ipv6_fwd_8pkts", and "simple_ipv8_fwd_4pkts"
instead of "simple_ipv4_fwd_8pkts".

Fixes: 80fcb4d4 ("examples/l3fwd: increase lookup burst size to 8")

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
---

Changes in v2:

- Missing to fix additional type

 examples/l3fwd/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Thomas Monjalon Aug. 10, 2015, 4:58 p.m. UTC | #1 
Hi Pablo,

2015-08-09 11:28, Pablo de Lara:
> From: "Pablo de Lara" <pablo.de.lara.guarch@intel.com>
> 
> L3fwd was trying to use an inexistent function "simple_ipv6_fwd_4pkts",
> instead it should be "simple_ipv6_fwd_8pkts", and "simple_ipv8_fwd_4pkts"
> instead of "simple_ipv4_fwd_8pkts".
> 
> Fixes: 80fcb4d4 ("examples/l3fwd: increase lookup burst size to 8")
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> ---
> 
> Changes in v2:
> 
> - Missing to fix additional type

More fixes are needed:

make RTE_SDK=$(readlink -m ../..) RTE_TARGET=x86_64-native-linuxapp-clang \
	EXTRA_CFLAGS='-DAPP_LOOKUP_METHOD=APP_LOOKUP_EXACT_MATCH'

examples/l3fwd/main.c:545:1: error: unused function 'send_packetsx4'
examples/l3fwd/main.c:1165:1: error: unused function 'rfc1812_process'

The right fix would be to remove one APP_LOOKUP_METHOD.
diff mbox

Patch

diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
index 9351322..f113778 100644
--- a/examples/l3fwd/main.c
+++ b/examples/l3fwd/main.c
@@ -1710,11 +1710,11 @@  main_loop(__attribute__((unused)) void *dummy)
 							& pkts_burst[j+6]->ol_flags
 							& pkts_burst[j+7]->ol_flags;
 					if (ol_flag & PKT_RX_IPV4_HDR ) {
-						simple_ipv8_fwd_4pkts(&pkts_burst[j],
+						simple_ipv4_fwd_8pkts(&pkts_burst[j],
 									portid, qconf);
 					} else if (ol_flag & PKT_RX_IPV6_HDR) {
 #endif /* RTE_NEXT_ABI */
-						simple_ipv6_fwd_4pkts(&pkts_burst[j],
+						simple_ipv6_fwd_8pkts(&pkts_burst[j],
 									portid, qconf);
 					} else {
 						l3fwd_simple_forward(pkts_burst[j],