From patchwork Wed Jul 29 04:38:12 2015
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Marvin Liu <yong.liu@intel.com>
X-Patchwork-Id: 6651
Return-Path: <dev-bounces@dpdk.org>
X-Original-To: patchwork@dpdk.org
Delivered-To: patchwork@dpdk.org
Received: from [92.243.14.124] (localhost [IPv6:::1])
	by dpdk.org (Postfix) with ESMTP id 02A5CC4E4;
	Wed, 29 Jul 2015 06:38:23 +0200 (CEST)
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by dpdk.org (Postfix) with ESMTP id 7C9CEC4E2
	for <dev@dpdk.org>; Wed, 29 Jul 2015 06:38:20 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
	by orsmga101.jf.intel.com with ESMTP; 28 Jul 2015 21:38:19 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,568,1432623600"; d="scan'208";a="737621610"
Received: from shvmail01.sh.intel.com ([10.239.29.42])
	by orsmga001.jf.intel.com with ESMTP; 28 Jul 2015 21:38:19 -0700
Received: from shecgisg003.sh.intel.com (shecgisg003.sh.intel.com
	[10.239.29.90])
	by shvmail01.sh.intel.com with ESMTP id t6T4cGXE020412;
	Wed, 29 Jul 2015 12:38:16 +0800
Received: from shecgisg003.sh.intel.com (localhost [127.0.0.1])
	by shecgisg003.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP
	id t6T4cELR010150; Wed, 29 Jul 2015 12:38:16 +0800
Received: (from yliu84x@localhost)
	by shecgisg003.sh.intel.com (8.13.6/8.13.6/Submit) id t6T4cEIj010146;
	Wed, 29 Jul 2015 12:38:14 +0800
From: Yong Liu <yong.liu@intel.com>
To: dev@dpdk.org
Date: Wed, 29 Jul 2015 12:38:12 +0800
Message-Id: <1438144692-10114-1-git-send-email-yong.liu@intel.com>
X-Mailer: git-send-email 1.7.4.1
Subject: [dpdk-dev] [PATCH] app test: fix eal --no-huge option should work
	with -m option
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
	<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
	<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

From: Marvin Liu <yong.liu@intel.com>

'--no-huge' option now can workable with -m option.
Unit test for eal flag should change pass criterion.

Signed-off-by: Marvin Liu <yong.liu@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 0352f87..e6f7035 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -748,8 +748,8 @@ test_no_hpet_flag(void)
 }
 
 /*
- * Test that the app runs with --no-huge and doesn't run when either
- * -m or --socket-mem are specified with --no-huge.
+ * Test that the app runs with --no-huge and doesn't run when --socket-mem are
+ * specified with --no-huge.
  */
 static int
 test_no_huge_flag(void)
@@ -778,8 +778,8 @@ test_no_huge_flag(void)
 		printf("Error - process did not run ok with --no-huge flag\n");
 		return -1;
 	}
-	if (launch_proc(argv2) == 0) {
-		printf("Error - process run ok with --no-huge and -m flags\n");
+	if (launch_proc(argv2) != 0) {
+		printf("Error - process did not run ok with --no-huge and -m flags\n");
 		return -1;
 	}
 #ifdef RTE_EXEC_ENV_BSDAPP