diff mbox

[dpdk-dev] app test: fix eal --no-huge option should work with -m option

Message ID 1438144692-10114-1-git-send-email-yong.liu@intel.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Marvin Liu July 29, 2015, 4:38 a.m. UTC 
  From: Marvin Liu <yong.liu@intel.com>

'--no-huge' option now can workable with -m option.
Unit test for eal flag should change pass criterion.

Signed-off-by: Marvin Liu <yong.liu@intel.com>

Comments

Jingjing Wu July 30, 2015, 6:08 a.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yong Liu
> Sent: Wednesday, July 29, 2015 12:38 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] app test: fix eal --no-huge option should work
> with -m option
> 
> From: Marvin Liu <yong.liu@intel.com>
> 
> '--no-huge' option now can workable with -m option.
> Unit test for eal flag should change pass criterion.
> 
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>

> diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c index
> 0352f87..e6f7035 100644
> --- a/app/test/test_eal_flags.c
> +++ b/app/test/test_eal_flags.c
> @@ -748,8 +748,8 @@ test_no_hpet_flag(void)  }
> 
>  /*
> - * Test that the app runs with --no-huge and doesn't run when either
> - * -m or --socket-mem are specified with --no-huge.
> + * Test that the app runs with --no-huge and doesn't run when
> + --socket-mem are
> + * specified with --no-huge.
>   */
>  static int
>  test_no_huge_flag(void)
> @@ -778,8 +778,8 @@ test_no_huge_flag(void)
>  		printf("Error - process did not run ok with --no-huge flag\n");
>  		return -1;
>  	}
> -	if (launch_proc(argv2) == 0) {
> -		printf("Error - process run ok with --no-huge and -m flags\n");
> +	if (launch_proc(argv2) != 0) {
> +		printf("Error - process did not run ok with --no-huge and -m
> +flags\n");
>  		return -1;
>  	}
>  #ifdef RTE_EXEC_ENV_BSDAPP
> --
> 1.9.3
diff mbox

Patch

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 0352f87..e6f7035 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -748,8 +748,8 @@  test_no_hpet_flag(void)
 }
 
 /*
- * Test that the app runs with --no-huge and doesn't run when either
- * -m or --socket-mem are specified with --no-huge.
+ * Test that the app runs with --no-huge and doesn't run when --socket-mem are
+ * specified with --no-huge.
  */
 static int
 test_no_huge_flag(void)
@@ -778,8 +778,8 @@  test_no_huge_flag(void)
 		printf("Error - process did not run ok with --no-huge flag\n");
 		return -1;
 	}
-	if (launch_proc(argv2) == 0) {
-		printf("Error - process run ok with --no-huge and -m flags\n");
+	if (launch_proc(argv2) != 0) {
+		printf("Error - process did not run ok with --no-huge and -m flags\n");
 		return -1;
 	}
 #ifdef RTE_EXEC_ENV_BSDAPP