diff mbox

[dpdk-dev] app test: fix eal --no-huge option should work with -m option

Message ID 1438142069-9617-1-git-send-email-yong.liu@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Marvin Liu July 29, 2015, 3:54 a.m. UTC 
  From: Marvin Liu <yong.liu@intel.com>

'--no-huge' option now can workable with -m option.
Unit test for eal flag should change pass criterion.

Signed-off-by: Marvin Liu <yong.liu@intel.com>

Comments

Thomas Monjalon Aug. 3, 2015, 9:58 p.m. UTC | #1 
2015-07-29 11:54, Yong Liu:
> From: Marvin Liu <yong.liu@intel.com>
> 
> '--no-huge' option now can workable with -m option.
> Unit test for eal flag should change pass criterion.
> 
> Signed-off-by: Marvin Liu <yong.liu@intel.com>

Fixes: a7de7e6beb69 ("eal: allow combining -m and --no-huge")

Applied, thanks
diff mbox

Patch

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 0352f87..e6f7035 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -748,8 +748,8 @@  test_no_hpet_flag(void)
 }
 
 /*
- * Test that the app runs with --no-huge and doesn't run when either
- * -m or --socket-mem are specified with --no-huge.
+ * Test that the app runs with --no-huge and doesn't run when --socket-mem are
+ * specified with --no-huge.
  */
 static int
 test_no_huge_flag(void)
@@ -778,8 +778,8 @@  test_no_huge_flag(void)
 		printf("Error - process did not run ok with --no-huge flag\n");
 		return -1;
 	}
-	if (launch_proc(argv2) == 0) {
-		printf("Error - process run ok with --no-huge and -m flags\n");
+	if (launch_proc(argv2) != 0) {
+		printf("Error - process did not run ok with --no-huge and -m flags\n");
 		return -1;
 	}
 #ifdef RTE_EXEC_ENV_BSDAPP