diff mbox

[dpdk-dev] i40e: correct the private data size for i40e vf driver

Message ID 1438046019-30149-1-git-send-email-jingjing.wu@intel.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Jingjing Wu July 28, 2015, 1:13 a.m. UTC 
  The patch fixes the i40e VF crash issue. The issue's root cause is that
the dev_private_size in i40e virtual function driver struct
rte_i40evf_pmd was set incorrectly.

Signed-off-by: jingjing.wu <jingjing.wu@intel.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marvin Liu July 28, 2015, 1:27 a.m. UTC | #1 
Tested-by: Marvin Liu <yong.liu@intel.com>

> -----Original Message-----
> From: Wu, Jingjing
> Sent: Tuesday, July 28, 2015 9:14 AM
> To: dev@dpdk.org
> Cc: Wu, Jingjing; Zhang, Helin; Chen, Jing D; Liu, Yong
> Subject: [PATCH] i40e: correct the private data size for i40e vf driver
> 
> The patch fixes the i40e VF crash issue. The issue's root cause is that
> the dev_private_size in i40e virtual function driver struct
> rte_i40evf_pmd was set incorrectly.
> 
> Signed-off-by: jingjing.wu <jingjing.wu@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> b/drivers/net/i40e/i40e_ethdev_vf.c
> index f3470e6..b694400 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -1248,7 +1248,7 @@ static struct eth_driver rte_i40evf_pmd = {
>  	},
>  	.eth_dev_init = i40evf_dev_init,
>  	.eth_dev_uninit = i40evf_dev_uninit,
> -	.dev_private_size = sizeof(struct i40e_vf),
> +	.dev_private_size = sizeof(struct i40e_adapter),
>  };
> 
>  /*
> --
> 2.4.0
Thomas Monjalon July 28, 2015, 8:11 a.m. UTC | #2 
Hi Jingjing,

Few comments about the patch message.
The title must tell what issue is fixed, e.g. "fix crash when...".
the end "for i40e vf driver" is useless if it starts with "i40evf:".

2015-07-28 09:13, Jingjing Wu:
> The patch fixes the i40e VF crash issue. The issue's root cause is that
> the dev_private_size in i40e virtual function driver struct
> rte_i40evf_pmd was set incorrectly.

Please explain what are the conditions of the crash
and give a reference to the commit introducing the error with "Fixes: ...".

> Signed-off-by: jingjing.wu <jingjing.wu@intel.com>

Thanks
diff mbox

Patch

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index f3470e6..b694400 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -1248,7 +1248,7 @@  static struct eth_driver rte_i40evf_pmd = {
 	},
 	.eth_dev_init = i40evf_dev_init,
 	.eth_dev_uninit = i40evf_dev_uninit,
-	.dev_private_size = sizeof(struct i40e_vf),
+	.dev_private_size = sizeof(struct i40e_adapter),
 };
 
 /*