[dpdk-dev,v2] testpmd: fix wrong variable type in ieee1588fwd for 32 bits

Message ID 1437552408-16917-1-git-send-email-pablo.de.lara.guarch@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

De Lara Guarch, Pablo July 22, 2015, 8:06 a.m. UTC
  In ieee1588fwd.c, timestamp.tv_sec is a time_t variable,
which is a long int, but it was being printed with PRIu64,
causing an issue on 32 bits.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
Changes in v2:

- Corrected wrong commit message

 app/test-pmd/ieee1588fwd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Wenzhuo Lu July 22, 2015, 8:11 a.m. UTC | #1
Hi,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Wednesday, July 22, 2015 4:07 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] testpmd: fix wrong variable type in ieee1588fwd
> for 32 bits
> 
> In ieee1588fwd.c, timestamp.tv_sec is a time_t variable, which is a long int, but
> it was being printed with PRIu64, causing an issue on 32 bits.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
  
Thomas Monjalon July 22, 2015, 10:07 a.m. UTC | #2
> > In ieee1588fwd.c, timestamp.tv_sec is a time_t variable, which is a long int, but
> > it was being printed with PRIu64, causing an issue on 32 bits.
> > 
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

Applied, thanks
  

Patch

diff --git a/app/test-pmd/ieee1588fwd.c b/app/test-pmd/ieee1588fwd.c
index 069ee2e..b1a301b 100644
--- a/app/test-pmd/ieee1588fwd.c
+++ b/app/test-pmd/ieee1588fwd.c
@@ -89,7 +89,7 @@  port_ieee1588_rx_timestamp_check(portid_t pi, uint32_t index)
 		       (unsigned) pi);
 		return;
 	}
-	printf("Port %u RX timestamp value %"PRIu64"\n",
+	printf("Port %u RX timestamp value %lu\n",
 	       (unsigned) pi, timestamp.tv_sec);
 }
 
@@ -112,7 +112,7 @@  port_ieee1588_tx_timestamp_check(portid_t pi)
 		       (unsigned) pi, (unsigned) MAX_TX_TMST_WAIT_MICROSECS);
 		return;
 	}
-	printf("Port %u TX timestamp value %"PRIu64" validated after "
+	printf("Port %u TX timestamp value %lu validated after "
 	       "%u micro-second%s\n",
 	       (unsigned) pi, timestamp.tv_sec, wait_us,
 	       (wait_us == 1) ? "" : "s");