diff mbox

[dpdk-dev] fm10k: fix improper RETA table config

Message ID 1436516360-439-1-git-send-email-jing.d.chen@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Chen, Jing D July 10, 2015, 8:19 a.m. UTC 
  From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>

fm10k has 128 RETA entries in 32 registers, but it only initialized
first 32 when doing multiple rx queue configurations. This fix will
initialize all 128 entries instead.

Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
---
 drivers/net/fm10k/fm10k_ethdev.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Michael Qiu July 10, 2015, 8:20 a.m. UTC | #1 
On 7/10/2015 4:19 PM, Chen, Jing D wrote:
> From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
>
> fm10k has 128 RETA entries in 32 registers, but it only initialized
> first 32 when doing multiple rx queue configurations. This fix will
> initialize all 128 entries instead.
>
> Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>

Acked-by: Michael Qiu <michael.qiu@intel.com>
Thomas Monjalon July 10, 2015, 8:42 p.m. UTC | #2 
2015-07-10 08:20, Qiu, Michael:
> On 7/10/2015 4:19 PM, Chen, Jing D wrote:
> > From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
> >
> > fm10k has 128 RETA entries in 32 registers, but it only initialized
> > first 32 when doing multiple rx queue configurations. This fix will
> > initialize all 128 entries instead.
> >
> > Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
> 
> Acked-by: Michael Qiu <michael.qiu@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index f12d0c8..a300711 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/drivers/net/fm10k/fm10k_ethdev.c
@@ -329,7 +329,7 @@  fm10k_dev_mq_rx_configure(struct rte_eth_dev *dev)
 	 * little-endian order.
 	 */
 	reta = 0;
-	for (i = 0, j = 0; i < FM10K_RETA_SIZE; i++, j++) {
+	for (i = 0, j = 0; i < FM10K_MAX_RSS_INDICES; i++, j++) {
 		if (j == dev->data->nb_rx_queues)
 			j = 0;
 		reta = (reta << CHAR_BIT) | j;