Message ID | 1433854261-9079-1-git-send-email-bruce.richardson@intel.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id B07E05A58; Tue, 9 Jun 2015 14:51:25 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D57A95A54 for <dev@dpdk.org>; Tue, 9 Jun 2015 14:51:23 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 09 Jun 2015 05:51:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,579,1427785200"; d="scan'208";a="723845154" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga001.fm.intel.com with ESMTP; 09 Jun 2015 05:51:02 -0700 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id t59Cp1BR005234; Tue, 9 Jun 2015 13:51:01 +0100 Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id t59Cp1Kd009120; Tue, 9 Jun 2015 13:51:01 +0100 Received: (from bricha3@localhost) by sivswdev01.ir.intel.com with id t59Cp1pd009115; Tue, 9 Jun 2015 13:51:01 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: dev@dpdk.org Date: Tue, 9 Jun 2015 13:51:01 +0100 Message-Id: <1433854261-9079-1-git-send-email-bruce.richardson@intel.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1433502340-14725-1-git-send-email-bruce.richardson@intel.com> References: <1433502340-14725-1-git-send-email-bruce.richardson@intel.com> Subject: [dpdk-dev] [PATCH v2] mk: remove "u" modifier from "ar" command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Bruce Richardson
June 9, 2015, 12:51 p.m. UTC
On Fedora 22, the "ar" binary operates by default in deterministic mode,
making the "u" parameter irrelevant, and leading to warning messages
getting printed in the build output like below.
INSTALL-LIB librte_kvargs.a
ar: `u' modifier ignored since `D' is the default (see `U')
There are two options to remove these warnings:
* add in the "U" flag to make "ar" non-deterministic again
* remove the "u" flag to have all objects always updated
This patch takes the second approach. It also explicitly adds in the "D"
flag to make behaviour consistent across different distributions which
may have different defaults.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
V2 Changes: Add in "D" flag for consistency across distros.
---
mk/rte.lib.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Bruce, On 06/09/2015 02:51 PM, Bruce Richardson wrote: > On Fedora 22, the "ar" binary operates by default in deterministic mode, > making the "u" parameter irrelevant, and leading to warning messages > getting printed in the build output like below. > > INSTALL-LIB librte_kvargs.a > ar: `u' modifier ignored since `D' is the default (see `U') > > There are two options to remove these warnings: > * add in the "U" flag to make "ar" non-deterministic again > * remove the "u" flag to have all objects always updated > > This patch takes the second approach. It also explicitly adds in the "D" > flag to make behaviour consistent across different distributions which > may have different defaults. > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Olivier Matz <olivier.matz@6wind.com> > > --- > V2 Changes: Add in "D" flag for consistency across distros. > --- > mk/rte.lib.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk > index 0d7482d..25aa989 100644 > --- a/mk/rte.lib.mk > +++ b/mk/rte.lib.mk > @@ -70,7 +70,7 @@ else > _CPU_LDFLAGS := $(CPU_LDFLAGS) > endif > > -O_TO_A = $(AR) crus $(LIB) $(OBJS-y) > +O_TO_A = $(AR) crDs $(LIB) $(OBJS-y) > O_TO_A_STR = $(subst ','\'',$(O_TO_A)) #'# fix syntax highlight > O_TO_A_DISP = $(if $(V),"$(O_TO_A_STR)"," AR $(@)") > O_TO_A_CMD = "cmd_$@ = $(O_TO_A_STR)" >
2015-06-09 16:17, Olivier MATZ: > On 06/09/2015 02:51 PM, Bruce Richardson wrote: > > On Fedora 22, the "ar" binary operates by default in deterministic mode, > > making the "u" parameter irrelevant, and leading to warning messages > > getting printed in the build output like below. > > > > INSTALL-LIB librte_kvargs.a > > ar: `u' modifier ignored since `D' is the default (see `U') > > > > There are two options to remove these warnings: > > * add in the "U" flag to make "ar" non-deterministic again > > * remove the "u" flag to have all objects always updated > > > > This patch takes the second approach. It also explicitly adds in the "D" > > flag to make behaviour consistent across different distributions which > > may have different defaults. > > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > > Acked-by: Olivier Matz <olivier.matz@6wind.com> Applied, thanks
diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index 0d7482d..25aa989 100644 --- a/mk/rte.lib.mk +++ b/mk/rte.lib.mk @@ -70,7 +70,7 @@ else _CPU_LDFLAGS := $(CPU_LDFLAGS) endif -O_TO_A = $(AR) crus $(LIB) $(OBJS-y) +O_TO_A = $(AR) crDs $(LIB) $(OBJS-y) O_TO_A_STR = $(subst ','\'',$(O_TO_A)) #'# fix syntax highlight O_TO_A_DISP = $(if $(V),"$(O_TO_A_STR)"," AR $(@)") O_TO_A_CMD = "cmd_$@ = $(O_TO_A_STR)"