diff mbox

[dpdk-dev] mk: fix combined library building

Message ID 1433842648-32492-1-git-send-email-sergio.gonzalez.monroy@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Sergio Gonzalez Monroy June 9, 2015, 9:37 a.m. UTC 
  The combined lib was being created after building the lib root dir.
With the new directory hierarchy, it should be created after the
drivers root dir instead.

Fixes: 980ed498eb1dd0 ("drivers: create new directory")

Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
---
 mk/rte.sdkbuild.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

De Lara Guarch, Pablo June 9, 2015, 10:33 a.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez
> Monroy
> Sent: Tuesday, June 09, 2015 10:37 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] mk: fix combined library building
> 
> The combined lib was being created after building the lib root dir.
> With the new directory hierarchy, it should be created after the
> drivers root dir instead.
> 
> Fixes: 980ed498eb1dd0 ("drivers: create new directory")
> 
> Signed-off-by: Sergio Gonzalez Monroy

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Li Wei June 10, 2015, 2:48 a.m. UTC | #2 
On 06/09/2015 05:37 PM, Sergio Gonzalez Monroy wrote:
> The combined lib was being created after building the lib root dir.
> With the new directory hierarchy, it should be created after the
> drivers root dir instead.
> 
> Fixes: 980ed498eb1dd0 ("drivers: create new directory")
> 
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>

Tested-by: Li Wei <lw@cn.fujitsu.com>
Thomas Monjalon June 10, 2015, 10:23 a.m. UTC | #3 
2015-06-10 10:48, Li Wei:
> On 06/09/2015 05:37 PM, Sergio Gonzalez Monroy wrote:
> > The combined lib was being created after building the lib root dir.
> > With the new directory hierarchy, it should be created after the
> > drivers root dir instead.
> > 
> > Fixes: 980ed498eb1dd0 ("drivers: create new directory")
> > 
> > Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> 
> Tested-by: Li Wei <lw@cn.fujitsu.com>

Applied, thanks
diff mbox

Patch

diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk
index 3154457..09bb60a 100644
--- a/mk/rte.sdkbuild.mk
+++ b/mk/rte.sdkbuild.mk
@@ -93,7 +93,7 @@  $(ROOTDIRS-y):
 	@[ -d $(BUILDDIR)/$@ ] || mkdir -p $(BUILDDIR)/$@
 	@echo "== Build $@"
 	$(Q)$(MAKE) S=$@ -f $(RTE_SRCDIR)/$@/Makefile -C $(BUILDDIR)/$@ all
-	@if [ $@ = lib -a $(RTE_BUILD_COMBINE_LIBS) = y ]; then \
+	@if [ $@ = drivers -a $(RTE_BUILD_COMBINE_LIBS) = y ]; then \
 		$(MAKE) -f $(RTE_SDK)/lib/Makefile sharelib; \
 	fi