From patchwork Fri Jun 5 09:02:57 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Chen, Jing D" X-Patchwork-Id: 5202 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 4D1E9C330; Fri, 5 Jun 2015 11:03:18 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E4E61C32C for ; Fri, 5 Jun 2015 11:03:16 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 05 Jun 2015 02:03:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,557,1427785200"; d="scan'208";a="737583263" Received: from shvmail01.sh.intel.com ([10.239.29.42]) by fmsmga002.fm.intel.com with ESMTP; 05 Jun 2015 02:03:14 -0700 Received: from shecgisg003.sh.intel.com (shecgisg003.sh.intel.com [10.239.29.90]) by shvmail01.sh.intel.com with ESMTP id t5593BIn014105; Fri, 5 Jun 2015 17:03:11 +0800 Received: from shecgisg003.sh.intel.com (localhost [127.0.0.1]) by shecgisg003.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP id t55939Ln006756; Fri, 5 Jun 2015 17:03:11 +0800 Received: (from jingche2@localhost) by shecgisg003.sh.intel.com (8.13.6/8.13.6/Submit) id t55939Ut006752; Fri, 5 Jun 2015 17:03:09 +0800 From: "Chen Jing D(Mark)" To: dev@dpdk.org Date: Fri, 5 Jun 2015 17:02:57 +0800 Message-Id: <1433494978-6708-3-git-send-email-jing.d.chen@intel.com> X-Mailer: git-send-email 1.7.12.2 In-Reply-To: <1433494978-6708-1-git-send-email-jing.d.chen@intel.com> References: <1433494978-6708-1-git-send-email-jing.d.chen@intel.com> Cc: shaopeng.he@intel.com Subject: [dpdk-dev] [PATCH 2/3] fm10k: remove mbuf size sanity check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: "Chen Jing D(Mark)" Original implementation required mbuf size should be greater than ETHER_MAX_VLAN_FRAME_LEN, which is not necessary. If it's less than that value, scatter function will be selected and incoming packets greater than mbuf size will be filled into several mbufs. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k_ethdev.c | 7 +------ 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index 9274ca3..3792df6 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/fm10k_ethdev.c @@ -1005,9 +1005,7 @@ handle_rxconf(struct fm10k_rx_queue *q, const struct rte_eth_rxconf *conf) * 2. Address is 8B aligned and buffer does not cross 4K boundary. * * As such, the driver may need to adjust the DMA address within the - * buffer by up to 512B. The mempool element size is checked here - * to make sure a maximally sized Ethernet frame can still be wholly - * contained within the buffer after 512B alignment. + * buffer by up to 512B. * * return 1 if the element size is valid, otherwise return 0. */ @@ -1027,9 +1025,6 @@ mempool_element_size_valid(struct rte_mempool *mp) if (min_size > mp->elt_size) return 0; - if (min_size < ETHER_MAX_VLAN_FRAME_LEN) - return 0; - /* size is valid */ return 1; }