Message ID | 1431957127-21395-1-git-send-email-helin.zhang@intel.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 5A940C312; Mon, 18 May 2015 15:52:24 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 19A6BB6AB for <dev@dpdk.org>; Mon, 18 May 2015 15:52:20 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 18 May 2015 06:52:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,453,1427785200"; d="scan'208";a="727766491" Received: from shvmail01.sh.intel.com ([10.239.29.42]) by fmsmga002.fm.intel.com with ESMTP; 18 May 2015 06:52:16 -0700 Received: from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com [10.239.29.89]) by shvmail01.sh.intel.com with ESMTP id t4IDqDgt001908; Mon, 18 May 2015 21:52:13 +0800 Received: from shecgisg004.sh.intel.com (localhost [127.0.0.1]) by shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP id t4IDq9OC021432; Mon, 18 May 2015 21:52:11 +0800 Received: (from hzhan75@localhost) by shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t4IDq8mR021428; Mon, 18 May 2015 21:52:08 +0800 From: Helin Zhang <helin.zhang@intel.com> To: dev@dpdk.org Date: Mon, 18 May 2015 21:52:07 +0800 Message-Id: <1431957127-21395-1-git-send-email-helin.zhang@intel.com> X-Mailer: git-send-email 1.7.4.1 Subject: [dpdk-dev] [PATCH] i40e: compile fix on ICC 13.0.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Zhang, Helin
May 18, 2015, 1:52 p.m. UTC
Below compile error can be found on ICC 13.0.0, which is a warning
treated as error. Forcedly disabling the warning can fix it.
Error log:
lib/librte_pmd_i40e/i40e/i40e_nvm.c(1022): error #188: enumerated
type mixed with another type
hw->aq.asq_last_status = old_asq_status;
^
Signed-off-by: Helin Zhang <helin.zhang@intel.com>
---
lib/librte_pmd_i40e/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Compile warnings on ICC and clang can be found, and treated as errors. Disabling those warnings forcedly can fix them. v2 changes: Added the fix for the compile error on clang. Helin Zhang (2): i40e: compile fix on ICC 13.0.0 i40e: compile fix on clang 3.3 lib/librte_pmd_i40e/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Compile warnings on ICC and clang can be found, and treated as errors. Disabling those warnings forcedly can fix them. v2 changes: Added the fix for the compile error on clang. v3 changes: Reworded the commit titles. Helin Zhang (2): i40e: compile fix on ICC 13.0.0 i40e: compile fix on clang 3.3 lib/librte_pmd_i40e/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
On Mon, May 18, 2015 at 11:40:54PM +0800, Helin Zhang wrote: > Compile warnings on ICC and clang can be found, and treated as errors. > Disabling those warnings forcedly can fix them. > > v2 changes: > Added the fix for the compile error on clang. > > v3 changes: > Reworded the commit titles. > > Helin Zhang (2): > i40e: compile fix on ICC 13.0.0 > i40e: compile fix on clang 3.3 > > lib/librte_pmd_i40e/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > -- > 1.8.1.4 > Series Acked-by: Bruce Richardson <bruce.richardson@intel.com>
On 2015/05/19 0:03, Helin Zhang wrote: > Compile warnings on ICC and clang can be found, and treated as errors. > Disabling those warnings forcedly can fix them. > > v2 changes: > Added the fix for the compile error on clang. > > Helin Zhang (2): > i40e: compile fix on ICC 13.0.0 > i40e: compile fix on clang 3.3 > > lib/librte_pmd_i40e/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Acked-by: Tetsuya Mukawa <mukawa@igel.co.jp>
2015-05-18 16:43, Bruce Richardson: > On Mon, May 18, 2015 at 11:40:54PM +0800, Helin Zhang wrote: > > Compile warnings on ICC and clang can be found, and treated as errors. > > Disabling those warnings forcedly can fix them. > > > > v2 changes: > > Added the fix for the compile error on clang. > > > > v3 changes: > > Reworded the commit titles. > > Series Acked-by: Bruce Richardson <bruce.richardson@intel.com> Applied, thanks I reworded the commit message and added reference to the breaking commit: http://dpdk.org/browse/dpdk/commit/?id=ff5c3960017cf Please consider giving this kind of explanation when fixing things, especially for special handling of base drivers.
Thomas, thank you! - Helin > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, May 19, 2015 6:33 PM > To: Zhang, Helin > Cc: dev@dpdk.org; Richardson, Bruce > Subject: Re: [dpdk-dev] [PATCH v3 0/2] fix compile with ICC and clang > > 2015-05-18 16:43, Bruce Richardson: > > On Mon, May 18, 2015 at 11:40:54PM +0800, Helin Zhang wrote: > > > Compile warnings on ICC and clang can be found, and treated as > errors. > > > Disabling those warnings forcedly can fix them. > > > > > > v2 changes: > > > Added the fix for the compile error on clang. > > > > > > v3 changes: > > > Reworded the commit titles. > > > > Series Acked-by: Bruce Richardson <bruce.richardson@intel.com> > > Applied, thanks > I reworded the commit message and added reference to the breaking > commit: > http://dpdk.org/browse/dpdk/commit/?id=ff5c3960017cf > Please consider giving this kind of explanation when fixing things, > especially for special handling of base drivers.
diff --git a/lib/librte_pmd_i40e/Makefile b/lib/librte_pmd_i40e/Makefile index 22f0716..911e4f5 100644 --- a/lib/librte_pmd_i40e/Makefile +++ b/lib/librte_pmd_i40e/Makefile @@ -48,7 +48,7 @@ LIBABIVER := 1 # to disable warnings # ifeq ($(CC), icc) -CFLAGS_BASE_DRIVER = -wd593 +CFLAGS_BASE_DRIVER = -wd593 -wd188 else ifeq ($(CC), clang) CFLAGS_BASE_DRIVER += -Wno-sign-compare CFLAGS_BASE_DRIVER += -Wno-unused-value