diff mbox

[dpdk-dev,4/5] ixgbe: use RTE_LOG not rte_log

Message ID 1431709707-5281-5-git-send-email-stephen@networkplumber.org (mailing list archive)
State Superseded, archived
Headers show

Commit Message

Stephen Hemminger May 15, 2015, 5:08 p.m. UTC
This driver should follow standard DPDK practice and use
RTE_LOG macro which allows setting config option to remove
the debug log messages.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_pmd_ixgbe/ixgbe_logs.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Bruce Richardson May 18, 2015, 9:28 a.m. UTC | #1
On Fri, May 15, 2015 at 10:08:26AM -0700, Stephen Hemminger wrote:
> This driver should follow standard DPDK practice and use
> RTE_LOG macro which allows setting config option to remove
> the debug log messages.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> ---
>  lib/librte_pmd_ixgbe/ixgbe_logs.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_logs.h b/lib/librte_pmd_ixgbe/ixgbe_logs.h
> index 572e030..53ba42d 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_logs.h
> +++ b/lib/librte_pmd_ixgbe/ixgbe_logs.h
> @@ -35,8 +35,7 @@
>  #define _IXGBE_LOGS_H_
>  
>  #define PMD_INIT_LOG(level, fmt, args...) \
> -	rte_log(RTE_LOG_ ## level, RTE_LOGTYPE_PMD, \
> -		"PMD: %s(): " fmt "\n", __func__, ##args)
> +	RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ##args)
>  
>  #ifdef RTE_LIBRTE_IXGBE_DEBUG_INIT
>  #define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, " >>")
> -- 
> 2.1.4
>
diff mbox

Patch

diff --git a/lib/librte_pmd_ixgbe/ixgbe_logs.h b/lib/librte_pmd_ixgbe/ixgbe_logs.h
index 572e030..53ba42d 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_logs.h
+++ b/lib/librte_pmd_ixgbe/ixgbe_logs.h
@@ -35,8 +35,7 @@ 
 #define _IXGBE_LOGS_H_
 
 #define PMD_INIT_LOG(level, fmt, args...) \
-	rte_log(RTE_LOG_ ## level, RTE_LOGTYPE_PMD, \
-		"PMD: %s(): " fmt "\n", __func__, ##args)
+	RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ##args)
 
 #ifdef RTE_LIBRTE_IXGBE_DEBUG_INIT
 #define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, " >>")