From patchwork Mon May 11 17:07:51 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 4674 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id ECB055A63; Mon, 11 May 2015 19:08:00 +0200 (CEST) Received: from mail-pd0-f170.google.com (mail-pd0-f170.google.com [209.85.192.170]) by dpdk.org (Postfix) with ESMTP id 6C68B5A34 for ; Mon, 11 May 2015 19:07:57 +0200 (CEST) Received: by pdbqa5 with SMTP id qa5so148797250pdb.1 for ; Mon, 11 May 2015 10:07:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ca/dNSm9oCWXUQO1srvCw1iYGE8zAvNUZZkLlhNyaaU=; b=FYyz+lGAzgXKlrWBFZYFtOiIp5lTzBQIbN9eWTGmPvdCZ/iDdFbhobi8ifOKTnfC03 18A66fU+SI4VHkotaC5ZNFdUH3W/Mt2fAVcIxSVJeBQDmz9L0PJm+GFjMgl4ubsEVESn gfTLPAceJ/0OK4GU729jZXhh+Qbhc2ShB/O8YZLerQVwbsyXBi/Ix/IhlilBJ5m+7zzY WdfLEfnt3yYlje//w1cw4jFWJwMA7Lh6NQLZ/bcdvKEhIM2MmMbBsayVBgCwiAiamIOp qlSG/qSK/3DC4tPV7+ZMs68qZ/SsfY5VOvRNQzL3qpO/HOQlFlI9iO1mv4o9b1kKMjB7 DLpA== X-Gm-Message-State: ALoCoQlcnE45Af/VHaKGqIOv8THgZy9L/oIimgV9ckxZ9snYB3aySKnx5PsqP5o6ficVQRokwHPw X-Received: by 10.70.108.137 with SMTP id hk9mr20673849pdb.105.1431364076773; Mon, 11 May 2015 10:07:56 -0700 (PDT) Received: from urahara.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id hv7sm13650018pdb.86.2015.05.11.10.07.55 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 11 May 2015 10:07:56 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Date: Mon, 11 May 2015 10:07:51 -0700 Message-Id: <1431364071-27298-7-git-send-email-stephen@networkplumber.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1431364071-27298-1-git-send-email-stephen@networkplumber.org> References: <1431364071-27298-1-git-send-email-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 6/6] rte_sched: use correct log level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The setup messages should be at DEBUG level since they are not important for normal operation of system. The messages about problems should be at NOTICE or ERR level. Signed-off-by: Stephen Hemminger --- lib/librte_sched/rte_sched.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c index b8d036a..ec55f67 100644 --- a/lib/librte_sched/rte_sched.c +++ b/lib/librte_sched/rte_sched.c @@ -448,7 +448,8 @@ rte_sched_port_get_memory_footprint(struct rte_sched_port_params *params) status = rte_sched_port_check_params(params); if (status != 0) { - RTE_LOG(INFO, SCHED, "Port scheduler params check failed (%d)\n", status); + RTE_LOG(NOTICE, SCHED, + "Port scheduler params check failed (%d)\n", status); return 0; } @@ -494,7 +495,7 @@ rte_sched_port_log_pipe_profile(struct rte_sched_port *port, uint32_t i) { struct rte_sched_pipe_profile *p = port->pipe_profiles + i; - RTE_LOG(INFO, SCHED, "Low level config for pipe profile %u:\n" + RTE_LOG(DEBUG, SCHED, "Low level config for pipe profile %u:\n" " Token bucket: period = %u, credits per period = %u, size = %u\n" " Traffic classes: period = %u, credits per period = [%u, %u, %u, %u]\n" " Traffic class 3 oversubscription: weight = %hhu\n" @@ -688,7 +689,7 @@ rte_sched_port_config(struct rte_sched_port_params *params) bmp_mem_size = rte_bitmap_get_memory_footprint(n_queues_per_port); port->bmp = rte_bitmap_init(n_queues_per_port, port->bmp_array, bmp_mem_size); if (port->bmp == NULL) { - RTE_LOG(INFO, SCHED, "Bitmap init error\n"); + RTE_LOG(ERR, SCHED, "Bitmap init error\n"); return NULL; } for (i = 0; i < RTE_SCHED_PORT_N_GRINDERS; i ++) { @@ -715,7 +716,7 @@ rte_sched_port_log_subport_config(struct rte_sched_port *port, uint32_t i) { struct rte_sched_subport *s = port->subport + i; - RTE_LOG(INFO, SCHED, "Low level config for subport %u:\n" + RTE_LOG(DEBUG, SCHED, "Low level config for subport %u:\n" " Token bucket: period = %u, credits per period = %u, size = %u\n" " Traffic classes: period = %u, credits per period = [%u, %u, %u, %u]\n" " Traffic class 3 oversubscription: wm min = %u, wm max = %u\n", @@ -857,7 +858,8 @@ rte_sched_pipe_config(struct rte_sched_port *port, s->tc_ov = s->tc_ov_rate > subport_tc3_rate; if (s->tc_ov != tc3_ov) { - RTE_LOG(INFO, SCHED, "Subport %u TC3 oversubscription is OFF (%.4lf >= %.4lf)\n", + RTE_LOG(DEBUG, SCHED, + "Subport %u TC3 oversubscription is OFF (%.4lf >= %.4lf)\n", subport_id, subport_tc3_rate, s->tc_ov_rate); } #endif @@ -896,7 +898,8 @@ rte_sched_pipe_config(struct rte_sched_port *port, s->tc_ov = s->tc_ov_rate > subport_tc3_rate; if (s->tc_ov != tc3_ov) { - RTE_LOG(INFO, SCHED, "Subport %u TC3 oversubscription is ON (%.4lf < %.4lf)\n", + RTE_LOG(DEBUG, SCHED, + "Subport %u TC3 oversubscription is ON (%.4lf < %.4lf)\n", subport_id, subport_tc3_rate, s->tc_ov_rate); } p->tc_ov_period_id = s->tc_ov_period_id;