diff mbox

[dpdk-dev] vhost: Fix compilation issue

Message ID 1430723719-27999-1-git-send-email-changchun.ouyang@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Ouyang Changchun May 4, 2015, 7:15 a.m. UTC 
  Minor fix for the referring of a pointer when debug and dump is enabled.
The original commit is: 72ec8d77

Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
---
 examples/vhost/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon May 12, 2015, 9:23 a.m. UTC | #1 
> Minor fix for the referring of a pointer when debug and dump is enabled.
> The original commit is: 72ec8d77
> 
> Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>

Applied, thanks

This bug was not seen before because it was disabled:
examples/vhost/main.h: //#define DEBUG

That's why we must avoid putting some code in #if blocks.
Please use log levels when possible.
If you absolutely want a compile-time option (other than CONFIG_RTE_LOG_LEVEL),
please put it in the config file instead of commenting a #define in a header file.

In this case, it should be handled only with CONFIG_RTE_LOG_LEVEL.
I think we can assume the debug level will have an impact on datapath performance.
And maybe we should raise the default log level to RTE_LOG_NOTICE.

Last comment about logs in vhost example: CONFIG_RTE_LOG_LEVEL should be used
to define the macro PRINT_PACKET. In case of debug level at compile-time, it
should call a function checking the runtime log level as in rte_vlog().
Please, let's avoid defining entirely a function in a macro, it's ugly.

Thanks
diff mbox

Patch

diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 195d82f..8cec7c2 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -1105,7 +1105,7 @@  find_local_dest(struct virtio_net *dev, struct rte_mbuf *m,
 			"(%"PRIu64") TX: pkt to local VM device id:"
 			"(%"PRIu64") vlan tag: %d.\n",
 			dev->device_fh, dev_ll->vdev->dev->device_fh,
-			vlan_tag);
+			(int)*vlan_tag);
 
 			break;
 		}