| Message ID | 1430318263-3189-2-git-send-email-keith.wiles@intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 9E4E8C880; Wed, 29 Apr 2015 16:37:57 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 9D8C0C870 for <dev@dpdk.org>; Wed, 29 Apr 2015 16:37:55 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 29 Apr 2015 07:37:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,671,1422950400"; d="scan'208";a="717813657" Received: from unknown (HELO rkwiles-desk.ger.corp.intel.com) ([10.255.41.14]) by fmsmga002.fm.intel.com with ESMTP; 29 Apr 2015 07:37:52 -0700 From: Keith Wiles <keith.wiles@intel.com> To: dev@dpdk.org Date: Wed, 29 Apr 2015 09:37:43 -0500 Message-Id: <1430318263-3189-2-git-send-email-keith.wiles@intel.com> X-Mailer: git-send-email 2.3.0 In-Reply-To: <1430318263-3189-1-git-send-email-keith.wiles@intel.com> References: <1430318263-3189-1-git-send-email-keith.wiles@intel.com> Subject: [dpdk-dev] [PATCH v2 2/2] Update Docs for new EXTRA_LDLIBS variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Wiles, Keith
April 29, 2015, 2:37 p.m. UTC
Signed-off-by: Keith Wiles <keith.wiles@intel.com>
---
doc/build-sdk-quick.txt | 1 +
doc/guides/prog_guide/dev_kit_build_system.rst | 2 ++
doc/guides/prog_guide/dev_kit_root_make_help.rst | 2 +-
3 files changed, 4 insertions(+), 1 deletion(-)
Comments
On 29/04/2015 15:37, Keith Wiles wrote: > Signed-off-by: Keith Wiles <keith.wiles@intel.com> > --- > doc/build-sdk-quick.txt | 1 + > doc/guides/prog_guide/dev_kit_build_system.rst | 2 ++ > doc/guides/prog_guide/dev_kit_root_make_help.rst | 2 +- > 3 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/doc/build-sdk-quick.txt b/doc/build-sdk-quick.txt > index 041a40e..26d5442 100644 > --- a/doc/build-sdk-quick.txt > +++ b/doc/build-sdk-quick.txt > @@ -13,6 +13,7 @@ Build variables > EXTRA_CPPFLAGS preprocessor options > EXTRA_CFLAGS compiler options > EXTRA_LDFLAGS linker options > + EXTRA_LDLIBS linker libary options > RTE_KERNELDIR linux headers path > CROSS toolchain prefix > V verbose > diff --git a/doc/guides/prog_guide/dev_kit_build_system.rst b/doc/guides/prog_guide/dev_kit_build_system.rst > index cf5c96f..b8ef167 100644 > --- a/doc/guides/prog_guide/dev_kit_build_system.rst > +++ b/doc/guides/prog_guide/dev_kit_build_system.rst > @@ -413,6 +413,8 @@ Variables that Can be Set/Overridden by the User in a Makefile or Command Line > > * EXTRA_LDFLAGS: The content of this variable is appended after LDFLAGS when linking. > > +* EXTRA_LDLIBS: The content of this variable is appended after LDLIBS when linking. > + > * EXTRA_ASFLAGS: The content of this variable is appended after ASFLAGS when assembling. > > * EXTRA_CPPFLAGS: The content of this variable is appended after CPPFLAGS when using a C preprocessor on assembly files. > diff --git a/doc/guides/prog_guide/dev_kit_root_make_help.rst b/doc/guides/prog_guide/dev_kit_root_make_help.rst > index 4f30192..fdc5fea 100644 > --- a/doc/guides/prog_guide/dev_kit_root_make_help.rst > +++ b/doc/guides/prog_guide/dev_kit_root_make_help.rst > @@ -205,7 +205,7 @@ The following variables can be specified on the command line: > > Enable dependency debugging. This provides some useful information about why a target is built or not. > > -* EXTRA_CFLAGS=, EXTRA_LDFLAGS=, EXTRA_ASFLAGS=, EXTRA_CPPFLAGS= > +* EXTRA_CFLAGS=, EXTRA_LDFLAGS=, EXTRA_LDLIBS=, EXTRA_ASFLAGS=, EXTRA_CPPFLAGS= > > Append specific compilation, link or asm flags. > Do we need to remove LDLIBS from section 28.3.4? With the current patch the value of LDLIBS in the app makefile is lost. Sergio
On 4/29/15, 9:55 AM, "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com> wrote: >On 29/04/2015 15:37, Keith Wiles wrote: >> Signed-off-by: Keith Wiles <keith.wiles@intel.com> >> --- >> doc/build-sdk-quick.txt | 1 + >> doc/guides/prog_guide/dev_kit_build_system.rst | 2 ++ >> doc/guides/prog_guide/dev_kit_root_make_help.rst | 2 +- >> 3 files changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/doc/build-sdk-quick.txt b/doc/build-sdk-quick.txt >> index 041a40e..26d5442 100644 >> --- a/doc/build-sdk-quick.txt >> +++ b/doc/build-sdk-quick.txt >> @@ -13,6 +13,7 @@ Build variables >> EXTRA_CPPFLAGS preprocessor options >> EXTRA_CFLAGS compiler options >> EXTRA_LDFLAGS linker options >> + EXTRA_LDLIBS linker libary options >> RTE_KERNELDIR linux headers path >> CROSS toolchain prefix >> V verbose >> diff --git a/doc/guides/prog_guide/dev_kit_build_system.rst >>b/doc/guides/prog_guide/dev_kit_build_system.rst >> index cf5c96f..b8ef167 100644 >> --- a/doc/guides/prog_guide/dev_kit_build_system.rst >> +++ b/doc/guides/prog_guide/dev_kit_build_system.rst >> @@ -413,6 +413,8 @@ Variables that Can be Set/Overridden by the User in >>a Makefile or Command Line >> >> * EXTRA_LDFLAGS: The content of this variable is appended after >>LDFLAGS when linking. >> >> +* EXTRA_LDLIBS: The content of this variable is appended after >>LDLIBS when linking. >> + >> * EXTRA_ASFLAGS: The content of this variable is appended after >>ASFLAGS when assembling. >> >> * EXTRA_CPPFLAGS: The content of this variable is appended after >>CPPFLAGS when using a C preprocessor on assembly files. >> diff --git a/doc/guides/prog_guide/dev_kit_root_make_help.rst >>b/doc/guides/prog_guide/dev_kit_root_make_help.rst >> index 4f30192..fdc5fea 100644 >> --- a/doc/guides/prog_guide/dev_kit_root_make_help.rst >> +++ b/doc/guides/prog_guide/dev_kit_root_make_help.rst >> @@ -205,7 +205,7 @@ The following variables can be specified on the >>command line: >> >> Enable dependency debugging. This provides some useful >>information about why a target is built or not. >> >> -* EXTRA_CFLAGS=, EXTRA_LDFLAGS=, EXTRA_ASFLAGS=, EXTRA_CPPFLAGS= >> +* EXTRA_CFLAGS=, EXTRA_LDFLAGS=, EXTRA_LDLIBS=, EXTRA_ASFLAGS=, >>EXTRA_CPPFLAGS= >> >> Append specific compilation, link or asm flags. >> >Do we need to remove LDLIBS from section 28.3.4? Missed it, but it should be LDLIBS-y now > >With the current patch the value of LDLIBS in the app makefile is lost. > >Sergio
On 29/04/2015 16:00, Wiles, Keith wrote: > > On 4/29/15, 9:55 AM, "Gonzalez Monroy, Sergio" > <sergio.gonzalez.monroy@intel.com> wrote: > >> On 29/04/2015 15:37, Keith Wiles wrote: >>> Signed-off-by: Keith Wiles <keith.wiles@intel.com> >>> --- >>> doc/build-sdk-quick.txt | 1 + >>> doc/guides/prog_guide/dev_kit_build_system.rst | 2 ++ >>> doc/guides/prog_guide/dev_kit_root_make_help.rst | 2 +- >>> 3 files changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/doc/build-sdk-quick.txt b/doc/build-sdk-quick.txt >>> index 041a40e..26d5442 100644 >>> --- a/doc/build-sdk-quick.txt >>> +++ b/doc/build-sdk-quick.txt >>> @@ -13,6 +13,7 @@ Build variables >>> EXTRA_CPPFLAGS preprocessor options >>> EXTRA_CFLAGS compiler options >>> EXTRA_LDFLAGS linker options >>> + EXTRA_LDLIBS linker libary options >>> RTE_KERNELDIR linux headers path >>> CROSS toolchain prefix >>> V verbose >>> diff --git a/doc/guides/prog_guide/dev_kit_build_system.rst >>> b/doc/guides/prog_guide/dev_kit_build_system.rst >>> index cf5c96f..b8ef167 100644 >>> --- a/doc/guides/prog_guide/dev_kit_build_system.rst >>> +++ b/doc/guides/prog_guide/dev_kit_build_system.rst >>> @@ -413,6 +413,8 @@ Variables that Can be Set/Overridden by the User in >>> a Makefile or Command Line >>> >>> * EXTRA_LDFLAGS: The content of this variable is appended after >>> LDFLAGS when linking. >>> >>> +* EXTRA_LDLIBS: The content of this variable is appended after >>> LDLIBS when linking. >>> + >>> * EXTRA_ASFLAGS: The content of this variable is appended after >>> ASFLAGS when assembling. >>> >>> * EXTRA_CPPFLAGS: The content of this variable is appended after >>> CPPFLAGS when using a C preprocessor on assembly files. >>> diff --git a/doc/guides/prog_guide/dev_kit_root_make_help.rst >>> b/doc/guides/prog_guide/dev_kit_root_make_help.rst >>> index 4f30192..fdc5fea 100644 >>> --- a/doc/guides/prog_guide/dev_kit_root_make_help.rst >>> +++ b/doc/guides/prog_guide/dev_kit_root_make_help.rst >>> @@ -205,7 +205,7 @@ The following variables can be specified on the >>> command line: >>> >>> Enable dependency debugging. This provides some useful >>> information about why a target is built or not. >>> >>> -* EXTRA_CFLAGS=, EXTRA_LDFLAGS=, EXTRA_ASFLAGS=, EXTRA_CPPFLAGS= >>> +* EXTRA_CFLAGS=, EXTRA_LDFLAGS=, EXTRA_LDLIBS=, EXTRA_ASFLAGS=, >>> EXTRA_CPPFLAGS= >>> >>> Append specific compilation, link or asm flags. >>> >> Do we need to remove LDLIBS from section 28.3.4? > Missed it, but it should be LDLIBS-y now It would still be lost cause you are resetting LDLIBS-y value at the start of rte.app.mk, right? The only way to add to LDLIBS-y would be using EXTRA_LDLIBS. Sergio >> With the current patch the value of LDLIBS in the app makefile is lost. >> >> Sergio
On 4/29/15, 10:04 AM, "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com> wrote: >On 29/04/2015 16:00, Wiles, Keith wrote: >> >> On 4/29/15, 9:55 AM, "Gonzalez Monroy, Sergio" >> <sergio.gonzalez.monroy@intel.com> wrote: >> >>> On 29/04/2015 15:37, Keith Wiles wrote: >>>> Signed-off-by: Keith Wiles <keith.wiles@intel.com> >>>> --- >>>> doc/build-sdk-quick.txt | 1 + >>>> doc/guides/prog_guide/dev_kit_build_system.rst | 2 ++ >>>> doc/guides/prog_guide/dev_kit_root_make_help.rst | 2 +- >>>> 3 files changed, 4 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/doc/build-sdk-quick.txt b/doc/build-sdk-quick.txt >>>> index 041a40e..26d5442 100644 >>>> --- a/doc/build-sdk-quick.txt >>>> +++ b/doc/build-sdk-quick.txt >>>> @@ -13,6 +13,7 @@ Build variables >>>> EXTRA_CPPFLAGS preprocessor options >>>> EXTRA_CFLAGS compiler options >>>> EXTRA_LDFLAGS linker options >>>> + EXTRA_LDLIBS linker libary options >>>> RTE_KERNELDIR linux headers path >>>> CROSS toolchain prefix >>>> V verbose >>>> diff --git a/doc/guides/prog_guide/dev_kit_build_system.rst >>>> b/doc/guides/prog_guide/dev_kit_build_system.rst >>>> index cf5c96f..b8ef167 100644 >>>> --- a/doc/guides/prog_guide/dev_kit_build_system.rst >>>> +++ b/doc/guides/prog_guide/dev_kit_build_system.rst >>>> @@ -413,6 +413,8 @@ Variables that Can be Set/Overridden by the User >>>>in >>>> a Makefile or Command Line >>>> >>>> * EXTRA_LDFLAGS: The content of this variable is appended after >>>> LDFLAGS when linking. >>>> >>>> +* EXTRA_LDLIBS: The content of this variable is appended after >>>> LDLIBS when linking. >>>> + >>>> * EXTRA_ASFLAGS: The content of this variable is appended after >>>> ASFLAGS when assembling. >>>> >>>> * EXTRA_CPPFLAGS: The content of this variable is appended after >>>> CPPFLAGS when using a C preprocessor on assembly files. >>>> diff --git a/doc/guides/prog_guide/dev_kit_root_make_help.rst >>>> b/doc/guides/prog_guide/dev_kit_root_make_help.rst >>>> index 4f30192..fdc5fea 100644 >>>> --- a/doc/guides/prog_guide/dev_kit_root_make_help.rst >>>> +++ b/doc/guides/prog_guide/dev_kit_root_make_help.rst >>>> @@ -205,7 +205,7 @@ The following variables can be specified on the >>>> command line: >>>> >>>> Enable dependency debugging. This provides some useful >>>> information about why a target is built or not. >>>> >>>> -* EXTRA_CFLAGS=, EXTRA_LDFLAGS=, EXTRA_ASFLAGS=, EXTRA_CPPFLAGS= >>>> +* EXTRA_CFLAGS=, EXTRA_LDFLAGS=, EXTRA_LDLIBS=, EXTRA_ASFLAGS=, >>>> EXTRA_CPPFLAGS= >>>> >>>> Append specific compilation, link or asm flags. >>>> >>> Do we need to remove LDLIBS from section 28.3.4? >> Missed it, but it should be LDLIBS-y now >It would still be lost cause you are resetting LDLIBS-y value at the >start of rte.app.mk, right? Yes, LDLIBS-y is reset at the top, just as LDLIBS was reset in the original rte.app.mk file. I would assume this is the correct design and we should reset LDLIBS-y at the top of the file, right? >The only way to add to LDLIBS-y would be using EXTRA_LDLIBS. > >Sergio >>> With the current patch the value of LDLIBS in the app makefile is lost. >>> >>> Sergio >
On 29/04/2015 16:16, Wiles, Keith wrote: > > On 4/29/15, 10:04 AM, "Gonzalez Monroy, Sergio" > <sergio.gonzalez.monroy@intel.com> wrote: > >> On 29/04/2015 16:00, Wiles, Keith wrote: >>> On 4/29/15, 9:55 AM, "Gonzalez Monroy, Sergio" >>> <sergio.gonzalez.monroy@intel.com> wrote: >>> >>>> On 29/04/2015 15:37, Keith Wiles wrote: >>>>> Signed-off-by: Keith Wiles <keith.wiles@intel.com> >>>>> --- >>>>> doc/build-sdk-quick.txt | 1 + >>>>> doc/guides/prog_guide/dev_kit_build_system.rst | 2 ++ >>>>> doc/guides/prog_guide/dev_kit_root_make_help.rst | 2 +- >>>>> 3 files changed, 4 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/doc/build-sdk-quick.txt b/doc/build-sdk-quick.txt >>>>> index 041a40e..26d5442 100644 >>>>> --- a/doc/build-sdk-quick.txt >>>>> +++ b/doc/build-sdk-quick.txt >>>>> @@ -13,6 +13,7 @@ Build variables >>>>> EXTRA_CPPFLAGS preprocessor options >>>>> EXTRA_CFLAGS compiler options >>>>> EXTRA_LDFLAGS linker options >>>>> + EXTRA_LDLIBS linker libary options >>>>> RTE_KERNELDIR linux headers path >>>>> CROSS toolchain prefix >>>>> V verbose >>>>> diff --git a/doc/guides/prog_guide/dev_kit_build_system.rst >>>>> b/doc/guides/prog_guide/dev_kit_build_system.rst >>>>> index cf5c96f..b8ef167 100644 >>>>> --- a/doc/guides/prog_guide/dev_kit_build_system.rst >>>>> +++ b/doc/guides/prog_guide/dev_kit_build_system.rst >>>>> @@ -413,6 +413,8 @@ Variables that Can be Set/Overridden by the User >>>>> in >>>>> a Makefile or Command Line >>>>> >>>>> * EXTRA_LDFLAGS: The content of this variable is appended after >>>>> LDFLAGS when linking. >>>>> >>>>> +* EXTRA_LDLIBS: The content of this variable is appended after >>>>> LDLIBS when linking. >>>>> + >>>>> * EXTRA_ASFLAGS: The content of this variable is appended after >>>>> ASFLAGS when assembling. >>>>> >>>>> * EXTRA_CPPFLAGS: The content of this variable is appended after >>>>> CPPFLAGS when using a C preprocessor on assembly files. >>>>> diff --git a/doc/guides/prog_guide/dev_kit_root_make_help.rst >>>>> b/doc/guides/prog_guide/dev_kit_root_make_help.rst >>>>> index 4f30192..fdc5fea 100644 >>>>> --- a/doc/guides/prog_guide/dev_kit_root_make_help.rst >>>>> +++ b/doc/guides/prog_guide/dev_kit_root_make_help.rst >>>>> @@ -205,7 +205,7 @@ The following variables can be specified on the >>>>> command line: >>>>> >>>>> Enable dependency debugging. This provides some useful >>>>> information about why a target is built or not. >>>>> >>>>> -* EXTRA_CFLAGS=, EXTRA_LDFLAGS=, EXTRA_ASFLAGS=, EXTRA_CPPFLAGS= >>>>> +* EXTRA_CFLAGS=, EXTRA_LDFLAGS=, EXTRA_LDLIBS=, EXTRA_ASFLAGS=, >>>>> EXTRA_CPPFLAGS= >>>>> >>>>> Append specific compilation, link or asm flags. >>>>> >>>> Do we need to remove LDLIBS from section 28.3.4? >>> Missed it, but it should be LDLIBS-y now >> It would still be lost cause you are resetting LDLIBS-y value at the >> start of rte.app.mk, right? > Yes, LDLIBS-y is reset at the top, just as LDLIBS was reset in the > original rte.app.mk file. I would assume this is the correct design and we > should reset LDLIBS-y at the top of the file, right? But LDLIBS was not reset pre-patch, was it? # default path for libs -LDLIBS += -L$(RTE_SDK_BIN)/lib +LDLIBS-y = -L$(RTE_SDK_BIN)/lib Sergio >> The only way to add to LDLIBS-y would be using EXTRA_LDLIBS. >> >> Sergio >>>> With the current patch the value of LDLIBS in the app makefile is lost. >>>> >>>> Sergio
On 4/29/15, 10:19 AM, "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com> wrote: >On 29/04/2015 16:16, Wiles, Keith wrote: >> >> On 4/29/15, 10:04 AM, "Gonzalez Monroy, Sergio" >> <sergio.gonzalez.monroy@intel.com> wrote: >> >>> On 29/04/2015 16:00, Wiles, Keith wrote: >>>> On 4/29/15, 9:55 AM, "Gonzalez Monroy, Sergio" >>>> <sergio.gonzalez.monroy@intel.com> wrote: >>>> >>>>> On 29/04/2015 15:37, Keith Wiles wrote: >>>>>> Signed-off-by: Keith Wiles <keith.wiles@intel.com> >>>>>> --- >>>>>> doc/build-sdk-quick.txt | 1 + >>>>>> doc/guides/prog_guide/dev_kit_build_system.rst | 2 ++ >>>>>> doc/guides/prog_guide/dev_kit_root_make_help.rst | 2 +- >>>>>> 3 files changed, 4 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/doc/build-sdk-quick.txt b/doc/build-sdk-quick.txt >>>>>> index 041a40e..26d5442 100644 >>>>>> --- a/doc/build-sdk-quick.txt >>>>>> +++ b/doc/build-sdk-quick.txt >>>>>> @@ -13,6 +13,7 @@ Build variables >>>>>> EXTRA_CPPFLAGS preprocessor options >>>>>> EXTRA_CFLAGS compiler options >>>>>> EXTRA_LDFLAGS linker options >>>>>> + EXTRA_LDLIBS linker libary options >>>>>> RTE_KERNELDIR linux headers path >>>>>> CROSS toolchain prefix >>>>>> V verbose >>>>>> diff --git a/doc/guides/prog_guide/dev_kit_build_system.rst >>>>>> b/doc/guides/prog_guide/dev_kit_build_system.rst >>>>>> index cf5c96f..b8ef167 100644 >>>>>> --- a/doc/guides/prog_guide/dev_kit_build_system.rst >>>>>> +++ b/doc/guides/prog_guide/dev_kit_build_system.rst >>>>>> @@ -413,6 +413,8 @@ Variables that Can be Set/Overridden by the User >>>>>> in >>>>>> a Makefile or Command Line >>>>>> >>>>>> * EXTRA_LDFLAGS: The content of this variable is appended >>>>>>after >>>>>> LDFLAGS when linking. >>>>>> >>>>>> +* EXTRA_LDLIBS: The content of this variable is appended after >>>>>> LDLIBS when linking. >>>>>> + >>>>>> * EXTRA_ASFLAGS: The content of this variable is appended >>>>>>after >>>>>> ASFLAGS when assembling. >>>>>> >>>>>> * EXTRA_CPPFLAGS: The content of this variable is appended >>>>>>after >>>>>> CPPFLAGS when using a C preprocessor on assembly files. >>>>>> diff --git a/doc/guides/prog_guide/dev_kit_root_make_help.rst >>>>>> b/doc/guides/prog_guide/dev_kit_root_make_help.rst >>>>>> index 4f30192..fdc5fea 100644 >>>>>> --- a/doc/guides/prog_guide/dev_kit_root_make_help.rst >>>>>> +++ b/doc/guides/prog_guide/dev_kit_root_make_help.rst >>>>>> @@ -205,7 +205,7 @@ The following variables can be specified on the >>>>>> command line: >>>>>> >>>>>> Enable dependency debugging. This provides some useful >>>>>> information about why a target is built or not. >>>>>> >>>>>> -* EXTRA_CFLAGS=, EXTRA_LDFLAGS=, EXTRA_ASFLAGS=, EXTRA_CPPFLAGS= >>>>>> +* EXTRA_CFLAGS=, EXTRA_LDFLAGS=, EXTRA_LDLIBS=, EXTRA_ASFLAGS=, >>>>>> EXTRA_CPPFLAGS= >>>>>> >>>>>> Append specific compilation, link or asm flags. >>>>>> >>>>> Do we need to remove LDLIBS from section 28.3.4? >>>> Missed it, but it should be LDLIBS-y now >>> It would still be lost cause you are resetting LDLIBS-y value at the >>> start of rte.app.mk, right? >> Yes, LDLIBS-y is reset at the top, just as LDLIBS was reset in the >> original rte.app.mk file. I would assume this is the correct design and >>we >> should reset LDLIBS-y at the top of the file, right? >But LDLIBS was not reset pre-patch, was it? > > # default path for libs >-LDLIBS += -L$(RTE_SDK_BIN)/lib >+LDLIBS-y = -L$(RTE_SDK_BIN)/lib OK, version 4 :-( doing to many things this morning. > > >Sergio >>> The only way to add to LDLIBS-y would be using EXTRA_LDLIBS. >>> >>> Sergio >>>>> With the current patch the value of LDLIBS in the app makefile is >>>>>lost. >>>>> >>>>> Sergio >
diff --git a/doc/build-sdk-quick.txt b/doc/build-sdk-quick.txt index 041a40e..26d5442 100644 --- a/doc/build-sdk-quick.txt +++ b/doc/build-sdk-quick.txt @@ -13,6 +13,7 @@ Build variables EXTRA_CPPFLAGS preprocessor options EXTRA_CFLAGS compiler options EXTRA_LDFLAGS linker options + EXTRA_LDLIBS linker libary options RTE_KERNELDIR linux headers path CROSS toolchain prefix V verbose diff --git a/doc/guides/prog_guide/dev_kit_build_system.rst b/doc/guides/prog_guide/dev_kit_build_system.rst index cf5c96f..b8ef167 100644 --- a/doc/guides/prog_guide/dev_kit_build_system.rst +++ b/doc/guides/prog_guide/dev_kit_build_system.rst @@ -413,6 +413,8 @@ Variables that Can be Set/Overridden by the User in a Makefile or Command Line * EXTRA_LDFLAGS: The content of this variable is appended after LDFLAGS when linking. +* EXTRA_LDLIBS: The content of this variable is appended after LDLIBS when linking. + * EXTRA_ASFLAGS: The content of this variable is appended after ASFLAGS when assembling. * EXTRA_CPPFLAGS: The content of this variable is appended after CPPFLAGS when using a C preprocessor on assembly files. diff --git a/doc/guides/prog_guide/dev_kit_root_make_help.rst b/doc/guides/prog_guide/dev_kit_root_make_help.rst index 4f30192..fdc5fea 100644 --- a/doc/guides/prog_guide/dev_kit_root_make_help.rst +++ b/doc/guides/prog_guide/dev_kit_root_make_help.rst @@ -205,7 +205,7 @@ The following variables can be specified on the command line: Enable dependency debugging. This provides some useful information about why a target is built or not. -* EXTRA_CFLAGS=, EXTRA_LDFLAGS=, EXTRA_ASFLAGS=, EXTRA_CPPFLAGS= +* EXTRA_CFLAGS=, EXTRA_LDFLAGS=, EXTRA_LDLIBS=, EXTRA_ASFLAGS=, EXTRA_CPPFLAGS= Append specific compilation, link or asm flags.