From patchwork Thu Apr 23 13:03:55 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 4454 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 1D55EC36A; Thu, 23 Apr 2015 15:04:08 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C47276A80 for ; Thu, 23 Apr 2015 15:04:01 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 23 Apr 2015 06:04:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,631,1422950400"; d="scan'208";a="718089981" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga002.jf.intel.com with ESMTP; 23 Apr 2015 06:04:01 -0700 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id t3ND3wdX025648; Thu, 23 Apr 2015 14:03:58 +0100 Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id t3ND3wcf009576; Thu, 23 Apr 2015 14:03:58 +0100 Received: (from bricha3@localhost) by sivswdev01.ir.intel.com with id t3ND3wdg009572; Thu, 23 Apr 2015 14:03:58 +0100 From: Bruce Richardson To: dev@dpdk.org Date: Thu, 23 Apr 2015 14:03:55 +0100 Message-Id: <1429794237-9498-7-git-send-email-bruce.richardson@intel.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1429794237-9498-1-git-send-email-bruce.richardson@intel.com> References: <1429794237-9498-1-git-send-email-bruce.richardson@intel.com> Subject: [dpdk-dev] [RFC PATCH 6/8] virtio: remove header inclusion of rte_mbuf.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The virtqueue header files include the mbuf header file, but they do not need to do so as they only use pointers to the struct rte_mbuf type, and do not use any of the mbuf internals, nor any of the mbuf functions or macros. Therefore the inclusion is unnecessary, and can be replaced by a forward declaration of the mbuf type. Signed-off-by: Bruce Richardson --- lib/librte_pmd_virtio/virtqueue.h | 3 ++- lib/librte_pmd_xenvirt/virtqueue.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/librte_pmd_virtio/virtqueue.h b/lib/librte_pmd_virtio/virtqueue.h index 41dda50..9d6079e 100644 --- a/lib/librte_pmd_virtio/virtqueue.h +++ b/lib/librte_pmd_virtio/virtqueue.h @@ -37,7 +37,6 @@ #include #include -#include #include #include #include @@ -46,6 +45,8 @@ #include "virtio_ring.h" #include "virtio_logs.h" +struct rte_mbuf; + /* * Per virtio_config.h in Linux. * For virtio_pci on SMP, we don't need to order with respect to MMIO diff --git a/lib/librte_pmd_xenvirt/virtqueue.h b/lib/librte_pmd_xenvirt/virtqueue.h index 34a24fc..eff6208 100644 --- a/lib/librte_pmd_xenvirt/virtqueue.h +++ b/lib/librte_pmd_xenvirt/virtqueue.h @@ -42,10 +42,11 @@ #include #include #include -#include #include "virtio_logs.h" +struct rte_mbuf; + /* The alignment to use between consumer and producer parts of vring. */ #define VIRTIO_PCI_VRING_ALIGN 4096