From patchwork Thu Apr 23 13:03:51 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 4450 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id EB34F5A67; Thu, 23 Apr 2015 15:04:03 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BC05F5A13 for ; Thu, 23 Apr 2015 15:04:00 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 23 Apr 2015 06:04:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,631,1422950400"; d="scan'208";a="560642746" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga003.jf.intel.com with ESMTP; 23 Apr 2015 06:03:59 -0700 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id t3ND3w30025633; Thu, 23 Apr 2015 14:03:58 +0100 Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id t3ND3vcc009548; Thu, 23 Apr 2015 14:03:57 +0100 Received: (from bricha3@localhost) by sivswdev01.ir.intel.com with id t3ND3vFb009544; Thu, 23 Apr 2015 14:03:57 +0100 From: Bruce Richardson To: dev@dpdk.org Date: Thu, 23 Apr 2015 14:03:51 +0100 Message-Id: <1429794237-9498-3-git-send-email-bruce.richardson@intel.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1429794237-9498-1-git-send-email-bruce.richardson@intel.com> References: <1429794237-9498-1-git-send-email-bruce.richardson@intel.com> Subject: [dpdk-dev] [RFC PATCH 2/8] ethdev: remove inclusion of rte_mbuf.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The ethdev header file includes the mbuf header file, but it does not need to do so as it only uses pointers to the struct rte_mbuf type, and does not use any of the mbuf internals, nor any of the mbuf functions or macros. Therefore the inclusion is unnecessary, and can be replaced by a forward declaration of the mbuf type. Signed-off-by: Bruce Richardson --- lib/librte_ether/rte_ethdev.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 4648290..16dbe00 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -180,10 +180,11 @@ extern "C" { #include #include #include -#include #include "rte_ether.h" #include "rte_eth_ctrl.h" +struct rte_mbuf; + /** * A structure used to retrieve statistics for an Ethernet port. */