From patchwork Thu Apr 23 13:03:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 4456 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id B024E5A67; Thu, 23 Apr 2015 15:05:10 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5183E5A41 for ; Thu, 23 Apr 2015 15:05:08 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 23 Apr 2015 06:03:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,631,1422950400"; d="scan'208";a="699753412" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga001.fm.intel.com with ESMTP; 23 Apr 2015 06:03:58 -0700 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id t3ND3vRu025632; Thu, 23 Apr 2015 14:03:57 +0100 Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id t3ND3vlM009541; Thu, 23 Apr 2015 14:03:57 +0100 Received: (from bricha3@localhost) by sivswdev01.ir.intel.com with id t3ND3vMG009537; Thu, 23 Apr 2015 14:03:57 +0100 From: Bruce Richardson To: dev@dpdk.org Date: Thu, 23 Apr 2015 14:03:50 +0100 Message-Id: <1429794237-9498-2-git-send-email-bruce.richardson@intel.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1429794237-9498-1-git-send-email-bruce.richardson@intel.com> References: <1429794237-9498-1-git-send-email-bruce.richardson@intel.com> Subject: [dpdk-dev] [RFC PATCH 1/8] distributor: remove header inclusion of mbuf.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The distributor header file includes the mbuf header file, but it does not need to do so as it only uses pointers to the struct rte_mbuf type, and does not use any of the mbuf internals, nor any of the mbuf functions or macros. Therefore the inclusion is unnecessary, and can be replaced by a forward declaration of the mbuf type. Signed-off-by: Bruce Richardson --- app/test/test_distributor.c | 2 ++ app/test/test_distributor_perf.c | 3 +++ lib/librte_distributor/rte_distributor.h | 3 +-- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c index 9e8c06d..c8c0942 100644 --- a/app/test/test_distributor.c +++ b/app/test/test_distributor.c @@ -37,6 +37,8 @@ #include #include #include +#include +#include #include #define ITER_POWER 20 /* log 2 of how many iterations we do when timing. */ diff --git a/app/test/test_distributor_perf.c b/app/test/test_distributor_perf.c index 31431bb..234a37e 100644 --- a/app/test/test_distributor_perf.c +++ b/app/test/test_distributor_perf.c @@ -35,7 +35,10 @@ #include #include +#include #include +#include +#include #include #define ITER_POWER 20 /* log 2 of how many iterations we do when timing. */ diff --git a/lib/librte_distributor/rte_distributor.h b/lib/librte_distributor/rte_distributor.h index cc1d559..7d36bc8 100644 --- a/lib/librte_distributor/rte_distributor.h +++ b/lib/librte_distributor/rte_distributor.h @@ -46,11 +46,10 @@ extern "C" { #endif -#include - #define RTE_DISTRIBUTOR_NAMESIZE 32 /**< Length of name for instance */ struct rte_distributor; +struct rte_mbuf; /** * Function to create a new distributor instance