Message ID | 1429171323-33292-1-git-send-email-razamir22@gmail.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 15EE7ADA7; Thu, 16 Apr 2015 10:02:12 +0200 (CEST) Received: from localhost.my.domain (84.95.210.61.forward.012.net.il [84.95.210.61]) by dpdk.org (Postfix) with ESMTP id BD8F22C72 for <dev@dpdk.org>; Thu, 16 Apr 2015 10:02:10 +0200 (CEST) Received: from localhost.my.domain (localhost [127.0.0.1]) by localhost.my.domain (8.14.9/8.14.9) with ESMTP id t3G827oo033331 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 16 Apr 2015 11:02:07 +0300 (IDT) (envelope-from root@localhost.my.domain) Received: (from root@localhost) by localhost.my.domain (8.14.9/8.14.9/Submit) id t3G826Sd033330; Thu, 16 Apr 2015 11:02:06 +0300 (IDT) (envelope-from root) From: Raz Amir <razamir22@gmail.com> To: dev@dpdk.org Date: Thu, 16 Apr 2015 11:02:03 +0300 Message-Id: <1429171323-33292-1-git-send-email-razamir22@gmail.com> X-Mailer: git-send-email 2.1.2 In-Reply-To: <1428450303-97954-1-git-send-email-razamir22@gmail.com> References: <1428450303-97954-1-git-send-email-razamir22@gmail.com> Cc: Raz Amir <razamir22@gmail.com> Subject: [dpdk-dev] [PATCH v6] Restore support for virtio on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Raz Amir
April 16, 2015, 8:02 a.m. UTC
Fixes: 8a312224bcde ("eal/bsd: fix fd leak")
Closing /dev/io fd causes SIGBUS in inb/outb instructions
as the process loses the IOPL privileges once the fd is closed:
(gdb) bt
0 0x0000000000492f2c in outb (port=49170, data=0 '\000')
at /usr/include/machine/cpufunc.h:244
1 0x0000000000492f7a in outb_p (data=0 '\000', port=49170)
at /dpdk/dpdk-2.0.0/lib/librte_pmd_virtio/virtio_pci.h:211
2 0x000000000049328d in vtpci_set_status (hw=0x80331f380, status=0 '\000')
at /dpdk/dpdk-2.0.0/lib/librte_pmd_virtio/virtio_pci.c:130
3 0x00000000004931fe in vtpci_reset (hw=0x80331f380)
at /dpdk/dpdk-2.0.0/lib/librte_pmd_virtio/virtio_pci.c:108
4 0x00000000004a175e in eth_virtio_dev_init (eth_dev=0x831b80 <rte_eth_devices>)
at /dpdk/dpdk-2.0.0/lib/librte_pmd_virtio/virtio_ethdev.c:1150
5 0x0000000000462c09 in rte_eth_dev_init (pci_drv=0x79d1a0 <rte_virtio_pmd>,
pci_dev=0x802417560) at /dpdk/dpdk-2.0.0/lib/librte_ether/rte_ethdev.c:326
6 0x000000000046f03f in rte_eal_pci_probe_one_driver (dr=0x79d1a0 <rte_virtio_pmd>,
dev=0x802417560) at /dpdk/dpdk-2.0.0/lib/librte_eal/bsdapp/eal/eal_pci.c:487
7 0x0000000000475b06 in pci_probe_all_drivers (dev=0x802417560)
at /dpdk/dpdk-2.0.0/lib/librte_eal/common/eal_common_pci.c:116
8 0x0000000000475bb9 in rte_eal_pci_probe ()
at /dpdk/dpdk-2.0.0/lib/librte_eal/common/eal_common_pci.c:246
9 0x000000000046cd63 in rte_eal_init (argc=5, argv=0x7fffffffeaf0)
at /dpdk/dpdk-2.0.0/lib/librte_eal/bsdapp/eal/eal.c:554
10 0x0000000000404544 in main ()
Signed-off-by: Raz Amir <razamir22@gmail.com>
---
lib/librte_eal/bsdapp/eal/eal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Thu, Apr 16, 2015 at 11:02:03AM +0300, Raz Amir wrote: > Fixes: 8a312224bcde ("eal/bsd: fix fd leak") > > Closing /dev/io fd causes SIGBUS in inb/outb instructions > as the process loses the IOPL privileges once the fd is closed: > (gdb) bt > 0 0x0000000000492f2c in outb (port=49170, data=0 '\000') > at /usr/include/machine/cpufunc.h:244 > 1 0x0000000000492f7a in outb_p (data=0 '\000', port=49170) > at /dpdk/dpdk-2.0.0/lib/librte_pmd_virtio/virtio_pci.h:211 > 2 0x000000000049328d in vtpci_set_status (hw=0x80331f380, status=0 '\000') > at /dpdk/dpdk-2.0.0/lib/librte_pmd_virtio/virtio_pci.c:130 > 3 0x00000000004931fe in vtpci_reset (hw=0x80331f380) > at /dpdk/dpdk-2.0.0/lib/librte_pmd_virtio/virtio_pci.c:108 > 4 0x00000000004a175e in eth_virtio_dev_init (eth_dev=0x831b80 <rte_eth_devices>) > at /dpdk/dpdk-2.0.0/lib/librte_pmd_virtio/virtio_ethdev.c:1150 > 5 0x0000000000462c09 in rte_eth_dev_init (pci_drv=0x79d1a0 <rte_virtio_pmd>, > pci_dev=0x802417560) at /dpdk/dpdk-2.0.0/lib/librte_ether/rte_ethdev.c:326 > 6 0x000000000046f03f in rte_eal_pci_probe_one_driver (dr=0x79d1a0 <rte_virtio_pmd>, > dev=0x802417560) at /dpdk/dpdk-2.0.0/lib/librte_eal/bsdapp/eal/eal_pci.c:487 > 7 0x0000000000475b06 in pci_probe_all_drivers (dev=0x802417560) > at /dpdk/dpdk-2.0.0/lib/librte_eal/common/eal_common_pci.c:116 > 8 0x0000000000475bb9 in rte_eal_pci_probe () > at /dpdk/dpdk-2.0.0/lib/librte_eal/common/eal_common_pci.c:246 > 9 0x000000000046cd63 in rte_eal_init (argc=5, argv=0x7fffffffeaf0) > at /dpdk/dpdk-2.0.0/lib/librte_eal/bsdapp/eal/eal.c:554 > 10 0x0000000000404544 in main () > > Signed-off-by: Raz Amir <razamir22@gmail.com> It does look the cleanest solution, though I don't like the idea of leaking the file handle. Can you perhaps just change things a little so that the fd variable is static - even locally in the function will do, as it helps indicate that the fd is persistent. /Bruce > --- > lib/librte_eal/bsdapp/eal/eal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c > index 871d5f4..e20f915 100644 > --- a/lib/librte_eal/bsdapp/eal/eal.c > +++ b/lib/librte_eal/bsdapp/eal/eal.c > @@ -426,7 +426,7 @@ rte_eal_iopl_init(void) > fd = open("/dev/io", O_RDWR); > if (fd < 0) > return -1; > - close(fd); > + /* keep fd open for iopl */ > return 0; > } > > -- > 2.1.2 >
Will do -----Original Message----- From: Bruce Richardson [mailto:bruce.richardson@intel.com] Sent: 16 April 2015 12:39 To: Raz Amir Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6] Restore support for virtio on FreeBSD On Thu, Apr 16, 2015 at 11:02:03AM +0300, Raz Amir wrote: > Fixes: 8a312224bcde ("eal/bsd: fix fd leak") > > Closing /dev/io fd causes SIGBUS in inb/outb instructions as the > process loses the IOPL privileges once the fd is closed: > (gdb) bt > 0 0x0000000000492f2c in outb (port=49170, data=0 '\000') at > /usr/include/machine/cpufunc.h:244 > 1 0x0000000000492f7a in outb_p (data=0 '\000', port=49170) at > /dpdk/dpdk-2.0.0/lib/librte_pmd_virtio/virtio_pci.h:211 > 2 0x000000000049328d in vtpci_set_status (hw=0x80331f380, status=0 > '\000') at /dpdk/dpdk-2.0.0/lib/librte_pmd_virtio/virtio_pci.c:130 > 3 0x00000000004931fe in vtpci_reset (hw=0x80331f380) at > /dpdk/dpdk-2.0.0/lib/librte_pmd_virtio/virtio_pci.c:108 > 4 0x00000000004a175e in eth_virtio_dev_init (eth_dev=0x831b80 > <rte_eth_devices>) at > /dpdk/dpdk-2.0.0/lib/librte_pmd_virtio/virtio_ethdev.c:1150 > 5 0x0000000000462c09 in rte_eth_dev_init (pci_drv=0x79d1a0 > <rte_virtio_pmd>, > pci_dev=0x802417560) at > /dpdk/dpdk-2.0.0/lib/librte_ether/rte_ethdev.c:326 > 6 0x000000000046f03f in rte_eal_pci_probe_one_driver (dr=0x79d1a0 > <rte_virtio_pmd>, > dev=0x802417560) at > /dpdk/dpdk-2.0.0/lib/librte_eal/bsdapp/eal/eal_pci.c:487 > 7 0x0000000000475b06 in pci_probe_all_drivers (dev=0x802417560) at > /dpdk/dpdk-2.0.0/lib/librte_eal/common/eal_common_pci.c:116 > 8 0x0000000000475bb9 in rte_eal_pci_probe () at > /dpdk/dpdk-2.0.0/lib/librte_eal/common/eal_common_pci.c:246 > 9 0x000000000046cd63 in rte_eal_init (argc=5, argv=0x7fffffffeaf0) at > /dpdk/dpdk-2.0.0/lib/librte_eal/bsdapp/eal/eal.c:554 > 10 0x0000000000404544 in main () > > Signed-off-by: Raz Amir <razamir22@gmail.com> It does look the cleanest solution, though I don't like the idea of leaking the file handle. Can you perhaps just change things a little so that the fd variable is static - even locally in the function will do, as it helps indicate that the fd is persistent. /Bruce > --- > lib/librte_eal/bsdapp/eal/eal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/bsdapp/eal/eal.c > b/lib/librte_eal/bsdapp/eal/eal.c index 871d5f4..e20f915 100644 > --- a/lib/librte_eal/bsdapp/eal/eal.c > +++ b/lib/librte_eal/bsdapp/eal/eal.c > @@ -426,7 +426,7 @@ rte_eal_iopl_init(void) > fd = open("/dev/io", O_RDWR); > if (fd < 0) > return -1; > - close(fd); > + /* keep fd open for iopl */ > return 0; > } > > -- > 2.1.2 >
diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c index 871d5f4..e20f915 100644 --- a/lib/librte_eal/bsdapp/eal/eal.c +++ b/lib/librte_eal/bsdapp/eal/eal.c @@ -426,7 +426,7 @@ rte_eal_iopl_init(void) fd = open("/dev/io", O_RDWR); if (fd < 0) return -1; - close(fd); + /* keep fd open for iopl */ return 0; }