Message ID | 1428514670-7982-2-git-send-email-stephen@networkplumber.org (mailing list archive) |
---|---|
State | Rejected, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id E06D05A8C; Wed, 8 Apr 2015 19:37:49 +0200 (CEST) Received: from mail-pd0-f173.google.com (mail-pd0-f173.google.com [209.85.192.173]) by dpdk.org (Postfix) with ESMTP id 33BB7377A for <dev@dpdk.org>; Wed, 8 Apr 2015 19:37:48 +0200 (CEST) Received: by pdbnk13 with SMTP id nk13so122608935pdb.0 for <dev@dpdk.org>; Wed, 08 Apr 2015 10:37:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vyeqD3iq1bQqFm/EJ9uXzYQP9jZWif4X64e3/DXZX4s=; b=dN9ZPIEzqiKOqbOv9s1xMS3W04TAULaPm6p0FIicgPKR3f66WnacQ32nuZ4oNlZ+Uc RROHlGlXLb8SWznKt+NM78oiguhqgUmygJEgRzQAOO7h5cy1Ff9u+NfUP3L8hH/6k9Dj R+YlCbj0SFlh756LCRo7bF3DnCePAikaUWXyQgV59zbqh6X6p3icZ2voZlyjX2AFiaUl kXH40XggXRvgkYZ2bxFNKJmslYwahkl0nb6sI/5E4/Y4BruSRUdfvbRDR0HAI+pXeyMB P7cWz8JDPdnLhCySk+1vzynohHp4oJ1RFqBTYteAfcNyDyLRg4+i1p1XFFoiqjdJBIrd IzKA== X-Gm-Message-State: ALoCoQmzdC0y2kHXHcFQVFYfpdyqESd6yj1eTtRqD8IEQ6ShGxTAW6f0YOHGHTEHZF9z1J+zHbOP X-Received: by 10.68.170.3 with SMTP id ai3mr48454093pbc.19.1428514667538; Wed, 08 Apr 2015 10:37:47 -0700 (PDT) Received: from urahara.brocade.com (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id fe1sm12063054pab.0.2015.04.08.10.37.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 08 Apr 2015 10:37:46 -0700 (PDT) From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Date: Wed, 8 Apr 2015 10:37:49 -0700 Message-Id: <1428514670-7982-2-git-send-email-stephen@networkplumber.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1428514670-7982-1-git-send-email-stephen@networkplumber.org> References: <1428514670-7982-1-git-send-email-stephen@networkplumber.org> Cc: Stephen Hemminger <shemming@brocade.com> Subject: [dpdk-dev] [PATCH 1/2] enic: silence log message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Stephen Hemminger
April 8, 2015, 5:37 p.m. UTC
From: Stephen Hemminger <shemming@brocade.com> Silence is normal. drivers should speak only when spoken to and not be chatty. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> --- lib/librte_pmd_enic/enic_main.c | 2 -- 1 file changed, 2 deletions(-)
Comments
On Wed, Apr 08, 2015 at 10:37:49AM -0700, Stephen Hemminger wrote: > From: Stephen Hemminger <shemming@brocade.com> > > Silence is normal. drivers should speak only when spoken to and not > be chatty. > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Bruce Richardson <bruce.richardson@intel.com> > --- > lib/librte_pmd_enic/enic_main.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/lib/librte_pmd_enic/enic_main.c b/lib/librte_pmd_enic/enic_main.c > index 0892b3e..508621e 100644 > --- a/lib/librte_pmd_enic/enic_main.c > +++ b/lib/librte_pmd_enic/enic_main.c > @@ -1048,8 +1048,6 @@ int enic_probe(struct enic *enic) > struct rte_pci_device *pdev = enic->pdev; > int err = -1; > > - dev_debug(enic, " Initializing ENIC PMD version %s\n", DRV_VERSION); > - > enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr; > enic->bar0.len = pdev->mem_resource[0].len; > > -- > 2.1.4 >
On 19/05/15 3:38 pm, "Bruce Richardson" <bruce.richardson@intel.com> wrote: >On Wed, Apr 08, 2015 at 10:37:49AM -0700, Stephen Hemminger wrote: >> From: Stephen Hemminger <shemming@brocade.com> >> >> Silence is normal. drivers should speak only when spoken to and not >> be chatty. >> >> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > >Acked-by: Bruce Richardson <bruce.richardson@intel.com> > >> --- >> lib/librte_pmd_enic/enic_main.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/lib/librte_pmd_enic/enic_main.c >>b/lib/librte_pmd_enic/enic_main.c >> index 0892b3e..508621e 100644 >> --- a/lib/librte_pmd_enic/enic_main.c >> +++ b/lib/librte_pmd_enic/enic_main.c >> @@ -1048,8 +1048,6 @@ int enic_probe(struct enic *enic) >> struct rte_pci_device *pdev = enic->pdev; >> int err = -1; >> >> - dev_debug(enic, " Initializing ENIC PMD version %s\n", DRV_VERSION); >> - It would be good to retain this under RTE_LIBRTE_ENIC_DEBUG. >> enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr; >> enic->bar0.len = pdev->mem_resource[0].len; >> >> -- >> 2.1.4 >>
Other drivers are quiet, why does this one need to be noisy On Wed, May 20, 2015 at 9:30 AM, Sujith Sankar (ssujith) <ssujith@cisco.com> wrote: > > > On 19/05/15 3:38 pm, "Bruce Richardson" <bruce.richardson@intel.com> > wrote: > > >On Wed, Apr 08, 2015 at 10:37:49AM -0700, Stephen Hemminger wrote: > >> From: Stephen Hemminger <shemming@brocade.com> > >> > >> Silence is normal. drivers should speak only when spoken to and not > >> be chatty. > >> > >> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > > > >Acked-by: Bruce Richardson <bruce.richardson@intel.com> > > > >> --- > >> lib/librte_pmd_enic/enic_main.c | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >> diff --git a/lib/librte_pmd_enic/enic_main.c > >>b/lib/librte_pmd_enic/enic_main.c > >> index 0892b3e..508621e 100644 > >> --- a/lib/librte_pmd_enic/enic_main.c > >> +++ b/lib/librte_pmd_enic/enic_main.c > >> @@ -1048,8 +1048,6 @@ int enic_probe(struct enic *enic) > >> struct rte_pci_device *pdev = enic->pdev; > >> int err = -1; > >> > >> - dev_debug(enic, " Initializing ENIC PMD version %s\n", > DRV_VERSION); > >> - > > It would be good to retain this under RTE_LIBRTE_ENIC_DEBUG. > > >> enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr; > >> enic->bar0.len = pdev->mem_resource[0].len; > >> > >> -- > >> 2.1.4 > >> > >
Stephen, The enic debug flag is off by default. So it is going to print the version only if the user wants it to. IsnĀ¹t that fine? Thanks, -Sujith From: Stephen Hemminger <stephen@networkplumber.org> Date: Wednesday, 20 May 2015 11:17 pm To: "Sujith Sankar (ssujith)" <ssujith@cisco.com> Cc: Bruce Richardson <bruce.richardson@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger <shemming@brocade.com> Subject: Re: [dpdk-dev] [PATCH 1/2] enic: silence log message Other drivers are quiet, why does this one need to be noisy On Wed, May 20, 2015 at 9:30 AM, Sujith Sankar (ssujith) <ssujith@cisco.com> wrote: On 19/05/15 3:38 pm, "Bruce Richardson" <bruce.richardson@intel.com> wrote: >On Wed, Apr 08, 2015 at 10:37:49AM -0700, Stephen Hemminger wrote: >> From: Stephen Hemminger <shemming@brocade.com> >> >> Silence is normal. drivers should speak only when spoken to and not >> be chatty. >> >> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > >Acked-by: Bruce Richardson <bruce.richardson@intel.com> > >> --- >> lib/librte_pmd_enic/enic_main.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/lib/librte_pmd_enic/enic_main.c >>b/lib/librte_pmd_enic/enic_main.c >> index 0892b3e..508621e 100644 >> --- a/lib/librte_pmd_enic/enic_main.c >> +++ b/lib/librte_pmd_enic/enic_main.c >> @@ -1048,8 +1048,6 @@ int enic_probe(struct enic *enic) >> struct rte_pci_device *pdev = enic->pdev; >> int err = -1; >> >> - dev_debug(enic, " Initializing ENIC PMD version %s\n", >>DRV_VERSION); >> - It would be good to retain this under RTE_LIBRTE_ENIC_DEBUG. >> enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr; >> enic->bar0.len = pdev->mem_resource[0].len; >> >> -- >> 2.1.4 >>
diff --git a/lib/librte_pmd_enic/enic_main.c b/lib/librte_pmd_enic/enic_main.c index 0892b3e..508621e 100644 --- a/lib/librte_pmd_enic/enic_main.c +++ b/lib/librte_pmd_enic/enic_main.c @@ -1048,8 +1048,6 @@ int enic_probe(struct enic *enic) struct rte_pci_device *pdev = enic->pdev; int err = -1; - dev_debug(enic, " Initializing ENIC PMD version %s\n", DRV_VERSION); - enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr; enic->bar0.len = pdev->mem_resource[0].len;