diff mbox

[dpdk-dev,v2,1/6] test: remove useless memset

Message ID 1428441663-3825-1-git-send-email-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Headers

Commit Message

Stephen Hemminger April 7, 2015, 9:20 p.m. UTC 
  Remove useless memset, since dev_private is created by rte_zmalloc
it must already be zero.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 app/test/virtual_pmd.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Neil Horman April 8, 2015, 11:49 a.m. UTC | #1 
On Tue, Apr 07, 2015 at 02:20:58PM -0700, Stephen Hemminger wrote:
> Remove useless memset, since dev_private is created by rte_zmalloc
> it must already be zero.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  app/test/virtual_pmd.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c
> index f163562..39ecf80 100644
> --- a/app/test/virtual_pmd.c
> +++ b/app/test/virtual_pmd.c
> @@ -565,8 +565,6 @@ virtual_ethdev_create(const char *name, struct ether_addr *mac_addr,
>  	if (dev_private == NULL)
>  		goto err;
>  
> -	memset(dev_private, 0, sizeof(*dev_private));
> -
>  	snprintf(name_buf, sizeof(name_buf), "%s_rxQ", name);
>  	dev_private->rx_queue = rte_ring_create(name_buf, MAX_PKT_BURST, socket_id,
>  			0);
> -- 
> 2.1.4
> 
> 

For the series
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Thomas Monjalon April 13, 2015, 8:36 p.m. UTC | #2 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> For the series
> Acked-by: Neil Horman <nhorman@tuxdriver.com>

Applied, thanks
diff mbox

Patch

diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c
index f163562..39ecf80 100644
--- a/app/test/virtual_pmd.c
+++ b/app/test/virtual_pmd.c
@@ -565,8 +565,6 @@  virtual_ethdev_create(const char *name, struct ether_addr *mac_addr,
 	if (dev_private == NULL)
 		goto err;
 
-	memset(dev_private, 0, sizeof(*dev_private));
-
 	snprintf(name_buf, sizeof(name_buf), "%s_rxQ", name);
 	dev_private->rx_queue = rte_ring_create(name_buf, MAX_PKT_BURST, socket_id,
 			0);