diff mbox

[dpdk-dev,2/5] bond mode 4: copy entire config structure

Message ID 1428339685-27686-3-git-send-email-ehkinzie@gmail.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Eric Kinzie April 6, 2015, 5:01 p.m. UTC 
  Copy all needed fields from the mode8023ad_private structure in
  bond_mode_8023ad_conf_get().

Signed-off-by: Eric Kinzie <ehkinzie@gmail.com>
---
 lib/librte_pmd_bond/rte_eth_bond_8023ad.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Wodkowski, PawelX April 10, 2015, 7:47 a.m. UTC | #1 
On 2015-04-06 19:01, Eric Kinzie wrote:
>    Copy all needed fields from the mode8023ad_private structure in
>    bond_mode_8023ad_conf_get().
>
> Signed-off-by: Eric Kinzie <ehkinzie@gmail.com>
> ---
>   lib/librte_pmd_bond/rte_eth_bond_8023ad.c |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_pmd_bond/rte_eth_bond_8023ad.c b/lib/librte_pmd_bond/rte_eth_bond_8023ad.c
> index 97a828e..1009d5b 100644
> --- a/lib/librte_pmd_bond/rte_eth_bond_8023ad.c
> +++ b/lib/librte_pmd_bond/rte_eth_bond_8023ad.c
> @@ -1013,6 +1013,7 @@ bond_mode_8023ad_conf_get(struct rte_eth_dev *dev,
>   	conf->aggregate_wait_timeout_ms = mode4->aggregate_wait_timeout / ms_ticks;
>   	conf->tx_period_ms = mode4->tx_period_timeout / ms_ticks;
>   	conf->update_timeout_ms = mode4->update_timeout_us / 1000;
> +	conf->rx_marker_period_ms = mode4->rx_marker_timeout / ms_ticks;
>   }
>
>   void
>

This is bugfix.

Acked-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
Thomas Monjalon April 10, 2015, 7:55 a.m. UTC | #2 
2015-04-10 09:47, Pawel Wodkowski:
> On 2015-04-06 19:01, Eric Kinzie wrote:
> >    Copy all needed fields from the mode8023ad_private structure in
> >    bond_mode_8023ad_conf_get().
> >
> > Signed-off-by: Eric Kinzie <ehkinzie@gmail.com>
> > ---
> >   lib/librte_pmd_bond/rte_eth_bond_8023ad.c |    1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/librte_pmd_bond/rte_eth_bond_8023ad.c b/lib/librte_pmd_bond/rte_eth_bond_8023ad.c
> > index 97a828e..1009d5b 100644
> > --- a/lib/librte_pmd_bond/rte_eth_bond_8023ad.c
> > +++ b/lib/librte_pmd_bond/rte_eth_bond_8023ad.c
> > @@ -1013,6 +1013,7 @@ bond_mode_8023ad_conf_get(struct rte_eth_dev *dev,
> >   	conf->aggregate_wait_timeout_ms = mode4->aggregate_wait_timeout / ms_ticks;
> >   	conf->tx_period_ms = mode4->tx_period_timeout / ms_ticks;
> >   	conf->update_timeout_ms = mode4->update_timeout_us / 1000;
> > +	conf->rx_marker_period_ms = mode4->rx_marker_timeout / ms_ticks;
> >   }
> >
> >   void
> >
> 
> This is bugfix.

When fixing a bug, it's better to explain what was wrong (i.e. behaviour impact)
and to add a tag "Fixes: <commit>".
Thanks

> Acked-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
diff mbox

Patch

diff --git a/lib/librte_pmd_bond/rte_eth_bond_8023ad.c b/lib/librte_pmd_bond/rte_eth_bond_8023ad.c
index 97a828e..1009d5b 100644
--- a/lib/librte_pmd_bond/rte_eth_bond_8023ad.c
+++ b/lib/librte_pmd_bond/rte_eth_bond_8023ad.c
@@ -1013,6 +1013,7 @@  bond_mode_8023ad_conf_get(struct rte_eth_dev *dev,
 	conf->aggregate_wait_timeout_ms = mode4->aggregate_wait_timeout / ms_ticks;
 	conf->tx_period_ms = mode4->tx_period_timeout / ms_ticks;
 	conf->update_timeout_ms = mode4->update_timeout_us / 1000;
+	conf->rx_marker_period_ms = mode4->rx_marker_timeout / ms_ticks;
 }
 
 void