[dpdk-dev,2/5] mk: reduce PDF build commands

Message ID 1428004702-8987-3-git-send-email-thomas.monjalon@6wind.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Thomas Monjalon April 2, 2015, 7:58 p.m. UTC
  In case of documents without image, an empty rm command can be seen if V=1.
Remove it to avoid disturbing debugging.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 mk/rte.sdkdoc.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Siobhan Butler April 3, 2015, 8:20 a.m. UTC | #1
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Thursday, April 2, 2015 8:58 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 2/5] mk: reduce PDF build commands
> 
> In case of documents without image, an empty rm command can be seen if
> V=1.
> Remove it to avoid disturbing debugging.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
>  mk/rte.sdkdoc.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mk/rte.sdkdoc.mk b/mk/rte.sdkdoc.mk index f91e079..9952f25
> 100644
> --- a/mk/rte.sdkdoc.mk
> +++ b/mk/rte.sdkdoc.mk
> @@ -99,7 +99,7 @@ guides-pdf-%:
>  	$(Q)$(RTE_SPHINX_BUILD) -b latex $(RTE_SPHINX_VERBOSE) \
>  		-c $(RTE_SDK)/doc/guides $(RTE_SDK)/doc/guides/$* \
>  		$(RTE_OUTPUT)/doc/pdf/guides/$*
> -	$(Q)rm -f $^
> +	$(if $^,$(Q)rm -f $^)
>  	@echo 'pdflatex processing $@...'
>  	$(Q)$(MAKE) all-pdf -sC $(RTE_OUTPUT)/doc/pdf/guides/$* \
>  		LATEXOPTS=$(RTE_PDFLATEX_VERBOSE)
> --
> 2.2.2
Acked-by Siobhan Butler <siobhan.a.butler@intel.com>
  

Patch

diff --git a/mk/rte.sdkdoc.mk b/mk/rte.sdkdoc.mk
index f91e079..9952f25 100644
--- a/mk/rte.sdkdoc.mk
+++ b/mk/rte.sdkdoc.mk
@@ -99,7 +99,7 @@  guides-pdf-%:
 	$(Q)$(RTE_SPHINX_BUILD) -b latex $(RTE_SPHINX_VERBOSE) \
 		-c $(RTE_SDK)/doc/guides $(RTE_SDK)/doc/guides/$* \
 		$(RTE_OUTPUT)/doc/pdf/guides/$*
-	$(Q)rm -f $^
+	$(if $^,$(Q)rm -f $^)
 	@echo 'pdflatex processing $@...'
 	$(Q)$(MAKE) all-pdf -sC $(RTE_OUTPUT)/doc/pdf/guides/$* \
 		LATEXOPTS=$(RTE_PDFLATEX_VERBOSE)