From patchwork Mon Mar 16 03:43:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tetsuya Mukawa X-Patchwork-Id: 4022 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 28E889AA4; Mon, 16 Mar 2015 04:43:30 +0100 (CET) Received: from mail-pd0-f170.google.com (mail-pd0-f170.google.com [209.85.192.170]) by dpdk.org (Postfix) with ESMTP id AD7DF5ABA for ; Mon, 16 Mar 2015 04:43:28 +0100 (CET) Received: by pdbcz9 with SMTP id cz9so45597960pdb.3 for ; Sun, 15 Mar 2015 20:43:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=IvMQHC/XT/xhetq3cP0394Qx/C240BAaPlSVNhNsZQU=; b=AgwN1DI7Cv2YU68bE5OcRcChIqtDt4A7z4mGb61JvdSCd8kARSnTKDeGygAH8Fc3sZ md8Hd8471HBp1kR/RUWZeV2zUa6Mast7iBX4jSyg51alhLNPc/9sjNi2pazlwjrgIuX5 2/giUE9V+CpkCVykRZmbKDhWwyxjJf6fInqwi4hKXgvXo8mVqLXA6G1adopTjv+JXcs1 3MMV1zaTjwq+KHWUuXJobdsommilbgf2HxKyZWCVKx4CAPnHDKpKG1y20DzWL79KG96a EXu2+xXg8M5SkRbxuWuDKosuG4sHjSRxYYBIauPMwfcwk4pmy6U4lInmDvHKtSA2idaj Axtg== X-Gm-Message-State: ALoCoQnTUB/KziDAg04KHowF7P4RHsPO+nsPOJtQHF6rQHprDTqXM0UAHVGGsnSBXcksfXcgqo1u X-Received: by 10.66.248.132 with SMTP id ym4mr80774923pac.147.1426477408068; Sun, 15 Mar 2015 20:43:28 -0700 (PDT) Received: from localhost.localdomain (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id d4sm14529637pdm.50.2015.03.15.20.43.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 15 Mar 2015 20:43:27 -0700 (PDT) From: Tetsuya Mukawa To: dev@dpdk.org Date: Mon, 16 Mar 2015 12:43:21 +0900 Message-Id: <1426477401-13429-1-git-send-email-mukawa@igel.co.jp> X-Mailer: git-send-email 1.9.1 Subject: [dpdk-dev] [PATCH] null: Fix dereference before null check in eth_null_copy_tx() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch fixes potential null pointer access of eth_null_copy_tx(). Reported-by: Mcnamara, John Signed-off-by: Tetsuya Mukawa --- lib/librte_pmd_null/rte_eth_null.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_pmd_null/rte_eth_null.c b/lib/librte_pmd_null/rte_eth_null.c index 86307eb..8a20c9d 100644 --- a/lib/librte_pmd_null/rte_eth_null.c +++ b/lib/librte_pmd_null/rte_eth_null.c @@ -160,11 +160,12 @@ eth_null_copy_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs) { int i; struct null_queue *h = q; - unsigned packet_size = h->internals->packet_size; + unsigned packet_size; if ((q == NULL) || (bufs == NULL)) return 0; + packet_size = h->internals->packet_size; for (i = 0; i < nb_bufs; i++) { rte_memcpy(h->dummy_packet, rte_pktmbuf_mtod(bufs[i], void *), packet_size);