[dpdk-dev] claim responsibility for KVM virtio PMD, vhost backend, and XEN virtio solution.

  ---
 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)
  

On 3/9/2015 11:45 PM, Huawei Xie wrote:
> ---
>  MAINTAINERS | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 07fdf5e..b4327d3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -131,6 +131,12 @@ F: app/test-pmd/mempool_*
>  F: examples/vhost_xen/
>  F: doc/guides/prog_guide/intel_dpdk_xen_based_packet_switch_sol.rst
>  
> +Linux Xen VIRTIO
> +M: Huawei Xie <huawei.xie@intel.com>
> +F: lib/librte_pmd_xenvirt/
> +F: examples/vhost_xen/
> +F: doc/guides/prog_guide/intel_dpdk_xen_based_packet_switch_sol.rst
> +
>  FreeBSD EAL (with overlaps)
>  M: Bruce Richardson <bruce.richardson@intel.com>
>  F: lib/librte_eal/bsdapp/Makefile
> @@ -226,6 +232,7 @@ F: lib/librte_pmd_mlx4/
>  F: doc/guides/prog_guide/mlx4_poll_mode_drv.rst
>  
>  RedHat virtio
> +M: Huawei Xie <huawei.xie@intel.com>
>  M: Changchun Ouyang <changchun.ouyang@intel.com>
>  F: lib/librte_pmd_virtio/
>  F: doc/guides/prog_guide/poll_mode_drv_emulated_virtio_nic.rst
Thomas:
Comments with this patch? Need i add "MAINTAINERS:" into the subject?

-huawei
  

2015-03-30 08:31, Xie, Huawei:
> On 3/9/2015 11:45 PM, Huawei Xie wrote:
> > ---
> >  MAINTAINERS | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 07fdf5e..b4327d3 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -131,6 +131,12 @@ F: app/test-pmd/mempool_*
> >  F: examples/vhost_xen/
> >  F: doc/guides/prog_guide/intel_dpdk_xen_based_packet_switch_sol.rst
> >  
> > +Linux Xen VIRTIO
> > +M: Huawei Xie <huawei.xie@intel.com>
> > +F: lib/librte_pmd_xenvirt/
> > +F: examples/vhost_xen/
> > +F: doc/guides/prog_guide/intel_dpdk_xen_based_packet_switch_sol.rst
> > +
> >  FreeBSD EAL (with overlaps)
> >  M: Bruce Richardson <bruce.richardson@intel.com>
> >  F: lib/librte_eal/bsdapp/Makefile
> > @@ -226,6 +232,7 @@ F: lib/librte_pmd_mlx4/
> >  F: doc/guides/prog_guide/mlx4_poll_mode_drv.rst
> >  
> >  RedHat virtio
> > +M: Huawei Xie <huawei.xie@intel.com>
> >  M: Changchun Ouyang <changchun.ouyang@intel.com>
> >  F: lib/librte_pmd_virtio/
> >  F: doc/guides/prog_guide/poll_mode_drv_emulated_virtio_nic.rst
> Thomas:
> Comments with this patch? Need i add "MAINTAINERS:" into the subject?

This patch is wrong because you are duplicating an existing section.
I think you want to split Xen support maintenance. If you are sure it's a
good idea, please send a correct patch.
About vhost, maybe you want to split virtio and vhost?
  

On 3/30/2015 8:25 PM, Thomas Monjalon wrote:
> 2015-03-30 08:31, Xie, Huawei:
>> On 3/9/2015 11:45 PM, Huawei Xie wrote:
>>> ---
>>>  MAINTAINERS | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 07fdf5e..b4327d3 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -131,6 +131,12 @@ F: app/test-pmd/mempool_*
>>>  F: examples/vhost_xen/
>>>  F: doc/guides/prog_guide/intel_dpdk_xen_based_packet_switch_sol.rst
>>>  
>>> +Linux Xen VIRTIO
>>> +M: Huawei Xie <huawei.xie@intel.com>
>>> +F: lib/librte_pmd_xenvirt/
>>> +F: examples/vhost_xen/
>>> +F: doc/guides/prog_guide/intel_dpdk_xen_based_packet_switch_sol.rst
>>> +
>>>  FreeBSD EAL (with overlaps)
>>>  M: Bruce Richardson <bruce.richardson@intel.com>
>>>  F: lib/librte_eal/bsdapp/Makefile
>>> @@ -226,6 +232,7 @@ F: lib/librte_pmd_mlx4/
>>>  F: doc/guides/prog_guide/mlx4_poll_mode_drv.rst
>>>  
>>>  RedHat virtio
>>> +M: Huawei Xie <huawei.xie@intel.com>
>>>  M: Changchun Ouyang <changchun.ouyang@intel.com>
>>>  F: lib/librte_pmd_virtio/
>>>  F: doc/guides/prog_guide/poll_mode_drv_emulated_virtio_nic.rst
>> Thomas:
>> Comments with this patch? Need i add "MAINTAINERS:" into the subject?
> This patch is wrong because you are duplicating an existing section.
> I think you want to split Xen support maintenance. If you are sure it's a
> good idea, please send a correct patch.
Yes, i am mainly the author of XEN virtio PMD and host part and would
like to review that part.
Should i split those two sections and move XEN virtio PMD and host part
to driver section?

> About vhost, maybe you want to split virtio and vhost?
>
About vhost, i will maintain those two parts. Is there issue with the
format?
>
  

2015-03-30 14:52, Xie, Huawei:
> On 3/30/2015 8:25 PM, Thomas Monjalon wrote:
> > 2015-03-30 08:31, Xie, Huawei:
> >> On 3/9/2015 11:45 PM, Huawei Xie wrote:
> >>> ---
> >>>  MAINTAINERS | 7 +++++++
> >>>  1 file changed, 7 insertions(+)
> >>>
> >>> diff --git a/MAINTAINERS b/MAINTAINERS
> >>> index 07fdf5e..b4327d3 100644
> >>> --- a/MAINTAINERS
> >>> +++ b/MAINTAINERS
> >>> @@ -131,6 +131,12 @@ F: app/test-pmd/mempool_*
> >>>  F: examples/vhost_xen/
> >>>  F: doc/guides/prog_guide/intel_dpdk_xen_based_packet_switch_sol.rst
> >>>  
> >>> +Linux Xen VIRTIO
> >>> +M: Huawei Xie <huawei.xie@intel.com>
> >>> +F: lib/librte_pmd_xenvirt/
> >>> +F: examples/vhost_xen/
> >>> +F: doc/guides/prog_guide/intel_dpdk_xen_based_packet_switch_sol.rst
> >>> +
> >>>  FreeBSD EAL (with overlaps)
> >>>  M: Bruce Richardson <bruce.richardson@intel.com>
> >>>  F: lib/librte_eal/bsdapp/Makefile
> >>> @@ -226,6 +232,7 @@ F: lib/librte_pmd_mlx4/
> >>>  F: doc/guides/prog_guide/mlx4_poll_mode_drv.rst
> >>>  
> >>>  RedHat virtio
> >>> +M: Huawei Xie <huawei.xie@intel.com>
> >>>  M: Changchun Ouyang <changchun.ouyang@intel.com>
> >>>  F: lib/librte_pmd_virtio/
> >>>  F: doc/guides/prog_guide/poll_mode_drv_emulated_virtio_nic.rst
> >> Thomas:
> >> Comments with this patch? Need i add "MAINTAINERS:" into the subject?
> > 
> > This patch is wrong because you are duplicating an existing section.
> > I think you want to split Xen support maintenance. If you are sure it's a
> > good idea, please send a correct patch.
> 
> Yes, i am mainly the author of XEN virtio PMD and host part and would
> like to review that part.
> Should i split those two sections and move XEN virtio PMD and host part
> to driver section?

Yes you cannot duplicate lib/librte_pmd_xenvirt/.
If you want to split "Linux Xen" section, just do it.
I already explained that to Jijiang. I don't even understand why we have to
discuss it again and again. Please just do the right split.

> > About vhost, maybe you want to split virtio and vhost?
> >
> About vhost, i will maintain those two parts. Is there issue with the
> format?

In my understanding Changchun was maintaining virtio, so I thought you were
interested in vhost only.
  

On 3/30/2015 11:08 PM, Thomas Monjalon wrote:
> 2015-03-30 14:52, Xie, Huawei:
>> On 3/30/2015 8:25 PM, Thomas Monjalon wrote:
>>> 2015-03-30 08:31, Xie, Huawei:
>>>> On 3/9/2015 11:45 PM, Huawei Xie wrote:
>>>>> ---
>>>>>  MAINTAINERS | 7 +++++++
>>>>>  1 file changed, 7 insertions(+)
>>>>>
>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>> index 07fdf5e..b4327d3 100644
>>>>> --- a/MAINTAINERS
>>>>> +++ b/MAINTAINERS
>>>>> @@ -131,6 +131,12 @@ F: app/test-pmd/mempool_*
>>>>>  F: examples/vhost_xen/
>>>>>  F: doc/guides/prog_guide/intel_dpdk_xen_based_packet_switch_sol.rst
>>>>>  
>>>>> +Linux Xen VIRTIO
>>>>> +M: Huawei Xie <huawei.xie@intel.com>
>>>>> +F: lib/librte_pmd_xenvirt/
>>>>> +F: examples/vhost_xen/
>>>>> +F: doc/guides/prog_guide/intel_dpdk_xen_based_packet_switch_sol.rst
>>>>> +
>>>>>  FreeBSD EAL (with overlaps)
>>>>>  M: Bruce Richardson <bruce.richardson@intel.com>
>>>>>  F: lib/librte_eal/bsdapp/Makefile
>>>>> @@ -226,6 +232,7 @@ F: lib/librte_pmd_mlx4/
>>>>>  F: doc/guides/prog_guide/mlx4_poll_mode_drv.rst
>>>>>  
>>>>>  RedHat virtio
>>>>> +M: Huawei Xie <huawei.xie@intel.com>
>>>>>  M: Changchun Ouyang <changchun.ouyang@intel.com>
>>>>>  F: lib/librte_pmd_virtio/
>>>>>  F: doc/guides/prog_guide/poll_mode_drv_emulated_virtio_nic.rst
>>>> Thomas:
>>>> Comments with this patch? Need i add "MAINTAINERS:" into the subject?
>>> This patch is wrong because you are duplicating an existing section.
>>> I think you want to split Xen support maintenance. If you are sure it's a
>>> good idea, please send a correct patch.
>> Yes, i am mainly the author of XEN virtio PMD and host part and would
>> like to review that part.
>> Should i split those two sections and move XEN virtio PMD and host part
>> to driver section?
> Yes you cannot duplicate lib/librte_pmd_xenvirt/.
> If you want to split "Linux Xen" section, just do it.
> I already explained that to Jijiang. I don't even understand why we have to
> discuss it again and again. Please just do the right split.
>
>>> About vhost, maybe you want to split virtio and vhost?
>>>
>> About vhost, i will maintain those two parts. Is there issue with the
>> format?
> In my understanding Changchun was maintaining virtio, so I thought you were
> interested in vhost only.
>
>
>
Is there issue with two co-maintainers?
I was the co-author(with Rashmin) of original static virtio-pmd library,
and would review the patch with changchun  to keep it healthy.
  

2015-03-30 15:23, Xie, Huawei:
> On 3/30/2015 11:08 PM, Thomas Monjalon wrote:
> > 2015-03-30 14:52, Xie, Huawei:
> >> On 3/30/2015 8:25 PM, Thomas Monjalon wrote:
> >>> 2015-03-30 08:31, Xie, Huawei:
> >>>> On 3/9/2015 11:45 PM, Huawei Xie wrote:
> >>>>> ---
> >>>>>  MAINTAINERS | 7 +++++++
> >>>>>  1 file changed, 7 insertions(+)
> >>>>>
> >>>>> diff --git a/MAINTAINERS b/MAINTAINERS
> >>>>> index 07fdf5e..b4327d3 100644
> >>>>> --- a/MAINTAINERS
> >>>>> +++ b/MAINTAINERS
> >>>>> @@ -131,6 +131,12 @@ F: app/test-pmd/mempool_*
> >>>>>  F: examples/vhost_xen/
> >>>>>  F: doc/guides/prog_guide/intel_dpdk_xen_based_packet_switch_sol.rst
> >>>>>  
> >>>>> +Linux Xen VIRTIO
> >>>>> +M: Huawei Xie <huawei.xie@intel.com>
> >>>>> +F: lib/librte_pmd_xenvirt/
> >>>>> +F: examples/vhost_xen/
> >>>>> +F: doc/guides/prog_guide/intel_dpdk_xen_based_packet_switch_sol.rst
> >>>>> +
> >>>>>  FreeBSD EAL (with overlaps)
> >>>>>  M: Bruce Richardson <bruce.richardson@intel.com>
> >>>>>  F: lib/librte_eal/bsdapp/Makefile
> >>>>> @@ -226,6 +232,7 @@ F: lib/librte_pmd_mlx4/
> >>>>>  F: doc/guides/prog_guide/mlx4_poll_mode_drv.rst
> >>>>>  
> >>>>>  RedHat virtio
> >>>>> +M: Huawei Xie <huawei.xie@intel.com>
> >>>>>  M: Changchun Ouyang <changchun.ouyang@intel.com>
> >>>>>  F: lib/librte_pmd_virtio/
> >>>>>  F: doc/guides/prog_guide/poll_mode_drv_emulated_virtio_nic.rst
> >>>> Thomas:
> >>>> Comments with this patch? Need i add "MAINTAINERS:" into the subject?
> >>> This patch is wrong because you are duplicating an existing section.
> >>> I think you want to split Xen support maintenance. If you are sure it's a
> >>> good idea, please send a correct patch.
> >> Yes, i am mainly the author of XEN virtio PMD and host part and would
> >> like to review that part.
> >> Should i split those two sections and move XEN virtio PMD and host part
> >> to driver section?
> > Yes you cannot duplicate lib/librte_pmd_xenvirt/.
> > If you want to split "Linux Xen" section, just do it.
> > I already explained that to Jijiang. I don't even understand why we have to
> > discuss it again and again. Please just do the right split.
> >
> >>> About vhost, maybe you want to split virtio and vhost?
> >>>
> >> About vhost, i will maintain those two parts. Is there issue with the
> >> format?
> > In my understanding Changchun was maintaining virtio, so I thought you were
> > interested in vhost only.
> >
> Is there issue with two co-maintainers?
> I was the co-author(with Rashmin) of original static virtio-pmd library,
> and would review the patch with changchun  to keep it healthy.

No it's OK. I now clearly understand that this part of the patch is right.
You want to co-maintain virtio and vhost. OK
I had a doubt because you failed with Xen split.
  

On 3/30/2015 11:33 PM, Thomas Monjalon wrote:
> 2015-03-30 15:23, Xie, Huawei:
>> On 3/30/2015 11:08 PM, Thomas Monjalon wrote:
>>> 2015-03-30 14:52, Xie, Huawei:
>>>> On 3/30/2015 8:25 PM, Thomas Monjalon wrote:
>>>>> 2015-03-30 08:31, Xie, Huawei:
>>>>>> On 3/9/2015 11:45 PM, Huawei Xie wrote:
>>>>>>> ---
>>>>>>>  MAINTAINERS | 7 +++++++
>>>>>>>  1 file changed, 7 insertions(+)
>>>>>>>
>>>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>>>> index 07fdf5e..b4327d3 100644
>>>>>>> --- a/MAINTAINERS
>>>>>>> +++ b/MAINTAINERS
>>>>>>> @@ -131,6 +131,12 @@ F: app/test-pmd/mempool_*
>>>>>>>  F: examples/vhost_xen/
>>>>>>>  F: doc/guides/prog_guide/intel_dpdk_xen_based_packet_switch_sol.rst
>>>>>>>  
>>>>>>> +Linux Xen VIRTIO
>>>>>>> +M: Huawei Xie <huawei.xie@intel.com>
>>>>>>> +F: lib/librte_pmd_xenvirt/
>>>>>>> +F: examples/vhost_xen/
>>>>>>> +F: doc/guides/prog_guide/intel_dpdk_xen_based_packet_switch_sol.rst
>>>>>>> +
>>>>>>>  FreeBSD EAL (with overlaps)
>>>>>>>  M: Bruce Richardson <bruce.richardson@intel.com>
>>>>>>>  F: lib/librte_eal/bsdapp/Makefile
>>>>>>> @@ -226,6 +232,7 @@ F: lib/librte_pmd_mlx4/
>>>>>>>  F: doc/guides/prog_guide/mlx4_poll_mode_drv.rst
>>>>>>>  
>>>>>>>  RedHat virtio
>>>>>>> +M: Huawei Xie <huawei.xie@intel.com>
>>>>>>>  M: Changchun Ouyang <changchun.ouyang@intel.com>
>>>>>>>  F: lib/librte_pmd_virtio/
>>>>>>>  F: doc/guides/prog_guide/poll_mode_drv_emulated_virtio_nic.rst
>>>>>> Thomas:
>>>>>> Comments with this patch? Need i add "MAINTAINERS:" into the subject?
>>>>> This patch is wrong because you are duplicating an existing section.
>>>>> I think you want to split Xen support maintenance. If you are sure it's a
>>>>> good idea, please send a correct patch.
>>>> Yes, i am mainly the author of XEN virtio PMD and host part and would
>>>> like to review that part.
>>>> Should i split those two sections and move XEN virtio PMD and host part
>>>> to driver section?
>>> Yes you cannot duplicate lib/librte_pmd_xenvirt/.
>>> If you want to split "Linux Xen" section, just do it.
>>> I already explained that to Jijiang. I don't even understand why we have to
>>> discuss it again and again. Please just do the right split.
>>>
>>>>> About vhost, maybe you want to split virtio and vhost?
>>>>>
>>>> About vhost, i will maintain those two parts. Is there issue with the
>>>> format?
>>> In my understanding Changchun was maintaining virtio, so I thought you were
>>> interested in vhost only.
>>>
>> Is there issue with two co-maintainers?
>> I was the co-author(with Rashmin) of original static virtio-pmd library,
>> and would review the patch with changchun  to keep it healthy.
> No it's OK. I now clearly understand that this part of the patch is right.
> You want to co-maintain virtio and vhost. OK
> I had a doubt because you failed with Xen split.
>
>
That explains. Would submit a new patch.