[dpdk-dev] Missing use of macro rte_eth_dev_is_valid_port()
Commit Message
Signed-off-by: Keith Wiles <keith.wiles@intel.com>
---
lib/librte_ether/rte_ethdev.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Comments
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Keith Wiles
> Sent: Thursday, February 26, 2015 2:01 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] Missing use of macro rte_eth_dev_is_valid_port()
>
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
--
> > Signed-off-by: Keith Wiles <keith.wiles@intel.com>
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Some checks with rte_eth_dev_is_valid_port() were missed when merging
hotplug and callbacks features.
Fixes: c282abd2a6cd ("ethdev: remove assumption that port will not be detached")
Applied, thanks
@@ -3541,7 +3541,7 @@ rte_eth_add_rx_callback(uint8_t port_id, uint16_t queue_id,
return NULL;
#endif
/* check input parameters */
- if (port_id >= nb_ports || fn == NULL ||
+ if (!rte_eth_dev_is_valid_port(port_id) || fn == NULL ||
queue_id >= rte_eth_devices[port_id].data->nb_rx_queues) {
rte_errno = EINVAL;
return NULL;
@@ -3570,7 +3570,7 @@ rte_eth_add_tx_callback(uint8_t port_id, uint16_t queue_id,
return NULL;
#endif
/* check input parameters */
- if (port_id >= nb_ports || fn == NULL ||
+ if (!rte_eth_dev_is_valid_port(port_id) || fn == NULL ||
queue_id >= rte_eth_devices[port_id].data->nb_tx_queues) {
rte_errno = EINVAL;
return NULL;
@@ -3598,7 +3598,7 @@ rte_eth_remove_rx_callback(uint8_t port_id, uint16_t queue_id,
return (-ENOTSUP);
#endif
/* Check input parameters. */
- if (port_id >= nb_ports || user_cb == NULL ||
+ if (!rte_eth_dev_is_valid_port(port_id) || user_cb == NULL ||
queue_id >= rte_eth_devices[port_id].data->nb_rx_queues) {
return (-EINVAL);
}
@@ -3637,7 +3637,7 @@ rte_eth_remove_tx_callback(uint8_t port_id, uint16_t queue_id,
return (-ENOTSUP);
#endif
/* Check input parameters. */
- if (port_id >= nb_ports || user_cb == NULL ||
+ if (!rte_eth_dev_is_valid_port(port_id) || user_cb == NULL ||
queue_id >= rte_eth_devices[port_id].data->nb_tx_queues) {
return (-EINVAL);
}