[dpdk-dev,2/5] librte_kvargs: make rte_kvargs_free() be consistent with other "free()" functions
Commit Message
It is desired that all type of *_free() functions mimic behaviour of
libc free() function. This function does nothing if given parameter is
NULL. This patch add this behaviour for rte_kvargs_free().
Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
---
lib/librte_kvargs/rte_kvargs.c | 4 ++++
lib/librte_kvargs/rte_kvargs.h | 3 ++-
2 files changed, 6 insertions(+), 1 deletion(-)
Comments
On 02/23/2015 03:09 PM, Pawel Wodkowski wrote:
> It is desired that all type of *_free() functions mimic behaviour of
> libc free() function. This function does nothing if given parameter is
> NULL. This patch add this behaviour for rte_kvargs_free().
>
> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
@@ -174,8 +174,12 @@ rte_kvargs_process(const struct rte_kvargs *kvlist,
void
rte_kvargs_free(struct rte_kvargs *kvlist)
{
+ if (!kvlist)
+ return;
+
if (kvlist->str != NULL)
free(kvlist->str);
+
free(kvlist);
}
@@ -115,7 +115,8 @@ void rte_kvargs_free(struct rte_kvargs *kvlist);
*
* For each key/value association that matches the given key, calls the
* handler function with the for a given arg_name passing the value on the
- * dictionary for that key and a given extra argument.
+ * dictionary for that key and a given extra argument. If *kvlist* is NULL
+ * function does nothing.
*
* @param kvlist
* The rte_kvargs structure