| Message ID | 1424677885-24171-1-git-send-email-syuu@cloudius-systems.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
> -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Takuya ASADA > Sent: Monday, February 23, 2015 7:51 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] virtio: Add default_txconf > > When I tried to launch test-pmd on KVM guest of Fedora21, I got following > error: > > Configuring Port 0 (socket 0) > Fail to configure port 0 tx queues > EAL: Error - exiting with code: 1 > Cause: Start ports failed > > I found that the error caused here, and actual error message was "TX > checksum offload not supported": > http://dpdk.org/browse/dpdk/tree/lib/librte_pmd_virtio/virtio_rxtx.c#n425 > > This patch adds default_txconf on virtio pmd, to avoid the error. > > Signed-off-by: Takuya ASADA <syuu@cloudius-systems.com> > --- > lib/librte_pmd_virtio/virtio_ethdev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c > b/lib/librte_pmd_virtio/virtio_ethdev.c > index b3b5bb6..9c183bb 100644 > --- a/lib/librte_pmd_virtio/virtio_ethdev.c > +++ b/lib/librte_pmd_virtio/virtio_ethdev.c > @@ -1188,6 +1188,9 @@ virtio_dev_info_get(struct rte_eth_dev *dev, > struct rte_eth_dev_info *dev_info) > dev_info->min_rx_bufsize = VIRTIO_MIN_RX_BUFSIZE; > dev_info->max_rx_pktlen = VIRTIO_MAX_RX_PKTLEN; > dev_info->max_mac_addrs = VIRTIO_MAX_MAC_ADDRS; > + dev_info->default_txconf = (struct rte_eth_txconf) { > + .txq_flags = ETH_TXQ_FLAGS_NOOFFLOADS > + }; > } > > /* > -- > 2.1.0 Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > When I tried to launch test-pmd on KVM guest of Fedora21, I got following > > error: > > > > Configuring Port 0 (socket 0) > > Fail to configure port 0 tx queues > > EAL: Error - exiting with code: 1 > > Cause: Start ports failed > > > > I found that the error caused here, and actual error message was "TX > > checksum offload not supported": > > http://dpdk.org/browse/dpdk/tree/lib/librte_pmd_virtio/virtio_rxtx.c#n425 > > > > This patch adds default_txconf on virtio pmd, to avoid the error. > > > > Signed-off-by: Takuya ASADA <syuu@cloudius-systems.com> > > Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> Applied, thanks
diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c b/lib/librte_pmd_virtio/virtio_ethdev.c index b3b5bb6..9c183bb 100644 --- a/lib/librte_pmd_virtio/virtio_ethdev.c +++ b/lib/librte_pmd_virtio/virtio_ethdev.c @@ -1188,6 +1188,9 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) dev_info->min_rx_bufsize = VIRTIO_MIN_RX_BUFSIZE; dev_info->max_rx_pktlen = VIRTIO_MAX_RX_PKTLEN; dev_info->max_mac_addrs = VIRTIO_MAX_MAC_ADDRS; + dev_info->default_txconf = (struct rte_eth_txconf) { + .txq_flags = ETH_TXQ_FLAGS_NOOFFLOADS + }; } /*
When I tried to launch test-pmd on KVM guest of Fedora21, I got following error: Configuring Port 0 (socket 0) Fail to configure port 0 tx queues EAL: Error - exiting with code: 1 Cause: Start ports failed I found that the error caused here, and actual error message was "TX checksum offload not supported": http://dpdk.org/browse/dpdk/tree/lib/librte_pmd_virtio/virtio_rxtx.c#n425 This patch adds default_txconf on virtio pmd, to avoid the error. Signed-off-by: Takuya ASADA <syuu@cloudius-systems.com> --- lib/librte_pmd_virtio/virtio_ethdev.c | 3 +++ 1 file changed, 3 insertions(+)