[dpdk-dev] fm10k: fix clang warning flags

Message ID 1424282263-28429-1-git-send-email-jeffrey.b.shaw@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Jeff Shaw Feb. 18, 2015, 5:57 p.m. UTC
  This commit fixes the following error which was reported when
compiling with clang by removing the option.

error: unknown warning option '-Wno-unused-but-set-variable'

Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
---
 lib/librte_pmd_fm10k/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Wiles, Keith Feb. 18, 2015, 6:18 p.m. UTC | #1
On 2/18/15, 11:57 AM, "Shaw, Jeffrey B" <jeffrey.b.shaw@intel.com> wrote:

>This commit fixes the following error which was reported when
>compiling with clang by removing the option.
>
>error: unknown warning option '-Wno-unused-but-set-variable'
>
>Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>

Acked-by: keith.wiles@intel.com
>---
> lib/librte_pmd_fm10k/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/lib/librte_pmd_fm10k/Makefile b/lib/librte_pmd_fm10k/Makefile
>index 986f4ef..26663ae 100644
>--- a/lib/librte_pmd_fm10k/Makefile
>+++ b/lib/librte_pmd_fm10k/Makefile
>@@ -55,7 +55,7 @@ else ifeq ($(CC), clang)
> #
> CFLAGS_BASE_DRIVER = -Wno-unused-parameter -Wno-unused-value
> CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -Wno-format-extra-args
>-CFLAGS_BASE_DRIVER += -Wno-unused-variable -Wno-unused-but-set-variable
>+CFLAGS_BASE_DRIVER += -Wno-unused-variable
> CFLAGS_BASE_DRIVER += -Wno-missing-field-initializers
> 
> else
>-- 
>2.1.0
>
  
Thomas Monjalon Feb. 24, 2015, 2:14 a.m. UTC | #2
> >This commit fixes the following error which was reported when
> >compiling with clang by removing the option.
> >
> >error: unknown warning option '-Wno-unused-but-set-variable'
> >
> >Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> 
> Acked-by: keith.wiles@intel.com

Applied, thanks
  

Patch

diff --git a/lib/librte_pmd_fm10k/Makefile b/lib/librte_pmd_fm10k/Makefile
index 986f4ef..26663ae 100644
--- a/lib/librte_pmd_fm10k/Makefile
+++ b/lib/librte_pmd_fm10k/Makefile
@@ -55,7 +55,7 @@  else ifeq ($(CC), clang)
 #
 CFLAGS_BASE_DRIVER = -Wno-unused-parameter -Wno-unused-value
 CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -Wno-format-extra-args
-CFLAGS_BASE_DRIVER += -Wno-unused-variable -Wno-unused-but-set-variable
+CFLAGS_BASE_DRIVER += -Wno-unused-variable
 CFLAGS_BASE_DRIVER += -Wno-missing-field-initializers
 
 else