diff mbox

[dpdk-dev] eal: add rte_eal_iopl_init to version map

Message ID 1423661455-27540-1-git-send-email-sergio.gonzalez.monroy@intel.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Sergio Gonzalez Monroy Feb. 11, 2015, 1:30 p.m. UTC 
  Common rte_eal_iopl_init function is missing from eal version map.

Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
---
 lib/librte_eal/bsdapp/eal/rte_eal_version.map   | 1 +
 lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 +
 2 files changed, 2 insertions(+)

Comments

Thomas Monjalon Feb. 12, 2015, 3:12 p.m. UTC | #1 
2015-02-11 13:30, Sergio Gonzalez Monroy:
> Common rte_eal_iopl_init function is missing from eal version map.

How did you see it?
Thanks

>  	rte_eal_hpet_init;
> +	rte_eal_iopl_init;
>  	rte_eal_init;

You missed the alphabetical order, you were not so far ;)
Sergio Gonzalez Monroy Feb. 12, 2015, 3:18 p.m. UTC | #2 
On 12/02/2015 15:12, Thomas Monjalon wrote:
> 2015-02-11 13:30, Sergio Gonzalez Monroy:
>> Common rte_eal_iopl_init function is missing from eal version map.
> How did you see it?
> Thanks
Building shared libraries and using virtio PMD would result in undefined 
reference symbol.
Should I add it to the commit log?
>>   	rte_eal_hpet_init;
>> +	rte_eal_iopl_init;
>>   	rte_eal_init;
> You missed the alphabetical order, you were not so far ;)
Oh, I did not realize it was alphabetical order, I'll send v2.

Regards,
Sergio
Thomas Monjalon Feb. 12, 2015, 3:28 p.m. UTC | #3 
2015-02-12 15:18, Gonzalez Monroy, Sergio:
> On 12/02/2015 15:12, Thomas Monjalon wrote:
> > 2015-02-11 13:30, Sergio Gonzalez Monroy:
> >> Common rte_eal_iopl_init function is missing from eal version map.
> > How did you see it?
> > Thanks
> Building shared libraries and using virtio PMD would result in undefined 
> reference symbol.
> Should I add it to the commit log?

Yes please.

> >>   	rte_eal_hpet_init;
> >> +	rte_eal_iopl_init;
> >>   	rte_eal_init;
> > You missed the alphabetical order, you were not so far ;)
> Oh, I did not realize it was alphabetical order, I'll send v2.

Thanks
diff mbox

Patch

diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
index d36286e..a5ca65a 100644
--- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
@@ -32,6 +32,7 @@  DPDK_2.0 {
 	rte_eal_get_physmem_size;
 	rte_eal_has_hugepages;
 	rte_eal_hpet_init;
+	rte_eal_iopl_init;
 	rte_eal_init;
 	rte_eal_lcore_role;
 	rte_eal_mp_remote_launch;
diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
index d36286e..a5ca65a 100644
--- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
@@ -32,6 +32,7 @@  DPDK_2.0 {
 	rte_eal_get_physmem_size;
 	rte_eal_has_hugepages;
 	rte_eal_hpet_init;
+	rte_eal_iopl_init;
 	rte_eal_init;
 	rte_eal_lcore_role;
 	rte_eal_mp_remote_launch;