[dpdk-dev] testpmd: remove incorrect parameter limits in help command line

Message ID 1423232572-24509-1-git-send-email-pablo.de.lara.guarch@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

De Lara Guarch, Pablo Feb. 6, 2015, 2:22 p.m. UTC
  Ring threshold parameters an RX/TX queue (pthresh, wthresh and hthresh)
had an incorrect range of values shown in help command line.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 app/test-pmd/parameters.c |   18 ++++++------------
 1 files changed, 6 insertions(+), 12 deletions(-)
  

Comments

Sergio Gonzalez Monroy Feb. 11, 2015, 10:42 a.m. UTC | #1
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Friday, February 6, 2015 2:23 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] testpmd: remove incorrect parameter limits in
> help command line
> 
> Ring threshold parameters an RX/TX queue (pthresh, wthresh and hthresh)
> had an incorrect range of values shown in help command line.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  app/test-pmd/parameters.c |   18 ++++++------------
>  1 files changed, 6 insertions(+), 12 deletions(-)
> 
Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
  
Thomas Monjalon Feb. 15, 2015, 3:56 p.m. UTC | #2
> > Ring threshold parameters an RX/TX queue (pthresh, wthresh and hthresh)
> > had an incorrect range of values shown in help command line.
> > 
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > 
> Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>

Applied, thanks
  

Patch

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index c7105ca..e66153d 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -171,20 +171,14 @@  usage(char* progname)
 	printf("  --txd=N: set the number of descriptors in TX rings to N.\n");
 	printf("  --burst=N: set the number of packets per burst to N.\n");
 	printf("  --mbcache=N: set the cache of mbuf memory pool to N.\n");
-	printf("  --rxpt=N: set prefetch threshold register of RX rings to N "
-	       "(0 <= N <= 16).\n");
-	printf("  --rxht=N: set the host threshold register of RX rings to N "
-	       "(0 <= N <= 16).\n");
+	printf("  --rxpt=N: set prefetch threshold register of RX rings to N.\n");
+	printf("  --rxht=N: set the host threshold register of RX rings to N.\n");
 	printf("  --rxfreet=N: set the free threshold of RX descriptors to N "
 	       "(0 <= N < value of rxd).\n");
-	printf("  --rxwt=N: set the write-back threshold register of RX rings "
-	       "to N (0 <= N <= 16).\n");
-	printf("  --txpt=N: set the prefetch threshold register of TX rings "
-	       "to N (0 <= N <= 16).\n");
-	printf("  --txht=N: set the nhost threshold register of TX rings to N "
-	       "(0 <= N <= 16).\n");
-	printf("  --txwt=N: set the write-back threshold register of TX rings "
-	       "to N (0 <= N <= 16).\n");
+	printf("  --rxwt=N: set the write-back threshold register of RX rings to N.\n");
+	printf("  --txpt=N: set the prefetch threshold register of TX rings to N.\n");
+	printf("  --txht=N: set the nhost threshold register of TX rings to N.\n");
+	printf("  --txwt=N: set the write-back threshold register of TX rings to N.\n");
 	printf("  --txfreet=N: set the transmit free threshold of TX rings to N "
 	       "(0 <= N <= value of txd).\n");
 	printf("  --txrst=N: set the transmit RS bit threshold of TX rings to N "