diff mbox

[dpdk-dev] maintainer: claim review for Xen Dom0 support

Message ID 1423103460-4161-1-git-send-email-jijiang.liu@intel.com (mailing list archive)
State Rejected, archived
Headers show

Commit Message

Jijiang Liu Feb. 5, 2015, 2:31 a.m. UTC
I will be a volunteer of reviewing the following files:
   lib/librte_eal/linuxapp/xen_dom0/*
   lib/librte_eal/linuxapp/eal/eal_xen_memory.c
   lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h

Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
---
 MAINTAINERS |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Thomas Monjalon Feb. 5, 2015, 8:25 a.m. UTC | #1
Hi Jijiang,

2015-02-05 10:31, Jijiang Liu:
> I will be a volunteer of reviewing the following files:
>    lib/librte_eal/linuxapp/xen_dom0/*
>    lib/librte_eal/linuxapp/eal/eal_xen_memory.c
>    lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h

Actually, the section that you are subscribing is wider:
F: lib/librte_eal/linuxapp/xen_dom0/
F: lib/librte_eal/linuxapp/eal/*xen*
F: lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h
F: lib/librte_mempool/rte_dom0_mempool.c
F: lib/librte_pmd_xenvirt/
F: doc/guides/xen/
F: app/test-pmd/mempool_*
F: examples/vhost_xen/

>  Linux Xen
> +M: Jijiang Liu <jijiang.liu@intel.com>

Was your intention to be responsible of the whole Xen area or
only of EAL for Xen?
Jijiang Liu Feb. 5, 2015, 8:34 a.m. UTC | #2
Hi Thomas,


> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, February 05, 2015 4:25 PM
> To: Liu, Jijiang
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] maintainer: claim review for Xen Dom0
> support
> 
> Hi Jijiang,
> 
> 2015-02-05 10:31, Jijiang Liu:
> > I will be a volunteer of reviewing the following files:
> >    lib/librte_eal/linuxapp/xen_dom0/*
> >    lib/librte_eal/linuxapp/eal/eal_xen_memory.c
> >    lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h
> 
> Actually, the section that you are subscribing is wider:
> F: lib/librte_eal/linuxapp/xen_dom0/
> F: lib/librte_eal/linuxapp/eal/*xen*
> F: lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h
> F: lib/librte_mempool/rte_dom0_mempool.c
> F: lib/librte_pmd_xenvirt/
> F: doc/guides/xen/
> F: app/test-pmd/mempool_*
> F: examples/vhost_xen/
> 
> >  Linux Xen
> > +M: Jijiang Liu <jijiang.liu@intel.com>
> 
> Was your intention to be responsible of the whole Xen area or only of EAL for
> Xen?

I just talked this with Xie Huawei, and I know that he will be a volunteer for the following files.
 F: lib/librte_pmd_xenvirt/
 F: doc/guides/xen/
 F: app/test-pmd/mempool_*
 F: examples/vhost_xen/

so I will be responsible for the following files:
 F: lib/librte_eal/linuxapp/xen_dom0/
F: lib/librte_eal/linuxapp/eal/*xen*
 F: lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h
 F: lib/librte_mempool/rte_dom0_mempool.c


> --
> Thomas
Helin Zhang Feb. 9, 2015, 12:41 a.m. UTC | #3
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu
> Sent: Thursday, February 5, 2015 10:31 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] maintainer: claim review for Xen Dom0 support
> 
> 
> I will be a volunteer of reviewing the following files:
>    lib/librte_eal/linuxapp/xen_dom0/*
>    lib/librte_eal/linuxapp/eal/eal_xen_memory.c
>    lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h
> 
> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>

> ---
>  MAINTAINERS |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9a63714..206783d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -110,6 +110,7 @@ Linux VFIO
>  F: lib/librte_eal/linuxapp/eal/*vfio*
> 
>  Linux Xen
> +M: Jijiang Liu <jijiang.liu@intel.com>
>  F: lib/librte_eal/linuxapp/xen_dom0/
>  F: lib/librte_eal/linuxapp/eal/*xen*
>  F: lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h
> --
> 1.7.7.6
Thomas Monjalon March 10, 2015, 4:15 p.m. UTC | #4
2015-02-05 08:34, Liu, Jijiang:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > 2015-02-05 10:31, Jijiang Liu:
> > > I will be a volunteer of reviewing the following files:
> > >    lib/librte_eal/linuxapp/xen_dom0/*
> > >    lib/librte_eal/linuxapp/eal/eal_xen_memory.c
> > >    lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h
> > 
> > Actually, the section that you are subscribing is wider:
> > F: lib/librte_eal/linuxapp/xen_dom0/
> > F: lib/librte_eal/linuxapp/eal/*xen*
> > F: lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h
> > F: lib/librte_mempool/rte_dom0_mempool.c
> > F: lib/librte_pmd_xenvirt/
> > F: doc/guides/xen/
> > F: app/test-pmd/mempool_*
> > F: examples/vhost_xen/
> > 
> > >  Linux Xen
> > > +M: Jijiang Liu <jijiang.liu@intel.com>
> > 
> > Was your intention to be responsible of the whole Xen area or only of EAL for
> > Xen?
> 
> I just talked this with Xie Huawei, and I know that he will be a volunteer for the following files.
>  F: lib/librte_pmd_xenvirt/
>  F: doc/guides/xen/
>  F: app/test-pmd/mempool_*
>  F: examples/vhost_xen/
> 
> so I will be responsible for the following files:
>  F: lib/librte_eal/linuxapp/xen_dom0/
> F: lib/librte_eal/linuxapp/eal/*xen*
>  F: lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h
>  F: lib/librte_mempool/rte_dom0_mempool.c

This patch cannot be accepted because you didn't split the section as described.
Actually, I'm not sure it makes sense to split Xen support maintainance.
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 9a63714..206783d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -110,6 +110,7 @@  Linux VFIO
 F: lib/librte_eal/linuxapp/eal/*vfio*
 
 Linux Xen
+M: Jijiang Liu <jijiang.liu@intel.com>
 F: lib/librte_eal/linuxapp/xen_dom0/
 F: lib/librte_eal/linuxapp/eal/*xen*
 F: lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h