From patchwork Wed Feb 4 09:25:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier Matz X-Patchwork-Id: 2948 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 4487BADDC; Wed, 4 Feb 2015 10:25:48 +0100 (CET) Received: from mail-we0-f172.google.com (mail-we0-f172.google.com [74.125.82.172]) by dpdk.org (Postfix) with ESMTP id 66C78ADBA for ; Wed, 4 Feb 2015 10:25:44 +0100 (CET) Received: by mail-we0-f172.google.com with SMTP id q59so563007wes.3 for ; Wed, 04 Feb 2015 01:25:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=io3gGQV/uRD2i1pVtV5PyumS1azPJyOR5Cky1opwAk0=; b=jhgF7c7qOWMNq/bHOrAx8R7ntuYdpwkNF27I+WQaT0TjP9Bl6snj5Wq0WXRFAe+4bm TARzNddBBO33CNYEIxpnn9LFcGfZavgFNT39v/YgYU8N7gamPVY31XwD38tRF88Q3Aq9 d/WPlMIHtjoYnGHWP3PkiHuMGC3hQRFcT3CIUk4Fc0VH05rQ+8mhkjo1D48qhKKgPVNw t/JUcj05gr0vZqU7S81lim891F5lTirtQvmlXWontW1LOcvdjVf69tbWiNH+U9I7KfE0 xD5kDnQOGDpJkaGKkoJK+3LOqFOsTt4kdjxl8kyQxHSnE0bjoNZ7yoCiyACrAMixjaIG RTiA== X-Gm-Message-State: ALoCoQn3JVdGoryNF+Pbpu2VnHjydZ7mOdhZSodD5rPpnpQB33GEqvYSzGi/SZgeXOkCuHkVteWf X-Received: by 10.194.61.51 with SMTP id m19mr14231381wjr.39.1423041944319; Wed, 04 Feb 2015 01:25:44 -0800 (PST) Received: from glumotte.dev.6wind.com (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id a13sm2346491wic.3.2015.02.04.01.25.43 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 04 Feb 2015 01:25:43 -0800 (PST) From: Olivier Matz To: dev@dpdk.org Date: Wed, 4 Feb 2015 10:25:09 +0100 Message-Id: <1423041925-26956-5-git-send-email-olivier.matz@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1423041925-26956-1-git-send-email-olivier.matz@6wind.com> References: <1422623775-8050-1-git-send-email-olivier.matz@6wind.com> <1423041925-26956-1-git-send-email-olivier.matz@6wind.com> Subject: [dpdk-dev] [PATCH v2 04/20] i40e: remove the use of PKT_TX_UDP_TUNNEL_PKT flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The definition of the flag in rte_mbuf.h was: TX packet is an UDP tunneled packet. It must be specified when using outer checksum offload (PKT_TX_OUTER_IP_CKSUM) This flag was used to tell the NIC that the offload type is UDP (I40E_TXD_CTX_UDP_TUNNELING flag). In the datasheet, it says it's required to specify the tunnel type in the register. However, some tests (see [1]) showed that it also works without this flag. Moreover, it is not explained how the hardware use this information. From a network perspective, this information is useless for calculating the outer IP checksum as it does not depend on the payload. Having this flag in the API would force the application to specify the tunnel type for something that looks only useful for this PMD. It will limit the number of possible tunnel types (we would need a flag for each tunnel type) and therefore prevent to support outer IP checksum for proprietary tunnels. Finally, if a hardware advertises "I support outer IP checksum", it must be supported for any payload types. This has been validated by [2], knowing that the ipip test case was fixed after this test report [3]. [1] http://dpdk.org/ml/archives/dev/2015-January/011380.html [2] http://dpdk.org/ml/archives/dev/2015-January/011475.html [3] http://dpdk.org/ml/archives/dev/2015-January/011610.html Signed-off-by: Olivier Matz --- lib/librte_pmd_i40e/i40e_rxtx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_rxtx.c index 9acdeee..0786255 100644 --- a/lib/librte_pmd_i40e/i40e_rxtx.c +++ b/lib/librte_pmd_i40e/i40e_rxtx.c @@ -482,7 +482,7 @@ i40e_txd_enable_checksum(uint64_t ol_flags, } /* UDP tunneling packet TX checksum offload */ - if (unlikely(ol_flags & PKT_TX_UDP_TUNNEL_PKT)) { + if (unlikely(ol_flags & PKT_TX_OUTER_IP_CKSUM)) { *td_offset |= (outer_l2_len >> 1) << I40E_TX_DESC_LENGTH_MACLEN_SHIFT; @@ -497,7 +497,6 @@ i40e_txd_enable_checksum(uint64_t ol_flags, /* Now set the ctx descriptor fields */ *cd_tunneling |= (outer_l3_len >> 2) << I40E_TXD_CTX_QW0_EXT_IPLEN_SHIFT | - I40E_TXD_CTX_UDP_TUNNELING | (l2_len >> 1) << I40E_TXD_CTX_QW0_NATLEN_SHIFT; @@ -1165,8 +1164,7 @@ i40e_calc_context_desc(uint64_t flags) { uint64_t mask = 0ULL; - if (flags | PKT_TX_UDP_TUNNEL_PKT) - mask |= PKT_TX_UDP_TUNNEL_PKT; + mask |= PKT_TX_OUTER_IP_CKSUM; #ifdef RTE_LIBRTE_IEEE1588 mask |= PKT_TX_IEEE1588_TMST;