diff mbox

[dpdk-dev,v2] bond: fix 'extern "C"' decls in mode4 header files

Message ID 1422624071-12437-1-git-send-email-pawelx.wodkowski@intel.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Wodkowski, PawelX Jan. 30, 2015, 1:21 p.m. UTC
v2:
 Remove 'extern "C"' declarations from bond private header files.

v1:
 Add missing declarations to rte_bond_8023ad.h.

Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
---
 lib/librte_pmd_bond/rte_eth_bond_8023ad.h  | 8 ++++++++
 lib/librte_pmd_bond/rte_eth_bond_private.h | 8 --------
 2 files changed, 8 insertions(+), 8 deletions(-)

Comments

Doherty, Declan Jan. 30, 2015, 1:35 p.m. UTC | #1
On 30/01/15 13:21, Pawel Wodkowski wrote:
> v2:
>   Remove 'extern "C"' declarations from bond private header files.
>
> v1:
>   Add missing declarations to rte_bond_8023ad.h.
>
> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> ---
>   lib/librte_pmd_bond/rte_eth_bond_8023ad.h  | 8 ++++++++
>   lib/librte_pmd_bond/rte_eth_bond_private.h | 8 --------
>   2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/lib/librte_pmd_bond/rte_eth_bond_8023ad.h b/lib/librte_pmd_bond/rte_eth_bond_8023ad.h
> index 9adc6aa..ebd0e93 100644
> --- a/lib/librte_pmd_bond/rte_eth_bond_8023ad.h
> +++ b/lib/librte_pmd_bond/rte_eth_bond_8023ad.h
> @@ -36,6 +36,10 @@
>
>   #include <rte_ether.h>
>
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
>   /**
>    * Actor/partner states
>    */
> @@ -211,4 +215,8 @@ int
>   rte_eth_bond_8023ad_slave_info(uint8_t port_id, uint8_t slave_id,
>   		struct rte_eth_bond_8023ad_slave_info *conf);
>
> +#ifdef __cplusplus
> +}
> +#endif
> +
>   #endif /* RTE_ETH_BOND_8023AD_H_ */
> diff --git a/lib/librte_pmd_bond/rte_eth_bond_private.h b/lib/librte_pmd_bond/rte_eth_bond_private.h
> index e01e66b..3da5a9e 100644
> --- a/lib/librte_pmd_bond/rte_eth_bond_private.h
> +++ b/lib/librte_pmd_bond/rte_eth_bond_private.h
> @@ -34,10 +34,6 @@
>   #ifndef _RTE_ETH_BOND_PRIVATE_H_
>   #define _RTE_ETH_BOND_PRIVATE_H_
>
> -#ifdef __cplusplus
> -extern "C" {
> -#endif
> -
>   #include <rte_ethdev.h>
>   #include <rte_spinlock.h>
>
> @@ -276,8 +272,4 @@ int
>   bond_ethdev_parse_time_ms_kvarg(const char *key __rte_unused,
>   		const char *value, void *extra_args);
>
> -#ifdef __cplusplus
> -}
> -#endif
> -
>   #endif
>

Acked-by: Declan Doherty <declan.doherty@intel.com>
Thomas Monjalon Feb. 2, 2015, 11:34 a.m. UTC | #2
2015-01-30 13:35, Declan Doherty:
> On 30/01/15 13:21, Pawel Wodkowski wrote:
> > v2:
> >   Remove 'extern "C"' declarations from bond private header files.
> >
> > v1:
> >   Add missing declarations to rte_bond_8023ad.h.
> >
> > Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> 
> Acked-by: Declan Doherty <declan.doherty@intel.com>

Applied

Thanks
diff mbox

Patch

diff --git a/lib/librte_pmd_bond/rte_eth_bond_8023ad.h b/lib/librte_pmd_bond/rte_eth_bond_8023ad.h
index 9adc6aa..ebd0e93 100644
--- a/lib/librte_pmd_bond/rte_eth_bond_8023ad.h
+++ b/lib/librte_pmd_bond/rte_eth_bond_8023ad.h
@@ -36,6 +36,10 @@ 
 
 #include <rte_ether.h>
 
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 /**
  * Actor/partner states
  */
@@ -211,4 +215,8 @@  int
 rte_eth_bond_8023ad_slave_info(uint8_t port_id, uint8_t slave_id,
 		struct rte_eth_bond_8023ad_slave_info *conf);
 
+#ifdef __cplusplus
+}
+#endif
+
 #endif /* RTE_ETH_BOND_8023AD_H_ */
diff --git a/lib/librte_pmd_bond/rte_eth_bond_private.h b/lib/librte_pmd_bond/rte_eth_bond_private.h
index e01e66b..3da5a9e 100644
--- a/lib/librte_pmd_bond/rte_eth_bond_private.h
+++ b/lib/librte_pmd_bond/rte_eth_bond_private.h
@@ -34,10 +34,6 @@ 
 #ifndef _RTE_ETH_BOND_PRIVATE_H_
 #define _RTE_ETH_BOND_PRIVATE_H_
 
-#ifdef __cplusplus
-extern "C" {
-#endif
-
 #include <rte_ethdev.h>
 #include <rte_spinlock.h>
 
@@ -276,8 +272,4 @@  int
 bond_ethdev_parse_time_ms_kvarg(const char *key __rte_unused,
 		const char *value, void *extra_args);
 
-#ifdef __cplusplus
-}
-#endif
-
 #endif