From patchwork Fri Jan 30 13:16:14 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier Matz X-Patchwork-Id: 2834 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 53E7E5AD4; Fri, 30 Jan 2015 14:17:42 +0100 (CET) Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 1EA415A9C for ; Fri, 30 Jan 2015 14:16:45 +0100 (CET) Received: by mail-wi0-f177.google.com with SMTP id r20so2605610wiv.4 for ; Fri, 30 Jan 2015 05:16:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=HlX+yug+fQhhr4zIW6jQplbJMMIDqLSMK7s2AoUcPkQ=; b=QrxVq0tBKSrc9noWMS0rDO89bLuIfXd4t0/Gt3NG8O/T4FOK98UjTfL4y40QRuwvlF WegZxOkTKDC0uRRfcyLeWxzE6Ceh1Zl6tGfY1Iyxhy6enoOtG4DXMDqMKtElg+P+g9Nc 6WYaW2aBTjXz9I17CGfn/71w5iqzF+68vK0G1NL61bO/UJGnBLSmE9HCk8lgOGUHK8yM bP0YHpOjLtB8SCXwbTs4kLrk4z4f10fcMRwSAkYg+T2nxE7xdcMlasmnp35+zPnD1RqH 6bWTNrauBF62OlnkgMVvzMC1t/N9sjwK4tdYFzMkMI+GBDH2W478HGhgXaQ7ebW5lQ3x Ly9Q== X-Gm-Message-State: ALoCoQnBv7eX4cmFKAunHwnpXvDn03IhntbRmbb+W4Pg9PzKtsl54IjHrYO0v9vrIXBrF9x4+NQc X-Received: by 10.180.88.33 with SMTP id bd1mr4807995wib.10.1422623804991; Fri, 30 Jan 2015 05:16:44 -0800 (PST) Received: from glumotte.dev.6wind.com (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id li7sm6911300wic.4.2015.01.30.05.16.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 30 Jan 2015 05:16:44 -0800 (PST) From: Olivier Matz To: dev@dpdk.org Date: Fri, 30 Jan 2015 14:16:14 +0100 Message-Id: <1422623775-8050-20-git-send-email-olivier.matz@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1422623775-8050-1-git-send-email-olivier.matz@6wind.com> References: <1421883395-27235-1-git-send-email-olivier.matz@6wind.com> <1422623775-8050-1-git-send-email-olivier.matz@6wind.com> Subject: [dpdk-dev] [PATCH 19/20] i40e: fix offloading of outer checksum for ip in ip tunnels X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When offloading the checksums of ipip tunnels, m->l2_len is set to 0 as there is no tunnel or inner l2 header. Since this is a valid value remove the test. By the way, also remove the same test with l3_len because at this point, it is expected that the software provides proper values in the mbuf. It should avoid a test in dataplane processing and therefore slightly increase performance. Signed-off-by: Olivier Matz --- lib/librte_pmd_i40e/i40e_rxtx.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_rxtx.c index 0786255..3031bd7 100644 --- a/lib/librte_pmd_i40e/i40e_rxtx.c +++ b/lib/librte_pmd_i40e/i40e_rxtx.c @@ -471,16 +471,6 @@ i40e_txd_enable_checksum(uint64_t ol_flags, uint16_t outer_l3_len, uint32_t *cd_tunneling) { - if (!l2_len) { - PMD_DRV_LOG(DEBUG, "L2 length set to 0"); - return; - } - - if (!l3_len) { - PMD_DRV_LOG(DEBUG, "L3 length set to 0"); - return; - } - /* UDP tunneling packet TX checksum offload */ if (unlikely(ol_flags & PKT_TX_OUTER_IP_CKSUM)) {