Message ID | 1421939108-28666-1-git-send-email-cian.ferriter@intel.com (mailing list archive) |
---|---|
State | Changes Requested, archived |
Headers | show |
Hi, 2015-01-22 15:05, Cian Ferriter: > Removes the dependency that this memzone reserve has on the > socket currently running on. Following the socket of the master > core will yield more predictable results when calling this > function after initialisation. You don't describe what is the problem. In another mail, you say "The original suggestion also fixes the crash that I was seeing because of memory being reserved from a numa node with no "--socket-mem" allocated." Please describe it clearly in the commit log. You should also explain what this rte_memzone_reserve() is for, and what are the incidences of your changes. Thanks
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c old mode 100644 new mode 100755 index ea3a1fb..088bffc --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -184,7 +184,7 @@ rte_eth_dev_data_alloc(void) if (rte_eal_process_type() == RTE_PROC_PRIMARY){ mz = rte_memzone_reserve(MZ_RTE_ETH_DEV_DATA, RTE_MAX_ETHPORTS * sizeof(*rte_eth_dev_data), - rte_socket_id(), flags); + rte_lcore_to_socket_id(rte_get_master_lcore()), flags); } else mz = rte_memzone_lookup(MZ_RTE_ETH_DEV_DATA); if (mz == NULL)