From patchwork Wed Jan 21 23:36:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier Matz X-Patchwork-Id: 2440 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id E44535A9A; Thu, 22 Jan 2015 00:36:50 +0100 (CET) Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id A5E075A15 for ; Thu, 22 Jan 2015 00:36:47 +0100 (CET) Received: by mail-wg0-f47.google.com with SMTP id n12so12570367wgh.6 for ; Wed, 21 Jan 2015 15:36:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3p5u/AZAq9zSrjll8HG2xWlH+rtViYSNsb1RKaNlArs=; b=ZvooUsjcnBE31OifInCaXhiBVl4yH7Ki7Ovr+Riw+ju/9XVduQK5+WtG7ef78Mamr0 Ze+RHFApmeryeu0mdZbhp6Q2ppIMxNeSEVxndu3j7BTYzDelPMCRZwwiU1Ec9d/2hbnU l4xIrBoujLXim3wjuANcusQUBpWXmYaIuJryDGMrk3XzbEgWGq4M5fNtX6oXxcccs5Hp mt6jzlGm4uMOs9JGBbFKfT4n+y4swzEBwI9ZzkHwyZ8u0emRqInbXBRpvd8vfPhO6pxO dHFnB6QjMGTQWNxYU31yKfnXnowamuCWOHlxUEyiwLGcdP4B4vnxRe0ZRMORMihzdHRr 8MdQ== X-Gm-Message-State: ALoCoQm/KbFPqGyW9fDhFO4WDjqA5ekesuMLp4HCSgHaaSJdjQjZBBnYYp/bNRmRZvfuWH09jG/6 X-Received: by 10.180.73.108 with SMTP id k12mr61023859wiv.24.1421883407555; Wed, 21 Jan 2015 15:36:47 -0800 (PST) Received: from glumotte.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id wa5sm1710761wjc.8.2015.01.21.15.36.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 21 Jan 2015 15:36:46 -0800 (PST) From: Olivier Matz To: dev@dpdk.org Date: Thu, 22 Jan 2015 00:36:20 +0100 Message-Id: <1421883395-27235-2-git-send-email-olivier.matz@6wind.com> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1421883395-27235-1-git-send-email-olivier.matz@6wind.com> References: <1421883395-27235-1-git-send-email-olivier.matz@6wind.com> Subject: [dpdk-dev] [RFC 01/16] mbuf: remove PKT_TX_IPV4_CSUM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This alias is only used in one place of i40e driver. Remove it and only keep the legacy flag PKT_TX_IP_CSUM. Signed-off-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.h | 1 - lib/librte_pmd_i40e/i40e_rxtx.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 16059c6..a554247 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -142,7 +142,6 @@ extern "C" { #define PKT_TX_L4_MASK (3ULL << 52) /**< Mask for L4 cksum offload request. */ #define PKT_TX_IP_CKSUM (1ULL << 54) /**< IP cksum of TX pkt. computed by NIC. */ -#define PKT_TX_IPV4_CSUM PKT_TX_IP_CKSUM /**< Alias of PKT_TX_IP_CKSUM. */ /** Packet is IPv4 without requiring IP checksum offload. */ #define PKT_TX_IPV4 (1ULL << 55) diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_rxtx.c index 2beae3c..8e9df96 100644 --- a/lib/librte_pmd_i40e/i40e_rxtx.c +++ b/lib/librte_pmd_i40e/i40e_rxtx.c @@ -501,7 +501,7 @@ i40e_txd_enable_checksum(uint64_t ol_flags, << I40E_TX_DESC_LENGTH_MACLEN_SHIFT; /* Enable L3 checksum offloads */ - if (ol_flags & PKT_TX_IPV4_CSUM) { + if (ol_flags & PKT_TX_IP_CKSUM) { *td_cmd |= I40E_TX_DESC_CMD_IIPT_IPV4_CSUM; *td_offset |= (l3_len >> 2) << I40E_TX_DESC_LENGTH_IPLEN_SHIFT; } else if (ol_flags & PKT_TX_IPV4) {