diff mbox

[dpdk-dev] stats: remove useless memset's

Message ID 1421813818-2354-1-git-send-email-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Stephen Hemminger Jan. 21, 2015, 4:16 a.m. UTC
From: Stephen Hemminger <shemming@brocade.com>

The rte_eth_stats_get is the only API that should call the device
statistics function directly, and it already does a memset of the
resulting structure. Therefore doing memset() in the driver is
redundant and should be removed.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_pmd_af_packet/rte_eth_af_packet.c | 2 --
 lib/librte_pmd_bond/rte_eth_bond_pmd.c       | 4 ----
 lib/librte_pmd_enic/enic_main.c              | 1 -
 lib/librte_pmd_i40e/i40e_ethdev_vf.c         | 1 -
 lib/librte_pmd_ixgbe/ixgbe_ethdev.c          | 1 -
 lib/librte_pmd_ring/rte_eth_ring.c           | 1 -
 6 files changed, 10 deletions(-)

Comments

Neil Horman Jan. 21, 2015, 12:43 p.m. UTC | #1
On Tue, Jan 20, 2015 at 08:16:58PM -0800, stephen@networkplumber.org wrote:
> From: Stephen Hemminger <shemming@brocade.com>
> 
> The rte_eth_stats_get is the only API that should call the device
> statistics function directly, and it already does a memset of the
> resulting structure. Therefore doing memset() in the driver is
> redundant and should be removed.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
David Marchand Jan. 21, 2015, 1:08 p.m. UTC | #2
Hello Stephen,

On Wed, Jan 21, 2015 at 5:16 AM, <stephen@networkplumber.org> wrote:

> From: Stephen Hemminger <shemming@brocade.com>
>
> The rte_eth_stats_get is the only API that should call the device
> statistics function directly, and it already does a memset of the
> resulting structure. Therefore doing memset() in the driver is
> redundant and should be removed.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/librte_pmd_af_packet/rte_eth_af_packet.c | 2 --
>  lib/librte_pmd_bond/rte_eth_bond_pmd.c       | 4 ----
>  lib/librte_pmd_enic/enic_main.c              | 1 -
>  lib/librte_pmd_i40e/i40e_ethdev_vf.c         | 1 -
>  lib/librte_pmd_ixgbe/ixgbe_ethdev.c          | 1 -
>  lib/librte_pmd_ring/rte_eth_ring.c           | 1 -
>  6 files changed, 10 deletions(-)
>

I think you missed some :
- lib/librte_pmd_e1000/igb_ethdev.c function eth_igbvf_stats_get()
- lib/librte_pmd_pcap/rte_eth_pcap.c function eth_stats_get()

With these fixed :
Acked-By: David Marchand <david.marchand@6wind.com>
Thomas Monjalon Jan. 27, 2015, 12:06 p.m. UTC | #3
2015-01-21 14:08, David Marchand:
> Hello Stephen,
> 
> > From: Stephen Hemminger <shemming@brocade.com>
> >
> > The rte_eth_stats_get is the only API that should call the device
> > statistics function directly, and it already does a memset of the
> > resulting structure. Therefore doing memset() in the driver is
> > redundant and should be removed.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> >  lib/librte_pmd_af_packet/rte_eth_af_packet.c | 2 --
> >  lib/librte_pmd_bond/rte_eth_bond_pmd.c       | 4 ----
> >  lib/librte_pmd_enic/enic_main.c              | 1 -
> >  lib/librte_pmd_i40e/i40e_ethdev_vf.c         | 1 -
> >  lib/librte_pmd_ixgbe/ixgbe_ethdev.c          | 1 -
> >  lib/librte_pmd_ring/rte_eth_ring.c           | 1 -
> >  6 files changed, 10 deletions(-)
> >
> 
> I think you missed some :
> - lib/librte_pmd_e1000/igb_ethdev.c function eth_igbvf_stats_get()
> - lib/librte_pmd_pcap/rte_eth_pcap.c function eth_stats_get()
> 
> With these fixed :
> Acked-By: David Marchand <david.marchand@6wind.com>

Applied with above fixes.

Thanks
diff mbox

Patch

diff --git a/lib/librte_pmd_af_packet/rte_eth_af_packet.c b/lib/librte_pmd_af_packet/rte_eth_af_packet.c
index 755780a..1ffe1cd 100644
--- a/lib/librte_pmd_af_packet/rte_eth_af_packet.c
+++ b/lib/librte_pmd_af_packet/rte_eth_af_packet.c
@@ -285,8 +285,6 @@  eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
 	unsigned long rx_total = 0, tx_total = 0, tx_err_total = 0;
 	const struct pmd_internals *internal = dev->data->dev_private;
 
-	memset(igb_stats, 0, sizeof(*igb_stats));
-
 	imax = (internal->nb_queues < RTE_ETHDEV_QUEUE_STAT_CNTRS ?
 	        internal->nb_queues : RTE_ETHDEV_QUEUE_STAT_CNTRS);
 	for (i = 0; i < imax; i++) {
diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c b/lib/librte_pmd_bond/rte_eth_bond_pmd.c
index e9cec2a..8b80297 100644
--- a/lib/librte_pmd_bond/rte_eth_bond_pmd.c
+++ b/lib/librte_pmd_bond/rte_eth_bond_pmd.c
@@ -1362,12 +1362,8 @@  bond_ethdev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 {
 	struct bond_dev_private *internals = dev->data->dev_private;
 	struct rte_eth_stats slave_stats;
-
 	int i;
 
-	/* clear bonded stats before populating from slaves */
-	memset(stats, 0, sizeof(*stats));
-
 	for (i = 0; i < internals->slave_count; i++) {
 		rte_eth_stats_get(internals->slaves[i].port_id, &slave_stats);
 
diff --git a/lib/librte_pmd_enic/enic_main.c b/lib/librte_pmd_enic/enic_main.c
index 8ab8e44..48fdca2 100644
--- a/lib/librte_pmd_enic/enic_main.c
+++ b/lib/librte_pmd_enic/enic_main.c
@@ -211,7 +211,6 @@  void enic_dev_stats_get(struct enic *enic, struct rte_eth_stats *r_stats)
 {
 	struct vnic_stats *stats;
 
-	memset(r_stats, 0, sizeof(*r_stats));
 	if (vnic_dev_stats_dump(enic->vdev, &stats)) {
 		dev_err(enic, "Error in getting stats\n");
 		return;
diff --git a/lib/librte_pmd_i40e/i40e_ethdev_vf.c b/lib/librte_pmd_i40e/i40e_ethdev_vf.c
index fe46cf1..7d8d8ef 100644
--- a/lib/librte_pmd_i40e/i40e_ethdev_vf.c
+++ b/lib/librte_pmd_i40e/i40e_ethdev_vf.c
@@ -1673,7 +1673,6 @@  i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 static void
 i40evf_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 {
-	memset(stats, 0, sizeof(*stats));
 	if (i40evf_get_statics(dev, stats))
 		PMD_DRV_LOG(ERR, "Get statics failed");
 }
diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
index b58ec45..e36cdf5 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
@@ -1940,7 +1940,6 @@  ixgbevf_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 	if (stats == NULL)
 		return;
 
-	memset(stats, 0, sizeof(*stats));
 	stats->ipackets = hw_stats->vfgprc;
 	stats->ibytes = hw_stats->vfgorc;
 	stats->opackets = hw_stats->vfgptc;
diff --git a/lib/librte_pmd_ring/rte_eth_ring.c b/lib/librte_pmd_ring/rte_eth_ring.c
index 4f1b6ed..f685f08 100644
--- a/lib/librte_pmd_ring/rte_eth_ring.c
+++ b/lib/librte_pmd_ring/rte_eth_ring.c
@@ -165,7 +165,6 @@  eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
 	unsigned long rx_total = 0, tx_total = 0, tx_err_total = 0;
 	const struct pmd_internals *internal = dev->data->dev_private;
 
-	memset(igb_stats, 0, sizeof(*igb_stats));
 	for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS &&
 			i < internal->nb_rx_queues; i++) {
 		igb_stats->q_ipackets[i] = internal->rx_ring_queues[i].rx_pkts.cnt;