[dpdk-dev] pcap: Fix ethernet device's name for pcap port

Message ID 1421781316-19906-1-git-send-email-repk@triplefau.lt (mailing list archive)
State Accepted, archived
Headers

Commit Message

Remi Pommarel Jan. 20, 2015, 7:15 p.m. UTC
  Ethernet device's data should contain the virtual device name for pcap port.
This name is correctly set by rte_eth_dev_allocate() at initialization time,
but it is directly lost.

Signed-off-by: Remi Pommarel <repk@triplefau.lt>
---
 lib/librte_pmd_pcap/rte_eth_pcap.c | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Thomas Monjalon Jan. 27, 2015, 11:46 a.m. UTC | #1
> Ethernet device's data should contain the virtual device name for pcap port.
> This name is correctly set by rte_eth_dev_allocate() at initialization time,
> but it is directly lost.
> 
> Signed-off-by: Remi Pommarel <repk@triplefau.lt>

Fixes: 83b41136934d ("ethdev: add unique name to devices")
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied

Thanks
  

Patch

diff --git a/lib/librte_pmd_pcap/rte_eth_pcap.c b/lib/librte_pmd_pcap/rte_eth_pcap.c
index f12d1e7..aa01464 100644
--- a/lib/librte_pmd_pcap/rte_eth_pcap.c
+++ b/lib/librte_pmd_pcap/rte_eth_pcap.c
@@ -735,6 +735,7 @@  rte_pmd_init_internals(const char *name, const unsigned nb_rx_queues,
 
 	data->dev_private = *internals;
 	data->port_id = (*eth_dev)->data->port_id;
+	snprintf(data->name, sizeof(data->name), "%s", (*eth_dev)->data->name);
 	data->nb_rx_queues = (uint16_t)nb_rx_queues;
 	data->nb_tx_queues = (uint16_t)nb_tx_queues;
 	data->dev_link = pmd_link;