diff mbox

[dpdk-dev] rte.app.mk: whole-archive should be used with COMBINED_LIB

Message ID 1420228737-23247-1-git-send-email-nhorman@tuxdriver.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Neil Horman Jan. 2, 2015, 7:58 p.m. UTC 
  When building static archives with CONFIG_COMBINED_LIBS, we still need to
specify --whole-archive to pull in all the proper constructors.

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Reported-by: Lyn M <netinal7@gmail.com>
Tested-by: Lyn M <netinal7@gmail.com>
CC: Lyn M <netinal7@gmail.com>
CC: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 mk/rte.app.mk | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Thomas Monjalon Jan. 15, 2015, 1:11 p.m. UTC | #1 
2015-01-02 14:58, Neil Horman:
> When building static archives with CONFIG_COMBINED_LIBS, we still need to
> specify --whole-archive to pull in all the proper constructors.
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> Reported-by: Lyn M <netinal7@gmail.com>
> Tested-by: Lyn M <netinal7@gmail.com>
> CC: Lyn M <netinal7@gmail.com>
> CC: Thomas Monjalon <thomas.monjalon@6wind.com>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied

Thanks
diff mbox

Patch

diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index e1a0dbf..40afb2c 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -61,6 +61,10 @@  ifeq ($(NO_AUTOLIBS),)
 
 LDLIBS += --whole-archive
 
+ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y)
+LDLIBS += -l$(RTE_LIBNAME)
+endif
+
 ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)
 
 ifeq ($(CONFIG_RTE_LIBRTE_DISTRIBUTOR),y)
@@ -251,10 +255,6 @@  build: _postbuild
 
 exe2cmd = $(strip $(call dotfile,$(patsubst %,%.cmd,$(1))))
 
-ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y)
-LDLIBS += -l$(RTE_LIBNAME)
-endif
-
 ifeq ($(LINK_USING_CC),1)
 override EXTRA_LDFLAGS := $(call linkerprefix,$(EXTRA_LDFLAGS))
 O_TO_EXE = $(CC) $(CFLAGS) $(LDFLAGS_$(@)) \