diff mbox

[dpdk-dev] test: fix macro by adding in missing "do" in do-while

Message ID 1418836013-19030-1-git-send-email-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Bruce Richardson Dec. 17, 2014, 5:06 p.m. UTC 
  One of the test assertion macros was missing the "do" part of the
do-while. This issue was picked up by clang reporting an empty while
loop body for the closing while of the do-while pair.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 app/test/test.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon Dec. 17, 2014, 11:45 p.m. UTC | #1 
2014-12-17 17:06, Bruce Richardson:
> One of the test assertion macros was missing the "do" part of the
> do-while. This issue was picked up by clang reporting an empty while
> loop body for the closing while of the do-while pair.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Applied

Thanks
diff mbox

Patch

diff --git a/app/test/test.h b/app/test/test.h
index 72e67b9..896f7db 100644
--- a/app/test/test.h
+++ b/app/test/test.h
@@ -44,7 +44,7 @@ 
 		}														\
 } while (0)
 
-#define TEST_ASSERT_EQUAL(a, b, msg, ...)  {					\
+#define TEST_ASSERT_EQUAL(a, b, msg, ...) do {					\
 		if (!(a == b)) {										\
 			printf("TestCase %s() line %d failed: "				\
 				msg "\n", __func__, __LINE__, ##__VA_ARGS__);	\